ASoC: odroid: Add missing properties
Krzysztof Kozlowski
maintainerPATCH 4/4 ARM: dts: exynos: Add clocks sound node in Exynos5422 Odroid XU4
In reply to Krzysztof KozlowskiThe dtschema expects "clocks" property if "assigned-clocks" are used. Add reference to all parent clocks to silence the dtbs_check warnings.
--- arch/arm/boot/dts/exynos5422-odroidxu4.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/exynos5422-odroidxu4.dts +5 -0
@@ -44,6 +44,11 @@ <&clock_audss EXYNOS_DOUT_AUD_BUS>, <&clock_audss EXYNOS_DOUT_I2S>; + clocks = <&clock CLK_FOUT_EPLL>, + <&clock CLK_MOUT_EPLL>, + <&clock CLK_MOUT_MAU_EPLL>, + <&clock CLK_MAU_EPLL>, + <&clock_audss EXYNOS_MOUT_AUDSS>; assigned-clock-parents = <&clock CLK_FOUT_EPLL>, <&clock CLK_MOUT_EPLL>, <&clock CLK_MOUT_MAU_EPLL>,
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 3/4 arm64: dts: exynos: Remove undocumented i2s properties in Exynos5433
In reply to Krzysztof KozlowskiFew I2S device node properties were not documented and not used by any of the drivers. Remove them to fix dtbs_check warning:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@14d60000:
Additional properties are not allowed ('samsung,supports-rstclr', 'samsung,supports-tdm', 'samsung,supports-6ch', 'samsung,supports-low-rfs' were unexpected)
--- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ---- 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +0 -4
@@ -1460,10 +1460,6 @@ <&cmu_peric CLK_SCLK_I2S1>; clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; #clock-cells = <1>; - samsung,supports-6ch; - samsung,supports-rstclr; - samsung,supports-tdm; - samsung,supports-low-rfs; #sound-dai-cells = <1>; status = "disabled"; };
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 2/4 ASoC: samsung-i2s: Add missing properties
In reply to Krzysztof KozlowskiUsage of "unevaluatedProperties: false" is not correct as it suppresses warnings about all undocumented properties. Instead, add all missing properties.
---
--- .../devicetree/bindings/sound/samsung-i2s.yaml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/samsung-i2s.yaml +16 -1
@@ -41,6 +41,12 @@ properties: - samsung,exynos7-i2s - samsung,exynos7-i2s1 + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + reg: maxItems: 1
@@ -58,6 +64,9 @@ properties: - const: rx - const: tx-sec + assigned-clock-parents: true + assigned-clocks: true + clocks: minItems: 1 maxItems: 3
@@ -92,6 +101,9 @@ properties: - const: i2s_cdclk2 description: Names of the CDCLK I2S output clocks. + interrupts: + maxItems: 1 + samsung,idma-addr: $ref: /schemas/types.yaml#/definitions/uint32 description: |
@@ -104,6 +116,9 @@ properties: pinctrl-names: const: default + power-domains: + maxItems: 1 + "#sound-dai-cells": const: 1
@@ -115,7 +130,7 @@ required: - clocks - clock-names -unevaluatedProperties: false +additionalProperties: false examples: - |
Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerPATCH 1/4 ASoC: odroid: Add missing properties
Usage of "unevaluatedProperties: false" is not correct as it suppresses warnings about all undocumented properties. Instead, add all missing properties.
---
Fixup for:
https://lore.kernel.org/lkml/[email protected]/
--- .../devicetree/bindings/sound/samsung,odroid.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/sound/samsung,odroid.yaml +6 -1
@@ -28,6 +28,11 @@ properties: $ref: /schemas/types.yaml#/definitions/string description: The user-visible name of this sound complex. + assigned-clock-parents: true + assigned-clock-rates: true + assigned-clocks: true + clocks: true + cpu: type: object properties:
@@ -69,7 +74,7 @@ required: - cpu - codec -unevaluatedProperties: false +additionalProperties: false examples: - |
Signature · 1 line
2.17.1
Mark Brown
maintainerQuoted 3 lines · Krzysztof Kozlowski
Usage of "unevaluatedProperties: false" is not correct as it suppresses warnings about all undocumented properties. Instead, add all missing properties.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: odroid: Add missing properties
commit: 6997e462b39b5041e6e4b9d547ebbcacb69052ae
[2/2] ASoC: samsung-i2s: Add missing properties
commit: 0c5f8ca49cff1e2e18300cca4fb0c17ba794dcb0All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Re: [PATCH 3/4] arm64: dts: exynos: Remove undocumented i2s properties in Exynos5433
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
Few I2S device node properties were not documented and not used by any of the drivers. Remove them to fix
dtbs_checkwarning:
arch/arm64/boot/dts/exynos/exynos5433-tm2.dt.yaml: i2s@14d60000:
Additional properties are not allowed ('samsung,supports-rstclr', 'samsung,supports-tdm', 'samsung,supports-6ch', 'samsung,supports-low-rfs' were unexpected)Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ----
Applied.
Best regards,
Krzysztof