fs/ocfs2/cluster/heartbeat.c:1796 o2hb_region_dev_store() error: potentially dereferencing uninitialized 'inode'.
PATCH 54/69 fs/ocfs2/cluster/heartbeat.c:1796 o2hb_region_dev_store() error: potentially dereferencing uninitialized 'inode'.
tree: git://git.infradead.org/users/hch/block.git bdev-inode head: bb70760fe2c3439fd1029218578c17786a9a6d2c commit: 734aab48f144821958bc99c90d333ad5dd91beaf [54/69] ocfs2: cleanup o2hb_region_dev_store config: x86_64-randconfig-m001-20200903 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>
smatch warnings:fs/ocfs2/cluster/heartbeat.c:1796 o2hb_region_dev_store() error: potentially dereferencing uninitialized 'inode'.
git remote add hch-block git://git.infradead.org/users/hch/block.git
git fetch --no-tags hch-block bdev-inode
git checkout 734aab48f144821958bc99c90d333ad5dd91beaf
vim +/inode +1796 fs/ocfs2/cluster/heartbeat.c
45b997737a8025b Christoph Hellwig 2015-10-03 1759 static ssize_t o2hb_region_dev_store(struct config_item *item,
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1760 const char *page,
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1761 size_t count)
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1762 {
45b997737a8025b Christoph Hellwig 2015-10-03 1763 struct o2hb_region *reg = to_o2hb_region(item);
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1764 struct task_struct *hb_task;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1765 long fd;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1766 int sectsize;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1767 char *p = (char *)page;
2903ff019b346ab Al Viro 2012-08-28 1768 struct fd f;
2903ff019b346ab Al Viro 2012-08-28 1769 struct inode *inode;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1770 ssize_t ret = -EINVAL;
76d9fc2954d057b Sunil Mushran 2011-05-04 1771 int live_threshold;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1772
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1773 if (reg->hr_bdev)
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1774 goto out;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1775
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1776 /* We can't heartbeat without having had our node number
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1777 * configured yet. */
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1778 if (o2nm_this_node() == O2NM_MAX_NODES)
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1779 goto out;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1780
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1781 fd = simple_strtol(p, &p, 0);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1782 if (!p || (*p && (*p != '\n')))
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1783 goto out;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1784
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1785 if (fd < 0 || fd >= INT_MAX)
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1786 goto out;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1787
2903ff019b346ab Al Viro 2012-08-28 1788 f = fdget(fd);
2903ff019b346ab Al Viro 2012-08-28 1789 if (f.file == NULL)
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1790 goto out;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1791
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1792 if (reg->hr_blocks == 0 || reg->hr_start_block == 0 ||
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1793 reg->hr_block_bytes == 0)
2903ff019b346ab Al Viro 2012-08-28 1794 goto out2;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1795
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 @1796 if (!S_ISBLK(inode->i_mode))
^^^^^^^^^^^^^"inode" is uninitialized.
734aab48f144821 Christoph Hellwig 2020-09-03 1797 goto out2;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1798
734aab48f144821 Christoph Hellwig 2020-09-03 1799 reg->hr_bdev = blkdev_get_by_dev(inode->i_rdev,
734aab48f144821 Christoph Hellwig 2020-09-03 1800 FMODE_WRITE | FMODE_READ, NULL);
734aab48f144821 Christoph Hellwig 2020-09-03 1801 if (IS_ERR(reg->hr_bdev)) {
734aab48f144821 Christoph Hellwig 2020-09-03 1802 ret = PTR_ERR(reg->hr_bdev);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1803 reg->hr_bdev = NULL;
734aab48f144821 Christoph Hellwig 2020-09-03 1804 goto out2;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1805 }
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1806 inode = NULL;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1807
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1808 bdevname(reg->hr_bdev, reg->hr_dev_name);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1809
e1defc4ff0cf57a Martin K. Petersen 2009-05-22 1810 sectsize = bdev_logical_block_size(reg->hr_bdev);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1811 if (sectsize != reg->hr_block_bytes) {
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1812 mlog(ML_ERROR,
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1813 "blocksize %u incorrect for device, expected %d",
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1814 reg->hr_block_bytes, sectsize);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1815 ret = -EINVAL;
2903ff019b346ab Al Viro 2012-08-28 1816 goto out3;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1817 }
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1818
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1819 o2hb_init_region_params(reg);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1820
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1821 /* Generation of zero is invalid */
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1822 do {
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1823 get_random_bytes(®->hr_generation,
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1824 sizeof(reg->hr_generation));
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1825 } while (reg->hr_generation == 0);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1826
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1827 ret = o2hb_map_slot_data(reg);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1828 if (ret) {
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1829 mlog_errno(ret);
2903ff019b346ab Al Viro 2012-08-28 1830 goto out3;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1831 }
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1832
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1833 ret = o2hb_populate_slot_data(reg);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1834 if (ret) {
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1835 mlog_errno(ret);
2903ff019b346ab Al Viro 2012-08-28 1836 goto out3;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1837 }
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1838
c4028958b6ecad0 David Howells 2006-11-22 1839 INIT_DELAYED_WORK(®->hr_write_timeout_work, o2hb_write_timeout);
e0cbb79805083b8 Junxiao Bi 2016-05-27 1840 INIT_DELAYED_WORK(®->hr_nego_timeout_work, o2hb_nego_timeout);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1841
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1842 /*
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1843 * A node is considered live after it has beat LIVE_THRESHOLD
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1844 * times. We're not steady until we've given them a chance
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1845 * _after_ our first read.
76d9fc2954d057b Sunil Mushran 2011-05-04 1846 * The default threshold is bare minimum so as to limit the delay
76d9fc2954d057b Sunil Mushran 2011-05-04 1847 * during mounts. For global heartbeat, the threshold doubled for the
76d9fc2954d057b Sunil Mushran 2011-05-04 1848 * first region.
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1849 */
76d9fc2954d057b Sunil Mushran 2011-05-04 1850 live_threshold = O2HB_LIVE_THRESHOLD;
76d9fc2954d057b Sunil Mushran 2011-05-04 1851 if (o2hb_global_heartbeat_active()) {
76d9fc2954d057b Sunil Mushran 2011-05-04 1852 spin_lock(&o2hb_live_lock);
a8f70de37bbb991 Akinobu Mita 2013-11-12 1853 if (bitmap_weight(o2hb_region_bitmap, O2NM_MAX_REGIONS) == 1)
76d9fc2954d057b Sunil Mushran 2011-05-04 1854 live_threshold <<= 1;
76d9fc2954d057b Sunil Mushran 2011-05-04 1855 spin_unlock(&o2hb_live_lock);
76d9fc2954d057b Sunil Mushran 2011-05-04 1856 }
d2eece376648d2f Sunil Mushran 2011-07-24 1857 ++live_threshold;
d2eece376648d2f Sunil Mushran 2011-07-24 1858 atomic_set(®->hr_steady_iterations, live_threshold);
a84ac334dcb44c7 Junxiao Bi 2016-01-14 1859 /* unsteady_iterations is triple the steady_iterations */
a84ac334dcb44c7 Junxiao Bi 2016-01-14 1860 atomic_set(®->hr_unsteady_iterations, (live_threshold * 3));
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1861
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1862 hb_task = kthread_run(o2hb_thread, reg, "o2hb-%s",
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1863 reg->hr_item.ci_name);
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1864 if (IS_ERR(hb_task)) {
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1865 ret = PTR_ERR(hb_task);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1866 mlog_errno(ret);
2903ff019b346ab Al Viro 2012-08-28 1867 goto out3;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1868 }
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1869
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1870 spin_lock(&o2hb_live_lock);
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1871 reg->hr_task = hb_task;
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1872 spin_unlock(&o2hb_live_lock);
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1873
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1874 ret = wait_event_interruptible(o2hb_steady_queue,
0986fe9b50f425e Joseph Qi 2015-11-05 1875 atomic_read(®->hr_steady_iterations) == 0 ||
0986fe9b50f425e Joseph Qi 2015-11-05 1876 reg->hr_node_deleted);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1877 if (ret) {
d2eece376648d2f Sunil Mushran 2011-07-24 1878 atomic_set(®->hr_steady_iterations, 0);
d2eece376648d2f Sunil Mushran 2011-07-24 1879 reg->hr_aborted_start = 1;
d2eece376648d2f Sunil Mushran 2011-07-24 1880 }
e6c352dbc0f4dc7 Joel Becker 2007-02-03 1881
d2eece376648d2f Sunil Mushran 2011-07-24 1882 if (reg->hr_aborted_start) {
d2eece376648d2f Sunil Mushran 2011-07-24 1883 ret = -EIO;
2903ff019b346ab Al Viro 2012-08-28 1884 goto out3;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1885 }
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1886
0986fe9b50f425e Joseph Qi 2015-11-05 1887 if (reg->hr_node_deleted) {
0986fe9b50f425e Joseph Qi 2015-11-05 1888 ret = -EINVAL;
0986fe9b50f425e Joseph Qi 2015-11-05 1889 goto out3;
0986fe9b50f425e Joseph Qi 2015-11-05 1890 }
0986fe9b50f425e Joseph Qi 2015-11-05 1891
e6df3a663a5d1ee Joel Becker 2007-02-06 1892 /* Ok, we were woken. Make sure it wasn't by drop_item() */
e6df3a663a5d1ee Joel Becker 2007-02-06 1893 spin_lock(&o2hb_live_lock);
e6df3a663a5d1ee Joel Becker 2007-02-06 1894 hb_task = reg->hr_task;
e7d656baf6607a0 Sunil Mushran 2010-10-06 1895 if (o2hb_global_heartbeat_active())
e7d656baf6607a0 Sunil Mushran 2010-10-06 1896 set_bit(reg->hr_region_num, o2hb_live_region_bitmap);
e6df3a663a5d1ee Joel Becker 2007-02-06 1897 spin_unlock(&o2hb_live_lock);
e6df3a663a5d1ee Joel Becker 2007-02-06 1898
e6df3a663a5d1ee Joel Becker 2007-02-06 1899 if (hb_task)
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1900 ret = count;
e6df3a663a5d1ee Joel Becker 2007-02-06 1901 else
e6df3a663a5d1ee Joel Becker 2007-02-06 1902 ret = -EIO;
e6df3a663a5d1ee Joel Becker 2007-02-06 1903
18c50cb0d3c293e Sunil Mushran 2010-10-06 1904 if (hb_task && o2hb_global_heartbeat_active())
d2eece376648d2f Sunil Mushran 2011-07-24 1905 printk(KERN_NOTICE "o2hb: Heartbeat started on region %s (%s)\n",
d2eece376648d2f Sunil Mushran 2011-07-24 1906 config_item_name(®->hr_item), reg->hr_dev_name);
18c50cb0d3c293e Sunil Mushran 2010-10-06 1907
2903ff019b346ab Al Viro 2012-08-28 1908 out3:
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1909 if (ret < 0) {
9a1c3542768b5a5 Al Viro 2008-02-22 1910 blkdev_put(reg->hr_bdev, FMODE_READ|FMODE_WRITE);
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1911 reg->hr_bdev = NULL;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1912 }
734aab48f144821 Christoph Hellwig 2020-09-03 1913 out2:
734aab48f144821 Christoph Hellwig 2020-09-03 1914 fdput(f);
734aab48f144821 Christoph Hellwig 2020-09-03 1915 out:
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1916 return ret;
a7f6a5fb4bde142 Mark Fasheh 2005-12-15 1917 }---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org