misc: fastrpc: add ioctl for attaching to sensors pd
v2 cover misc: fastrpc: add ioctl for attaching to sensors pd
Initializing sensors requires attaching to pd 2. Add an ioctl for that.
This corresponds to FASTRPC_INIT_ATTACH_SENSORS in the downstream driver.
v2:
- define names of PD values in a separate patch
- split out identation fix in a separate patch
Jonathan Marek (3):
misc: fastrpc: fix indentation error in uapi header
misc: fastrpc: define names for protection domain ids
misc: fastrpc: add ioctl for attaching to sensors pd
drivers/misc/fastrpc.c | 16 ++++++++++++---- include/uapi/misc/fastrpc.h | 5 +++-- 2 files changed, 15 insertions(+), 6 deletions(-)
Signature · 1 line
2.26.1
PATCH v2 1/3 misc: fastrpc: fix indentation error in uapi header
Use tabs instead of spaces.
--- include/uapi/misc/fastrpc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/uapi/misc/fastrpc.h +2 -2
@@ -10,8 +10,8 @@#define FASTRPC_IOCTL_INVOKE _IOWR('R', 3, struct fastrpc_invoke)#define FASTRPC_IOCTL_INIT_ATTACH _IO('R', 4)#define FASTRPC_IOCTL_INIT_CREATE _IOWR('R', 5, struct fastrpc_init_create) -#define FASTRPC_IOCTL_MMAP _IOWR('R', 6, struct fastrpc_req_mmap) -#define FASTRPC_IOCTL_MUNMAP _IOWR('R', 7, struct fastrpc_req_munmap) +#define FASTRPC_IOCTL_MMAP _IOWR('R', 6, struct fastrpc_req_mmap) +#define FASTRPC_IOCTL_MUNMAP _IOWR('R', 7, struct fastrpc_req_munmap)struct fastrpc_invoke_args {__u64 ptr;
Signature · 1 line
2.26.1
PATCH v2 2/3 misc: fastrpc: define names for protection domain ids
In reply to Jonathan MarekDefine SENSORS_PD for the next patch, to void using magic values for these.
--- drivers/misc/fastrpc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/misc/fastrpc.c +7 -2
@@ -73,6 +73,11 @@#define FASTRPC_RMID_INIT_CREATE_ATTR 7#define FASTRPC_RMID_INIT_CREATE_STATIC 8 +/* Protection Domain(PD) ids */ +#define AUDIO_PD (0)/* also GUEST_OS PD? */ +#define USER_PD (1) +#define SENSORS_PD (2) +#define miscdev_to_cctx (d) container_of(d, struct fastrpc_channel_ctx, miscdev)static const char *domains[FASTRPC_DEV_MAX ] = {"adsp" ,"mdsp" ,
@@ -1037,7 +1042,7 @@ static int fastrpc_init_create_process(struct fastrpc_user *fl, inbuf.pageslen =1 ; inbuf.attrs = init.attrs; inbuf.siglen = init.siglen; - fl->pd =1 ; + fl->pd =USER_PD ;if (init.filelen && init.filefd) { err =fastrpc_map_create (fl, init.filefd, init.filelen, &map);
@@ -1287,7 +1292,7 @@ static int fastrpc_init_attach(struct fastrpc_user *fl) args[0 ].fd =-1 ; args[0 ].reserved =0 ; sc =FASTRPC_SCALARS (FASTRPC_RMID_INIT_ATTACH ,1 ,0 ); - fl->pd =0 ; + fl->pd =AUDIO_PD ;return fastrpc_internal_invoke (fl, true,FASTRPC_INIT_HANDLE , sc, &args[0 ]);
Signature · 1 line
2.26.1
PATCH v2 3/3 misc: fastrpc: add ioctl for attaching to sensors pd
In reply to Jonathan MarekInitializing sensors requires attaching to pd 2. Add an ioctl for that.
This corresponds to FASTRPC_INIT_ATTACH_SENSORS in the downstream driver.
--- drivers/misc/fastrpc.c | 9 ++++++--- include/uapi/misc/fastrpc.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-)
drivers/misc/fastrpc.c +6 -3
@@ -1281,7 +1281,7 @@ static int fastrpc_dmabuf_alloc(struct fastrpc_user *fl, char __user *argp)return 0 ; } -static int fastrpc_init_attach (struct fastrpc_user *fl) +static int fastrpc_init_attach (struct fastrpc_user *fl,int pd) {struct fastrpc_invoke_args args[1 ];int tgid = fl->tgid;
@@ -1292,7 +1292,7 @@ static int fastrpc_init_attach(struct fastrpc_user *fl) args[0 ].fd =-1 ; args[0 ].reserved =0 ; sc =FASTRPC_SCALARS (FASTRPC_RMID_INIT_ATTACH ,1 ,0 ); - fl->pd =AUDIO_PD ; + fl->pd = pd;return fastrpc_internal_invoke (fl, true,FASTRPC_INIT_HANDLE , sc, &args[0 ]);
@@ -1482,7 +1482,10 @@ static long fastrpc_device_ioctl(struct file *file, unsigned int cmd, err =fastrpc_invoke (fl, argp);break ;case FASTRPC_IOCTL_INIT_ATTACH : - err =fastrpc_init_attach (fl); + err =fastrpc_init_attach (fl,AUDIO_PD ); +break ; +case FASTRPC_IOCTL_INIT_ATTACH_SNS : + err =fastrpc_init_attach (fl,SENSORS_PD );break ;case FASTRPC_IOCTL_INIT_CREATE : err =fastrpc_init_create_process (fl, argp);
include/uapi/misc/fastrpc.h +1 -0
@@ -12,6 +12,7 @@#define FASTRPC_IOCTL_INIT_CREATE _IOWR('R', 5, struct fastrpc_init_create)#define FASTRPC_IOCTL_MMAP _IOWR('R', 6, struct fastrpc_req_mmap)#define FASTRPC_IOCTL_MUNMAP _IOWR('R', 7, struct fastrpc_req_munmap) +#define FASTRPC_IOCTL_INIT_ATTACH_SNS _IO('R', 8)struct fastrpc_invoke_args {__u64 ptr;
Signature · 1 line
2.26.1