Skip to contentSkip to conversation

make_fit_atf.py and multiple U-Boot ELF segments

DISCUSSION Tom Rini 2 participants 2 messages Sep 8, 2020

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

Hey all,

As part of reviewing
http://patchwork.ozlabs.org/project/uboot/list/?series=187450&state=*
I've run in to an odd problem. With patch 4/7 of that series, building firefly-rk3399 fails on the make_fit_atf.py step as those changes end up with a U-Boot ELF that has len(segments) of 2, rather than 1, and the generator blows up. It's not clear to me if we can just check for non-zero number of segments here or what. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200908/670ab5b1/attachment.sig>
#1 lore raw

Hi Tom,

Quoted 10 lines · Tom Rini

Hey all,

As part of reviewing
http://patchwork.ozlabs.org/project/uboot/list/?series=187450&state=*
I've run in to an odd problem. With patch 4/7 of that series, building firefly-rk3399 fails on the make_fit_atf.py step as those changes end up with a U-Boot ELF that has len(segments) of 2, rather than 1, and the generator blows up. It's not clear to me if we can just check for non-zero number of segments here or what. Thanks!

I don't see that but it is probably a toolchain difference.

I haven't looked at the script in detail, but we should convert it to binman soon and add some tests. It seems odd to me that the number of LOAD sections could change because of that patch, if that is actually what is happening.

Regards,
Simon