hsr: avoid newline at end of message in NL_SET_ERR_MSG_MOD
Subsystems (3)
PATCH 1/1 hsr: avoid newline at end of message in NL_SET_ERR_MSG_MOD
clean follow coccicheck warning:
net//hsr/hsr_netlink.c:94:8-42: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD
net//hsr/hsr_netlink.c:87:30-57: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD
net//hsr/hsr_netlink.c:79:29-53: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD
--- net/hsr/hsr_netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
net/hsr/hsr_netlink.c +3 -3
@@ -76,7 +76,7 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev, proto =nla_get_u8 (data[IFLA_HSR_PROTOCOL ]);if (proto >=HSR_PROTOCOL_MAX ) { -NL_SET_ERR_MSG_MOD (extack,"Unsupported protocol\n" ); +NL_SET_ERR_MSG_MOD (extack,"Unsupported protocol" );return -EINVAL ; }
@@ -84,14 +84,14 @@ static int hsr_newlink(struct net *src_net, struct net_device *dev, proto_version =HSR_V0 ; }else {if (proto ==HSR_PROTOCOL_PRP ) { -NL_SET_ERR_MSG_MOD (extack,"PRP version unsupported\n" ); +NL_SET_ERR_MSG_MOD (extack,"PRP version unsupported" );return -EINVAL ; } proto_version =nla_get_u8 (data[IFLA_HSR_VERSION ]);if (proto_version >HSR_V1 ) {NL_SET_ERR_MSG_MOD (extack, -"Only HSR version 0/1 supported\n" ); +"Only HSR version 0/1 supported" );return -EINVAL ; } }
Signature · 1 line
2.16.2.dirty
From: Ye Bin <[email protected]>
Date: Wed, 9 Sep 2020 17:38:21 +0800
Quoted 9 lines
clean follow coccicheck warning:
net//hsr/hsr_netlink.c:94:8-42: WARNING avoid newline at end of message inNL_SET_ERR_MSG_MOD
net//hsr/hsr_netlink.c:87:30-57: WARNING avoid newline at end of message inNL_SET_ERR_MSG_MOD
net//hsr/hsr_netlink.c:79:29-53: WARNING avoid newline at end of message inNL_SET_ERR_MSG_MODSigned-off-by Ye Bin <[email protected]>
Applied, thank you.