Skip to contentSkip to conversation

spi: stm32: fix pm_runtime_get_sync() error checking

PATCH In review Dan Carpenter 3 participants 3 messages Sep 9, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: stm32: fix pm_runtime_get_sync() error checking

The pm_runtime_get_sync() can return either 0 or 1 on success but this code treats 1 as a failure.

Fixes db96bf976a4f ("spi: stm32: fixes suspend/resume management")
---
 drivers/spi/spi-stm32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-stm32.c +1 -1
index d4b33b358a31..19064df42d25 100644
@@ -2060,7 +2060,7 @@ static int stm32_spi_resume(struct device *dev)
 	}
 
 	ret = pm_runtime_get_sync(dev);
-	if (ret) {
+	if (ret < 0) {
 		dev_err(dev, "Unable to power device:%d\n", ret);
 		return ret;
 	}
Signature · 1 line
2.28.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Dan,

Thanks for the patch.

Quoted 5 lines · Dan Carpenter

The pm_runtime_get_sync() can return either 0 or 1 on success but this code treats 1 as a failure.

Fixes db96bf976a4f ("spi: stm32: fixes suspend/resume management")
Quoted 20 lines
---
 drivers/spi/spi-stm32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-stm32.c +1 -1
index d4b33b358a31..19064df42d25 100644
@@ -2060,7 +2060,7 @@ static int stm32_spi_resume(struct device *dev)
 	}
 
 	ret = pm_runtime_get_sync(dev);
-	if (ret) {
+	if (ret < 0) {
 		dev_err(dev, "Unable to power device:%d\n", ret);
 		return ret;
 	}
Signature · 1 line
2.28.0
maintainer
#2 lore raw
In reply to Dan Carpenter
Quoted 2 lines · Dan Carpenter

The pm_runtime_get_sync() can return either 0 or 1 on success but this code treats 1 as a failure.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: stm32: fix pm_runtime_get_sync() error checking

      commit: c170a5a3b6944ad8e76547c4a1d9fe81c8f23ac8

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark