drm/i915: Fix DMA mapped scatterlist walks
Subsystems (2)
PATCH 1/1 drm/i915: Fix DMA mapped scatterlist walks
From: Tvrtko Ursulin <[email protected]>
When walking DMA mapped scatterlists sg_dma_len has to be used since it can be different (coalesced) from the backing store entry.
This also means we have to end the walk when encountering a zero length DMA entry and cannot rely on the normal sg list end marker.
Both issues were there in theory for some time but were hidden by the fact Intel IOMMU driver was never coalescing entries. As there are ongoing efforts to change this we need to start handling it.
References: 85d1225ec066 ("drm/i915: Introduce & use new lightweight SGL iterators")
References: b31144c0daa8 ("drm/i915: Micro-optimise gen6_ppgtt_insert_entries()")
--- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 6 +++--- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 17 ++++++++++------- drivers/gpu/drm/i915/gt/intel_gtt.h | 2 +- drivers/gpu/drm/i915/i915_scatterlist.h | 12 ++++++++---- 4 files changed, 22 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/gt/gen6_ppgtt.c +3 -3
@@ -131,17 +131,17 @@ static void gen6_ppgtt_insert_entries(struct i915_address_space *vm, vaddr =kmap_atomic_px (i915_pt_entry (pd, act_pt)); do { - GEM_BUG_ON(iter.sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter.sg) < I915_GTT_PAGE_SIZE); vaddr[act_pte] = pte_encode | GEN6_PTE_ADDR_ENCODE(iter.dma); iter.dma += I915_GTT_PAGE_SIZE; if (iter.dma == iter.max) { iter.sg = __sg_next(iter.sg); - if (!iter.sg) + if (!iter.sg || sg_dma_len(iter.sg) == 0) break; iter.dma = sg_dma_address(iter.sg); - iter.max = iter.dma + iter.sg->length; + iter.max = iter.dma + sg_dma_len(iter.sg); } if (++act_pte == GEN6_PTES) {
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +10 -7
@@ -372,19 +372,19 @@ gen8_ppgtt_insert_pte(struct i915_ppgtt *ppgtt, pd =i915_pd_entry (pdp,gen8_pd_index (idx,2 )); vaddr =kmap_atomic_px (i915_pt_entry (pd,gen8_pd_index (idx,1 ))); do { - GEM_BUG_ON(iter->sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter->sg) < I915_GTT_PAGE_SIZE); vaddr[gen8_pd_index(idx, 0)] = pte_encode | iter->dma; iter->dma += I915_GTT_PAGE_SIZE; if (iter->dma >= iter->max) { iter->sg = __sg_next(iter->sg); - if (!iter->sg) { + if (!iter->sg || sg_dma_len(iter->sg) == 0) { idx = 0; break; } iter->dma = sg_dma_address(iter->sg); - iter->max = iter->dma + iter->sg->length; + iter->max = iter->dma + sg_dma_len(iter->sg); } if (gen8_pd_index(++idx, 0) == 0) {
@@ -414,7 +414,7 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, {const gen8_pte_t pte_encode =gen8_pte_encode (0 , cache_level, flags);u64 start = vma->node.start; -dma_addr_t rem = iter->sg->length; +dma_addr_t rem =sg_dma_len (iter->sg);GEM_BUG_ON (!i915_vm_is_4lvl (vma->vm));
@@ -456,7 +456,7 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, } do { - GEM_BUG_ON(iter->sg->length < page_size); + GEM_BUG_ON(sg_dma_len(iter->sg) < page_size); vaddr[index++] = encode | iter->dma; start += page_size;
@@ -467,7 +467,10 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma,if (!iter->sg)break ; - rem = iter->sg->length; + rem =sg_dma_len (iter->sg); +if (!rem) +break ; + iter->dma =sg_dma_address (iter->sg); iter->max = iter->dma + rem;
@@ -525,7 +528,7 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, } vma->page_sizes.gtt |= page_size; - }while (iter->sg); + }while (iter->sg &&sg_dma_len (iter->sg)); } static void gen8_ppgtt_insert(struct i915_address_space *vm,
drivers/gpu/drm/i915/gt/intel_gtt.h +1 -1
@@ -580,7 +580,7 @@ static inline struct sgt_dma {struct scatterlist *sg = vma->pages->sgl;dma_addr_t addr =sg_dma_address (sg); - return (struct sgt_dma){ sg, addr, addr + sg->length }; + return (struct sgt_dma){ sg, addr, addr + sg_dma_len(sg) }; }#endif
drivers/gpu/drm/i915/i915_scatterlist.h +8 -4
@@ -27,13 +27,17 @@ static __always_inline struct sgt_iter { } __sgt_iter(struct scatterlist *sgl, bool dma) {struct sgt_iter s = { .sgp = sgl }; -if (s.sgp) { +if (dma && s.sgp &&sg_dma_len (s.sgp) ==0 ) { + s.sgp =NULL ; + }else if (s.sgp) { s.max = s.curr = s.sgp->offset; - s.max += s.sgp->length; -if (dma) +if (dma) { s.dma =sg_dma_address (s.sgp); -else + s.max +=sg_dma_len (s.sgp); + }else { s.pfn =page_to_pfn (sg_page (s.sgp)); + s.max += s.sgp->length; + } }return s;
Signature · 6 lines
2.25.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2020-09-09 13:44:57)
Quoted 11 lines
From: Tvrtko Ursulin <[email protected]>
When walking DMA mapped scatterlists
sg_dma_lenhas to be used since it can be different (coalesced) from the backing store entry.This also means we have to end the walk when encountering a zero length DMA entry and cannot rely on the normal sg list end marker.
Both issues were there in theory for some time but were hidden by the fact Intel IOMMU driver was never coalescing entries. As there are ongoing efforts to change this we need to start handling it.
Does this change anything if we were already feeding in coalesced entries? I doubt we made all sg generators compact the lists though.
The change looks reasonable, it seems you have kept the dma and page iterators distinct, which was the only worry that occurred to me. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix DMA mapped scatterlist walks
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Fix DMA mapped scatterlist walks
URL : https://patchwork.freedesktop.org/series/81497/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8990 -> Patchwork_18460
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/index.html
Known issues
------------
Here are the changes found in Patchwork_18460 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-cfl-8109u: [PASS][1] -> [INCOMPLETE][2] ([i915#2439])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-cfl-8109u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-cfl-8109u/igt@[email protected]
- fi-kbl-7500u: [PASS][3] -> [INCOMPLETE][4] ([i915#2439])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-kbl-7500u/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-kbl-7500u/igt@[email protected]
- fi-skl-6600u: [PASS][5] -> [INCOMPLETE][6] ([i915#2439])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-skl-6600u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-skl-6600u/igt@[email protected]
- fi-skl-lmem: [PASS][7] -> [INCOMPLETE][8] ([i915#2439])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-skl-lmem/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-skl-lmem/igt@[email protected]
- fi-cml-s: [PASS][9] -> [INCOMPLETE][10] ([i915#2439])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-cml-s/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-cml-s/igt@[email protected]
* igt@gem_exec_parallel@engines@basic:
- fi-bsw-kefka: [PASS][11] -> [INCOMPLETE][12] ([i915#2439])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-bsw-kefka/igt@gem_exec_parallel@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-bsw-kefka/igt@gem_exec_parallel@[email protected]
* igt@gem_tiled_fence_blits@basic:
- fi-bsw-nick: [PASS][13] -> [INCOMPLETE][14] ([i915#2439])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-bsw-nick/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-bsw-nick/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-bsw-n3050/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-bsw-n3050/igt@[email protected]
#### Possible fixes ####
* igt@debugfs_test@read_all_entries:
- {fi-kbl-7560u}: [INCOMPLETE][17] ([i915#2417]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-kbl-7560u/igt@debugfs_test@read_all_entries.html
* igt@gem_exec_gttfill@basic:
- fi-icl-y: [INCOMPLETE][19] ([i915#2439]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-icl-y/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-icl-y/igt@[email protected]
- fi-kbl-r: [INCOMPLETE][21] ([i915#2439]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-kbl-r/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-kbl-r/igt@[email protected]
* igt@gem_tiled_fence_blits@basic:
- fi-byt-j1900: [INCOMPLETE][23] ([i915#2439]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-byt-j1900/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-byt-j1900/igt@[email protected]
* igt@i915_selftest@live@gem_execbuf:
- fi-gdg-551: [INCOMPLETE][25] ([i915#172] / [i915#2440]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-gdg-551/igt@i915_selftest@live@gem_execbuf.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-gdg-551/igt@i915_selftest@live@gem_execbuf.html
- fi-pnv-d510: [INCOMPLETE][27] ([i915#2440] / [i915#299]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-pnv-d510/igt@i915_selftest@live@gem_execbuf.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-pnv-d510/igt@i915_selftest@live@gem_execbuf.html
#### Warnings ####
* igt@i915_selftest@live@gem_execbuf:
- fi-bsw-n3050: [INCOMPLETE][29] ([i915#2439]) -> [INCOMPLETE][30] ([i915#2440])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-bsw-n3050/igt@i915_selftest@live@gem_execbuf.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-bsw-n3050/igt@i915_selftest@live@gem_execbuf.html
* igt@runner@aborted:
- fi-kbl-x1275: [FAIL][31] ([i915#1186] / [i915#2439]) -> [FAIL][32] ([i915#1186] / [i915#1784] / [i915#2439])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-kbl-x1275/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-kbl-x1275/igt@[email protected]
- fi-skl-6600u: [FAIL][33] ([i915#2398] / [i915#2439]) -> [FAIL][34] ([i915#1186] / [i915#2439])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-skl-6600u/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-skl-6600u/igt@[email protected]
- fi-cfl-8109u: [FAIL][35] ([i915#2398] / [i915#2439]) -> [FAIL][36] ([i915#1186] / [i915#2439])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-cfl-8109u/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-cfl-8109u/igt@[email protected]
- fi-bsw-nick: [FAIL][37] ([i915#1436] / [i915#2109] / [i915#2439]) -> [FAIL][38] ([i915#2109] / [i915#2439])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-bsw-nick/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-bsw-nick/igt@[email protected]
- fi-skl-lmem: [FAIL][39] ([i915#2398] / [i915#2439]) -> [FAIL][40] ([i915#1186] / [i915#2439])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-skl-lmem/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-skl-lmem/igt@[email protected]
- fi-kbl-r: [FAIL][41] ([i915#1186] / [i915#1784] / [i915#2439]) -> [FAIL][42] ([i915#2398] / [i915#2439])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-kbl-r/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-kbl-r/igt@[email protected]
- fi-bdw-5557u: [FAIL][43] ([i915#2439] / [i915#483]) -> [FAIL][44] ([i915#2439])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-bdw-5557u/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-bdw-5557u/igt@[email protected]
- fi-kbl-7500u: [FAIL][45] ([i915#1784] / [i915#2398] / [i915#2439]) -> [FAIL][46] ([i915#1186] / [i915#2439])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-kbl-7500u/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-kbl-7500u/igt@[email protected]
- fi-cml-u2: [FAIL][47] ([i915#1186] / [i915#2082] / [i915#2439]) -> [FAIL][48] ([i915#1186] / [i915#2439])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-cml-u2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-cml-u2/igt@[email protected]
- fi-cml-s: [FAIL][49] ([i915#2398] / [i915#2439]) -> [FAIL][50] ([i915#1186] / [i915#2439])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-cml-s/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-cml-s/igt@[email protected]
- fi-icl-y: [FAIL][51] ([i915#2439]) -> [FAIL][52] ([i915#2398] / [i915#2439])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/fi-icl-y/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/fi-icl-y/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1186]: https://gitlab.freedesktop.org/drm/intel/issues/1186
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#172]: https://gitlab.freedesktop.org/drm/intel/issues/172
[i915#1784]: https://gitlab.freedesktop.org/drm/intel/issues/1784
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
[i915#2109]: https://gitlab.freedesktop.org/drm/intel/issues/2109
[i915#2398]: https://gitlab.freedesktop.org/drm/intel/issues/2398
[i915#2417]: https://gitlab.freedesktop.org/drm/intel/issues/2417
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2440]: https://gitlab.freedesktop.org/drm/intel/issues/2440
[i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
Participating hosts (41 -> 35)
------------------------------
Missing (6): fi-hsw-4200u fi-tgl-u2 fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8990 -> Patchwork_18460
CI-20190529: 20190529
CI_DRM_8990: 5c949aaff68021fed2e0b4f2609a61ebdbdff8a8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5780: 9c5dfeb0338d7f98ad998663a595eab71ea887f3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18460: 920da7069faae97c87fc3689500423f75aecd80c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
920da7069faa drm/i915: Fix DMA mapped scatterlist walks
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Chris Wilson
Quoting Tvrtko Ursulin (2020-09-09 13:44:57)
Quoted 8 lines
From: Tvrtko Ursulin <[email protected]>
When walking DMA mapped scatterlists
sg_dma_lenhas to be used since it can be different (coalesced) from the backing store entry.This also means we have to end the walk when encountering a zero length DMA entry and cannot rely on the normal sg list end marker.
Quoted 6 lines
Quoted 3 lines
Both issues were there in theory for some time but were hidden by the fact Intel IOMMU driver was never coalescing entries. As there are ongoing efforts to change this we need to start handling it.
Does this change anything if we were already feeding in coalesced entries? I doubt we made all sg generators compact the lists though.
I don't think so. My takeaway from this was a realization that page and dma coalescing can be completely different (more so once the iommu patches get in). I did not think of any other problems as long as the dma remapping fits into the number of available sg table entries we allocated. It is just a bit weird, this duality of sg_table "views".
Quoted 2 lines
The change looks reasonable, it seems you have kept the dma and page iterators distinct, which was the only worry that occurred to me.
It surprised me we have two iterators, well one and a half. The sgt_dma one being the half of an iterator. :)
Regards,
Tvrtko
P.S. Well as I was writing this reply full test results came in and something is still broken, so scratch that..
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix DMA mapped scatterlist walks
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Fix DMA mapped scatterlist walks
URL : https://patchwork.freedesktop.org/series/81497/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8990_full -> Patchwork_18460_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18460_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][1] -> [DMESG-WARN][2] ([i915#180])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl6/igt@[email protected]
* igt@gem_exec_reloc@basic-cpu-gtt-active:
- shard-apl: [PASS][3] -> [INCOMPLETE][4] ([i915#1635] / [i915#2439])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-apl6/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-apl4/igt@[email protected]
* igt@gem_exec_reloc@basic-cpu-read-active:
- shard-glk: [PASS][5] -> [INCOMPLETE][6] ([i915#2439]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-glk9/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-glk9/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-active:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#2439]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl10/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([i915#2439]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-iclb6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-iclb8/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-read-active:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([i915#2439])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb2/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-wc-active:
- shard-snb: [PASS][13] -> [INCOMPLETE][14] ([i915#2439] / [i915#82]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-snb5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-snb2/igt@[email protected]
* igt@gem_exec_reloc@basic-wc-read-active:
- shard-kbl: [PASS][15] -> [INCOMPLETE][16] ([i915#2439]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl3/igt@[email protected]
* igt@gem_exec_whisper@basic-queues-forked:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([i915#118] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-glk5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-glk2/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-skl: [PASS][19] -> [TIMEOUT][20] ([i915#1958])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl7/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-skl: [PASS][21] -> [INCOMPLETE][22] ([i915#198])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl1/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
- shard-tglb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb5/igt@[email protected]
* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- shard-glk: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-glk4/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-glk5/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
- shard-skl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl1/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl3/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@a-hdmi-a1:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#79])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-glk3/igt@kms_flip@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-glk1/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#2122]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl4/igt@kms_flip@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl1/igt@kms_flip@[email protected]
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109441]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_cpu.html
#### Possible fixes ####
* igt@gem_exec_reloc@basic-cpu-wc-active:
- shard-skl: [DMESG-FAIL][35] ([i915#2439]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl5/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl4/igt@[email protected]
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-glk: [INCOMPLETE][37] ([i915#2439]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-glk3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-glk1/igt@[email protected]
* igt@gem_exec_reloc@basic-spin@rcs0:
- shard-kbl: [INCOMPLETE][39] ([i915#2439]) -> [PASS][40] +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl7/igt@gem_exec_reloc@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl1/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_reloc@basic-write-read-active:
- shard-snb: [INCOMPLETE][41] ([i915#2439] / [i915#82]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-snb1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-snb6/igt@[email protected]
* igt@gem_exec_schedule@out-order@vecs0:
- shard-skl: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl3/igt@gem_exec_schedule@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl8/igt@gem_exec_schedule@[email protected]
* igt@gem_exec_whisper@basic-normal:
- shard-skl: [INCOMPLETE][45] ([i915#2439]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl10/igt@[email protected]
- shard-apl: [INCOMPLETE][47] ([i915#1635] / [i915#2439]) -> [PASS][48] +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-apl3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-apl1/igt@[email protected]
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-tglb: [INCOMPLETE][49] ([i915#2439]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb3/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb1/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl7/igt@[email protected]
* igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions:
- shard-apl: [DMESG-WARN][53] ([i915#1635] / [i915#1982]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-apl1/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-apl3/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
- shard-kbl: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl4/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl7/igt@kms_cursor_legacy@short-flip-before-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-skl: [INCOMPLETE][57] ([i915#198]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl5/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [DMESG-FAIL][59] ([fdo#108145] / [i915#1982]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl10/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][61] ([fdo#108145] / [i915#265]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl2/igt@[email protected]
* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][63] ([fdo#109441]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-iclb1/igt@kms_psr@psr2_dpms.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-iclb2/igt@kms_psr@psr2_dpms.html
#### Warnings ####
* igt@gem_exec_reloc@basic-gtt-cpu-active:
- shard-apl: [DMESG-FAIL][65] ([i915#1635] / [i915#2439]) -> [INCOMPLETE][66] ([i915#1635] / [i915#2439])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-apl2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-apl3/igt@[email protected]
* igt@gem_exec_reloc@basic-write-gtt-active:
- shard-skl: [DMESG-FAIL][67] ([i915#2439]) -> [DMESG-WARN][68] ([i915#1982])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-skl3/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-skl7/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][69], [FAIL][70], [FAIL][71], [FAIL][72], [FAIL][73], [FAIL][74], [FAIL][75], [FAIL][76], [FAIL][77], [FAIL][78], [FAIL][79], [FAIL][80], [FAIL][81], [FAIL][82], [FAIL][83], [FAIL][84], [FAIL][85], [FAIL][86], [FAIL][87], [FAIL][88]) ([i915#1611] / [i915#1784] / [i915#2263] / [i915#2439]) -> ([FAIL][89], [FAIL][90], [FAIL][91], [FAIL][92], [FAIL][93], [FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100], [FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107]) ([i915#1611] / [i915#1784] / [i915#2263] / [i915#2268] / [i915#2439])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl6/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl4/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl3/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl7/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl7/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl6/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl2/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl6/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl2/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl6/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl7/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl7/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-kbl1/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl1/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl3/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl6/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl2/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl4/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl6/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl1/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl7/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl2/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl2/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl1/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl4/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl4/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl3/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl2/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl1/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl2/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl4/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-kbl1/igt@[email protected]
- shard-tglb: ([FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#2045] / [i915#2263] / [i915#2439]) -> ([FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154]) ([i915#1764] / [i915#2045] / [i915#2263] / [i915#2268] / [i915#2439])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb1/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb2/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb8/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb2/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb7/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb7/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb2/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb1/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb7/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb7/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb3/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb6/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb8/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb3/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb8/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb1/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb5/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb6/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb8/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb5/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb5/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8990/shard-tglb5/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb7/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb5/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb1/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb8/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb2/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb2/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb6/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb8/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb5/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb6/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb2/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb5/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb3/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb7/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb5/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb3/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb8/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb6/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb3/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb3/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb1/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/shard-tglb3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1764]: https://gitlab.freedesktop.org/drm/intel/issues/1764
[i915#1784]: https://gitlab.freedesktop.org/drm/intel/issues/1784
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2045]: https://gitlab.freedesktop.org/drm/intel/issues/2045
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2263]: https://gitlab.freedesktop.org/drm/intel/issues/2263
[i915#2268]: https://gitlab.freedesktop.org/drm/intel/issues/2268
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 10)
------------------------------
Missing (1): pig-snb-2600
Build changes
-------------
* Linux: CI_DRM_8990 -> Patchwork_18460
CI-20190529: 20190529
CI_DRM_8990: 5c949aaff68021fed2e0b4f2609a61ebdbdff8a8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5780: 9c5dfeb0338d7f98ad998663a595eab71ea887f3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18460: 920da7069faae97c87fc3689500423f75aecd80c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18460/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 82 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
When walking DMA mapped scatterlists
sg_dma_lenhas to be used since it can be different (coalesced) from the backing store entry.This also means we have to end the walk when encountering a zero length DMA entry and cannot rely on the normal sg list end marker.
Both issues were there in theory for some time but were hidden by the fact Intel IOMMU driver was never coalescing entries. As there are ongoing efforts to change this we need to start handling it.
Signed-off-by Tvrtko Ursulin <[email protected]>References:
85d1225ec066("drm/i915: Introduce & use new lightweight SGL iterators")
References:b31144c0daa8("drm/i915: Micro-optimisegen6_ppgtt_insert_entries()")Reported-by Tom Murphy <[email protected]>Suggested-by Tom Murphy <[email protected]> # __sgt_iterSuggested-by Logan Gunthorpe <[email protected]> # __sgt_iterCc Joonas Lahtinen <[email protected]>Cc Chris Wilson <[email protected]>Cc Matthew Auld <[email protected]>Cc Lu Baolu <[email protected]>--- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 6 +++--- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 17 ++++++++++------- drivers/gpu/drm/i915/gt/intel_gtt.h | 2 +- drivers/gpu/drm/i915/i915_scatterlist.h | 12 ++++++++---- 4 files changed, 22 insertions(+), 15 deletions(-)drivers/gpu/drm/i915/gt/gen6_ppgtt.c +3
-3@@ -131,17 +131,17 @@ static void gen6_ppgtt_insert_entries(struct i915_address_space *vm, vaddr =kmap_atomic_px (i915_pt_entry (pd, act_pt)); do { - GEM_BUG_ON(iter.sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter.sg) < I915_GTT_PAGE_SIZE); vaddr[act_pte] = pte_encode | GEN6_PTE_ADDR_ENCODE(iter.dma); iter.dma += I915_GTT_PAGE_SIZE; if (iter.dma == iter.max) { iter.sg = __sg_next(iter.sg); - if (!iter.sg) + if (!iter.sg || sg_dma_len(iter.sg) == 0) break; iter.dma = sg_dma_address(iter.sg); - iter.max = iter.dma + iter.sg->length; + iter.max = iter.dma + sg_dma_len(iter.sg); } if (++act_pte == GEN6_PTES) {drivers/gpu/drm/i915/gt/gen8_ppgtt.c +3
-3@@ -372,19 +372,19 @@ gen8_ppgtt_insert_pte(struct i915_ppgtt *ppgtt, pd =i915_pd_entry (pdp,gen8_pd_index (idx,2 )); vaddr =kmap_atomic_px (i915_pt_entry (pd,gen8_pd_index (idx,1 ))); do { - GEM_BUG_ON(iter->sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter->sg) < I915_GTT_PAGE_SIZE); vaddr[gen8_pd_index(idx, 0)] = pte_encode | iter->dma; iter->dma += I915_GTT_PAGE_SIZE; if (iter->dma >= iter->max) { iter->sg = __sg_next(iter->sg); - if (!iter->sg) { + if (!iter->sg || sg_dma_len(iter->sg) == 0) { idx = 0; break; } iter->dma = sg_dma_address(iter->sg); - iter->max = iter->dma + iter->sg->length; + iter->max = iter->dma + sg_dma_len(iter->sg); } if (gen8_pd_index(++idx, 0) == 0) {
drivers/gpu/drm/i915/gt/gen8_ppgtt.c static void gen8_ppgtt_insert_huge(struct i915_vma *vma, · line 417
Quoted 5 lines
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +1
-1@@ -414,7 +414,7 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, {const gen8_pte_t pte_encode =gen8_pte_encode (0 , cache_level, flags);u64 start = vma->node.start; -dma_addr_t rem = iter->sg->length; +dma_addr_t rem =sg_dma_len (iter->sg);
Seems a little odd to me to be storing a length in a dma_addr_t. But besides that small nit, this all makes sense to me.
Thanks,
Logan
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 92 lines · Logan Gunthorpe
Quoted 82 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
When walking DMA mapped scatterlists
sg_dma_lenhas to be used since it can be different (coalesced) from the backing store entry.This also means we have to end the walk when encountering a zero length DMA entry and cannot rely on the normal sg list end marker.
Both issues were there in theory for some time but were hidden by the fact Intel IOMMU driver was never coalescing entries. As there are ongoing efforts to change this we need to start handling it.
Signed-off-by Tvrtko Ursulin <[email protected]>References:
85d1225ec066("drm/i915: Introduce & use new lightweight SGL iterators")
References:b31144c0daa8("drm/i915: Micro-optimisegen6_ppgtt_insert_entries()")Reported-by Tom Murphy <[email protected]>Suggested-by Tom Murphy <[email protected]> # __sgt_iterSuggested-by Logan Gunthorpe <[email protected]> # __sgt_iterCc Joonas Lahtinen <[email protected]>Cc Chris Wilson <[email protected]>Cc Matthew Auld <[email protected]>Cc Lu Baolu <[email protected]>--- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 6 +++--- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 17 ++++++++++------- drivers/gpu/drm/i915/gt/intel_gtt.h | 2 +- drivers/gpu/drm/i915/i915_scatterlist.h | 12 ++++++++---- 4 files changed, 22 insertions(+), 15 deletions(-)drivers/gpu/drm/i915/gt/gen6_ppgtt.c +3
-3@@ -131,17 +131,17 @@ static void gen6_ppgtt_insert_entries(struct i915_address_space *vm, vaddr =kmap_atomic_px (i915_pt_entry (pd, act_pt)); do { - GEM_BUG_ON(iter.sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter.sg) < I915_GTT_PAGE_SIZE); vaddr[act_pte] = pte_encode | GEN6_PTE_ADDR_ENCODE(iter.dma); iter.dma += I915_GTT_PAGE_SIZE; if (iter.dma == iter.max) { iter.sg = __sg_next(iter.sg); - if (!iter.sg) + if (!iter.sg || sg_dma_len(iter.sg) == 0) break; iter.dma = sg_dma_address(iter.sg); - iter.max = iter.dma + iter.sg->length; + iter.max = iter.dma + sg_dma_len(iter.sg); } if (++act_pte == GEN6_PTES) {drivers/gpu/drm/i915/gt/gen8_ppgtt.c +3
-3@@ -372,19 +372,19 @@ gen8_ppgtt_insert_pte(struct i915_ppgtt *ppgtt, pd =i915_pd_entry (pdp,gen8_pd_index (idx,2 )); vaddr =kmap_atomic_px (i915_pt_entry (pd,gen8_pd_index (idx,1 ))); do { - GEM_BUG_ON(iter->sg->length < I915_GTT_PAGE_SIZE); + GEM_BUG_ON(sg_dma_len(iter->sg) < I915_GTT_PAGE_SIZE); vaddr[gen8_pd_index(idx, 0)] = pte_encode | iter->dma; iter->dma += I915_GTT_PAGE_SIZE; if (iter->dma >= iter->max) { iter->sg = __sg_next(iter->sg); - if (!iter->sg) { + if (!iter->sg || sg_dma_len(iter->sg) == 0) { idx = 0; break; } iter->dma = sg_dma_address(iter->sg); - iter->max = iter->dma + iter->sg->length; + iter->max = iter->dma + sg_dma_len(iter->sg); } if (gen8_pd_index(++idx, 0) == 0) {drivers/gpu/drm/i915/gt/gen8_ppgtt.c static void gen8_ppgtt_insert_huge(struct i915_vma *vma, · line 417
Quoted 5 lines
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +1
-1@@ -414,7 +414,7 @@ static void gen8_ppgtt_insert_huge(struct i915_vma *vma, {const gen8_pte_t pte_encode =gen8_pte_encode (0 , cache_level, flags);u64 start = vma->node.start; -dma_addr_t rem = iter->sg->length; +dma_addr_t rem =sg_dma_len (iter->sg);Seems a little odd to me to be storing a length in a
dma_addr_t. But besides that small nit, this all makes sense to me.
Quoted 1 line
Reviewed-by Logan Gunthorpe <[email protected]>
I did not spot that, thanks. I'll improve that in v2 since I need to add a 2nd patch to completely prepare i915 for this.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx