Skip to contentSkip to conversation

blame.c: replace instance of !oidcmp for oideq

PATCH In review Edmundo Carmona Antoranz 2 participants 2 messages Sep 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 blame.c: replace instance of !oidcmp for oideq

0906ac2b (blame: use changed-path Bloom filters, 2020-04-16) introduced a call to oidcmp() that should be replaced with oideq() defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

---
 blame.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
blame.c +2 -2
index da7e28800e..a8abe86ae4 100644
@@ -1352,8 +1352,8 @@ static struct blame_origin *find_origin(struct repository *r,
 	else {
 		int compute_diff = 1;
 		if (origin->commit->parents &&
-		    !oidcmp(&parent->object.oid,
-			    &origin->commit->parents->item->object.oid))
+		    oideq(&parent->object.oid,
+			  &origin->commit->parents->item->object.oid))
 			compute_diff = maybe_changed_path(r, origin, bd);
 
 		if (compute_diff)
Signature · 1 line
2.28.0
#1 lore raw
Quoted 3 lines · Edmundo Carmona Antoranz

0906ac2b (blame: use changed-path Bloom filters, 2020-04-16) introduced a call to oidcmp() that should be replaced with oideq() defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

LGTM. Thanks.

-Stolee