Skip to contentSkip to conversation

linux-next: build warning after merge of the tty tree

DISCUSSION Stephen Rothwell 2 participants 2 messages Sep 9, 2020 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) produced this warning:

drivers/tty/serial/8250/8250_bcm2835aux.c: In function 'bcm2835aux_serial_probe':
drivers/tty/serial/8250/8250_bcm2835aux.c:154:3: warning: ignoring return value of 'dev_err_probe' declared with attribute 'warn_unused_result' [-Wunused-result]

  154 |   dev_err_probe(&pdev->dev, ret, "unable to register 8250 port\n");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

ea43a60b1548 ("serial: 8250: Simplify with dev_err_probe()")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 5 lines · Stephen Rothwell

Hi all,

After merging the tty tree, today's linux-next build (arm multi_v7_defconfig) produced this warning:

Quoted 8 lines

drivers/tty/serial/8250/8250_bcm2835aux.c: In function 'bcm2835aux_serial_probe':
drivers/tty/serial/8250/8250_bcm2835aux.c:154:3: warning: ignoring return value of 'dev_err_probe' declared with attribute 'warn_unused_result' [-Wunused-result]

  154 |   dev_err_probe(&pdev->dev, ret, "unable to register 8250 port\n");
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

ea43a60b1548 ("serial: 8250: Simplify with dev_err_probe()")

Offending patch now dropped from the driver-core tree, thanks.

greg k-h