Skip to contentSkip to conversation

Missing SPDK and redundant license info

dpdk-dev In review Stephen Hemminger 5 participants 8 messages Sep 10, 2020 – Sep 21, 2020 Network drivers

lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

These should be fixed before release!
Makefiles will be dropped.
The ethdev stuff is from Jan Blunck, let me see if I can find current email.

$ ./devtools/check-spdx-tag.sh -v
Files without SPDX License
--------------------------
doc/guides/custom.css
doc/guides/linux_gsg/nic_perf_intel_platform.rst
doc/guides/prog_guide/build-sdk-meson.rst
drivers/net/qede/base/ecore_hsi_func_common.h
examples/multi_process/Makefile
examples/multi_process/client_server_mp/Makefile

Files with redundant license text
---------------------------------
app/test/test_timer_racecond.c
lib/librte_ethdev/rte_ethdev_pci.h
lib/librte_ethdev/rte_ethdev_vdev.h

total: 6 errors, 3 warnings

#1 lore raw

PATCH 1/1 ethdev: remove redundant license text

Redundant BSD-3 license text removed, the licensing already documented by "SPDX-License-Identifier: BSD-3-Clause" SPDX tag.

Signed-off-by Ferruh Yigit <[email protected]>

---
Cc: Jan Blunck <[email protected]>
Cc: Stephen Hemminger <[email protected]>

---
 lib/librte_ethdev/rte_ethdev_pci.h  | 26 --------------------------
 lib/librte_ethdev/rte_ethdev_vdev.h | 26 --------------------------
 2 files changed, 52 deletions(-)
lib/librte_ethdev/rte_ethdev_pci.h +0 -26
index a999602fdd..ef828ea16a 100644
@@ -1,32 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2017 Brocade Communications Systems, Inc.
  *   Author: Jan Blunck <[email protected]>
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of the copyright holder nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef _RTE_ETHDEV_PCI_H_
lib/librte_ethdev/rte_ethdev_vdev.h +0 -26
index b3ef12398e..bf468125aa 100644
@@ -1,32 +1,6 @@
 /* SPDX-License-Identifier: BSD-3-Clause
  * Copyright(c) 2017 Brocade Communications Systems, Inc.
  *   Author: Jan Blunck <[email protected]>
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *     * Neither the name of the copyright holder nor the names of its
- *       contributors may be used to endorse or promote products derived
- *       from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef _RTE_ETHDEV_VDEV_H_
Signature · 1 line
2.26.2
#5 lore raw

PATCH 1/1 net/qede/base: add missing licence

In reply to Stephen Hemminger

Adding BSD-3 SPDX license tag.

Fixes 519438f7c17f ("net/qede/base: re-arrange few structures for DDC")
Cc [email protected]
Reported-by Stephen Hemminger <[email protected]>
Signed-off-by Ferruh Yigit <[email protected]>

---
Cc: Jerin Jacob <[email protected]>

---
 drivers/net/qede/base/ecore_hsi_func_common.h | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/net/qede/base/ecore_hsi_func_common.h +6 -0
index 2cd175163b..4351b7b14f 100644
@@ -1,3 +1,9 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2016 - 2020 Cavium Inc.
+ * All rights reserved.
+ * www.cavium.com
+ */
+
 #ifndef _HSI_FUNC_COMMON_H
 #define _HSI_FUNC_COMMON_H
Signature · 1 line
2.26.2
Applied
#7 lore raw

Re: [dpdk-dev] [EXT] [PATCH] net/qede/base: add missing licence

Quoted 9 lines · Igor Russkikh

Thanks Ferruh,

Quoted 5 lines

Adding BSD-3 SPDX license tag.

Fixes 519438f7c17f ("net/qede/base: re-arrange few structures for DDC")
Cc [email protected]
Quoted 6 lines
Quoted 4 lines
Reported-by Stephen Hemminger <[email protected]>
Signed-off-by Ferruh Yigit <[email protected]>

---
Cc: Jerin Jacob <[email protected]>

Acked-by Igor Russkikh <[email protected]>

Applied to dpdk-next-net-mrvl/master. Thanks