riscv: Clean up timer drivers
Subsystems (4)
v4 cover riscv: Clean up timer drivers
This series cleans up the timer drivers in RISC-V and converts them to DM.
This series needs to be tested! I have only tested it on QEMU and the K210. Notably, this means that the HiFive and anything Andes is completely untested.
Changes in v4:
- Both the Andes PMLT and Sifive CLINT now fall back on timebase-frequency, per discussion with Anup Patel
- Introduce helper function for falling back on timebase-frequency
- Modify RISCV_TIMER KConfig
- Now depends on RISCV
- Implied by S-Mode (with or without SPL)
- Rebase
- Remove clock-frequency property from k210 clint binding because we fall back on timebase-frequency
Changes in v3:
- Don't initialize the IPI in spl_invoke_opensbi. Further testing has revealed it to be unnecessary.
- Rebase
Changes in v2:
- Fix SiFive CLINT not getting tick-rate from rtcclk
- Remove RISCV_RDTIME KConfig option
- Split Kendryte binding changes into their own commit
Sean Anderson (8):
riscv: Rework riscv timer driver to only support S-mode
timer: Add helper for drivers using timebase fallback
riscv: Rework Andes PLMT as a UCLASS_TIMER driver
riscv: Clean up initialization in Andes PLIC
riscv: Rework Sifive CLINT as UCLASS_TIMER driver
riscv: clk: Add CLINT clock to kendryte clock driver
riscv: Update Kendryte device tree for new CLINT driver
riscv: Update SiFive device tree for new CLINT driver
arch/riscv/Kconfig | 16 ----- arch/riscv/cpu/ax25/Kconfig | 2 +- arch/riscv/cpu/fu540/Kconfig | 2 +- arch/riscv/cpu/generic/Kconfig | 2 +- arch/riscv/dts/ae350_32.dts | 1 + arch/riscv/dts/ae350_64.dts | 1 + arch/riscv/dts/fu540-c000-u-boot.dtsi | 8 ++- .../dts/hifive-unleashed-a00-u-boot.dtsi | 4 ++ arch/riscv/dts/k210.dtsi | 7 +- arch/riscv/include/asm/global_data.h | 3 - arch/riscv/lib/Makefile | 1 - arch/riscv/lib/andes_plic.c | 58 +++++++--------- arch/riscv/lib/andes_plmt.c | 44 ++++++------- arch/riscv/lib/rdtime.c | 38 ----------- arch/riscv/lib/sifive_clint.c | 66 ++++++++++--------- drivers/clk/kendryte/clk.c | 4 ++ drivers/ram/sifive/Kconfig | 2 + drivers/timer/Kconfig | 4 +- drivers/timer/riscv_timer.c | 39 +++++------ drivers/timer/timer-uclass.c | 25 +++++++ include/dt-bindings/clock/k210-sysctl.h | 1 + include/timer.h | 15 +++++ 22 files changed, 170 insertions(+), 173 deletions(-) delete mode 100644 arch/riscv/lib/rdtime.c
Signature · 1 line
2.28.0
PATCH v4 1/8 riscv: Rework riscv timer driver to only support S-mode
The riscv-timer driver currently serves as a shim for several riscv timer drivers. This is not too desirable because it bypasses the usual timer selection via the driver model. There is no easy way to specify an alternate timing driver, or have the tick rate depend on the cpu's configured frequency. The timer drivers also do not have device structs, and so have to rely on storing parameters in gd_t. Lastly, there is no initialization call, so driver init is done in the same function which reads the time. This can result in confusing error messages. To a user, it looks like the driver failed when trying to read the time, whereas it may have failed while initializing.
This patch removes the shim functionality from the riscv-timer driver, and has it instead implement the former rdtime.c timer driver. This is because existing u-boot users who pass in a device tree (e.g. qemu) do not create a timer device for S-mode u-boot. The existing behavior of creating the riscv-timer device in the riscv cpu driver must be kept. The actual reading of the CSRs has been redone in the style of Linux's get_cycles64.
---
Changes in v4:
- Modify RISCV_TIMER KConfig
- Now depends on RISCV
- Implied by S-Mode (with or without SPL)
Changes in v2:
- Remove RISCV_RDTIME KConfig option
arch/riscv/Kconfig | 8 ------- arch/riscv/cpu/ax25/Kconfig | 2 +- arch/riscv/cpu/fu540/Kconfig | 2 +- arch/riscv/cpu/generic/Kconfig | 2 +- arch/riscv/lib/Makefile | 1 - arch/riscv/lib/rdtime.c | 38 --------------------------------- drivers/timer/Kconfig | 4 ++-- drivers/timer/riscv_timer.c | 39 +++++++++++++++++----------------- 8 files changed, 25 insertions(+), 71 deletions(-) delete mode 100644 arch/riscv/lib/rdtime.c
arch/riscv/Kconfig +0 -8
@@ -185,14 +185,6 @@ config ANDES_PLMT The Andes PLMT block holds memory-mapped mtime register associated with timer tick. -config RISCV_RDTIME - bool - default y if RISCV_SMODE || SPL_RISCV_SMODE - help - The provides the riscv_get_time() API that is implemented using the - standard rdtime instruction. This is the case for S-mode U-Boot, and - is useful for processors that support rdtime in M-mode too. - config SYS_MALLOC_F_LEN default 0x1000
arch/riscv/cpu/ax25/Kconfig +1 -1
@@ -3,7 +3,7 @@ config RISCV_NDS select ARCH_EARLY_INIT_R imply CPU imply CPU_RISCV - imply RISCV_TIMER + imply RISCV_TIMER if (RISCV_SMODE || SPL_RISCV_SMODE) imply ANDES_PLIC if (RISCV_MMODE || SPL_RISCV_MMODE) imply ANDES_PLMT if (RISCV_MMODE || SPL_RISCV_MMODE) imply SPL_CPU_SUPPORT
arch/riscv/cpu/fu540/Kconfig +1 -1
@@ -10,7 +10,7 @@ config SIFIVE_FU540 select SPL_RAM if SPL imply CPU imply CPU_RISCV - imply RISCV_TIMER + imply RISCV_TIMER if (RISCV_SMODE || SPL_RISCV_SMODE) imply SIFIVE_CLINT if (RISCV_MMODE || SPL_RISCV_MMODE) imply CMD_CPU imply SPL_CPU_SUPPORT
arch/riscv/cpu/generic/Kconfig +1 -1
@@ -7,7 +7,7 @@ config GENERIC_RISCV select ARCH_EARLY_INIT_R imply CPU imply CPU_RISCV - imply RISCV_TIMER + imply RISCV_TIMER if (RISCV_SMODE || SPL_RISCV_SMODE) imply SIFIVE_CLINT if (RISCV_MMODE || SPL_RISCV_MMODE) imply CMD_CPU imply SPL_CPU_SUPPORT
arch/riscv/lib/Makefile +0 -1
@@ -15,7 +15,6 @@ obj-$(CONFIG_SIFIVE_CLINT) += sifive_clint.o obj-$(CONFIG_ANDES_PLIC) += andes_plic.o obj-$(CONFIG_ANDES_PLMT) += andes_plmt.o else -obj-$(CONFIG_RISCV_RDTIME) += rdtime.o obj-$(CONFIG_SBI) += sbi.o obj-$(CONFIG_SBI_IPI) += sbi_ipi.o endif
arch/riscv/lib/rdtime.c deleted +0 -38
@@ -1,38 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* -* Copyright (C) 2018, Anup Patel <[email protected]> -* Copyright (C) 2018, Bin Meng <[email protected]> -* -* The riscv_get_time() API implementation that is using the -* standard rdtime instruction. -*/ - -#include <common.h> - -/* Implement the API required by RISC-V timer driver */ -int riscv_get_time (u64 *time) -{ -#ifdef CONFIG_64BIT -u64 n; - - __asm__ __volatile__ ( -"rdtime %0" - :"=r" (n)); - - *time = n; -#else -u32 lo, hi, tmp; - - __asm__ __volatile__ ( -"1:\n" -"rdtimeh %0\n" -"rdtime %1\n" -"rdtimeh %2\n" -"bne %0, %2, 1b" - :"=&r" (hi),"=&r" (lo),"=&r" (tmp)); - - *time = ((u64 )hi <<32 ) | lo; -#endif - -return 0 ; -}
drivers/timer/Kconfig +2 -2
@@ -146,8 +146,8 @@ config RISCV_TIMER bool "RISC-V timer support" depends on TIMER && RISCV help - Select this to enable support for the timer as defined - by the RISC-V privileged architecture spec. + Select this to enable support for a generic RISC-V S-Mode timer + driver. config ROCKCHIP_TIMER bool "Rockchip timer support"
drivers/timer/riscv_timer.c +20 -19
@@ -1,36 +1,37 @@// SPDX-License-Identifier: GPL-2.0+ /* +* Copyright (C) 2020, Sean Anderson <[email protected]> * Copyright (C) 2018, Bin Meng <[email protected]> +* Copyright (C) 2018, Anup Patel <[email protected]> +* Copyright (C) 2012 Regents of the University of California * -* RISC-V privileged architecture defined generic timer driver +* RISC-V architecturally-defined generic timer driver * -* This driver relies on RISC-V platform codes to provide the essential API -* riscv_get_time() which is supposed to return the timer counter as defined -* by the RISC-V privileged architecture spec. -* -* This driver can be used in both M-mode and S-mode U-Boot. +* This driver provides generic timer support for S-mode U-Boot. */ #include <common.h> #include <dm.h> #include <errno.h> #include <timer.h> -#include <asm/io.h> - -/** -* riscv_get_time() - get the timer counter -* -* Platform codes should provide this API in order to make this driver function. -* -* @time: the 64-bit timer count as defined by the RISC-V privileged -* architecture spec. -* @return: 0 on success, -ve on error. -*/ -extern int riscv_get_time (u64 *time); +#include <asm/csr.h> static int riscv_timer_get_count (struct udevice *dev,u64 *count) { -return riscv_get_time (count); +if (IS_ENABLED (CONFIG_64BIT )) { + *count =csr_read (CSR_TIME ); + }else { +u32 hi, lo; + +do { + hi =csr_read (CSR_TIMEH ); + lo =csr_read (CSR_TIME ); + }while (hi !=csr_read (CSR_TIMEH )); + + *count = ((u64 )hi <<32 ) | lo; + } + +return 0 ; }static int riscv_timer_probe (struct udevice *dev)
Signature · 1 line
2.28.0
PATCH v4 2/8 timer: Add helper for drivers using timebase fallback
In reply to Sean AndersonThis function is designed to be used when a timer used to be initialized by the cpu (e.g. RISC-V timers), but now is initialized by dm_timer_init. In such a case, the timer may prefer to use the clocks and clock-frequency properties, but should be able to fall back on using the cpu's timebase-frequency.
---
Changes in v4:
- New
drivers/timer/timer-uclass.c | 25 +++++++++++++++++++++++++ include/timer.h | 15 +++++++++++++++ 2 files changed, 40 insertions(+)
drivers/timer/timer-uclass.c +25 -0
@@ -4,6 +4,7 @@*/ #include <common.h> +#include <cpu.h> #include <dm.h> #include <init.h> #include <dm/lists.h>
@@ -79,6 +80,30 @@ static int timer_post_probe(struct udevice *dev)return 0 ; } +int timer_timebase_fallback (struct udevice *dev) +{ +struct udevice *cpu; +struct cpu_platdata *cpu_plat; +struct timer_dev_priv *uc_priv =dev_get_uclass_priv (dev); + +/* Did we get our clock rate from the device tree? */ +if (uc_priv->clock_rate) +return 0 ; + +/* Fall back to timebase-frequency */ +dev_dbg (dev,"missing clocks or clock-frequency property; falling back on timebase-frequency\n" ); + cpu =cpu_get_current_dev (); +if (!cpu) +return -ENODEV ; + + cpu_plat =dev_get_parent_platdata (cpu); +if (!cpu_plat) +return -ENODEV ; + + uc_priv->clock_rate = cpu_plat->timebase_freq; +return 0 ; +} +u64 timer_conv_64 (u32 count) {/* increment tbh if tbl has rolled over */
include/timer.h +15 -0
@@ -15,6 +15,21 @@*/ int dm_timer_init (void ); +/** +* timer_timebase_fallback() - Helper for timers using timebase fallback +* @dev: A timer partially-probed timer device +* +* This is a helper function designed for timers which need to fall back on the +* cpu's timebase. This function is designed to be called during the driver's +* probe(). If there is a clocks or clock-frequency property in the timer's +* binding, then it will be used. Otherwise, the timebase of the current cpu +* will be used. This is initialized by the cpu driver, and usually gotten from +* ``/cpus/timebase-frequency`` or ``/cpus/cpu at X/timebase-frequency``. +* +* Return: 0 if OK, or negative error code on failure +*/ +int timer_timebase_fallback (struct udevice *dev); +/* * timer_conv_64 - convert 32-bit counter value to 64-bit *
Signature · 1 line
2.28.0
PATCH v4 3/8 riscv: Rework Andes PLMT as a UCLASS_TIMER driver
In reply to Sean AndersonThis converts the PLMT driver from the riscv-specific timer interface to be a DM-based UCLASS_TIMER driver.
The clock-frequency/clocks properties are preferred over timebase-frequency for two reasons. First, properties which affect a device should be located near its binding in the device tree. Using timebase-frequency only really makes sense when the cpu itself is the timer device. This is the case when we read the time from a CSR, but not when there is a separate device. Second, it lets the device use the clock subsystem which adds flexibility. If the device is configured for a different clock speed, the timer can adjust itself.
---
This patch builds but has NOT been tested.
Changes in v4:
- Use timer_timebase_fallback
arch/riscv/Kconfig | 4 --- arch/riscv/dts/ae350_32.dts | 1 + arch/riscv/dts/ae350_64.dts | 1 + arch/riscv/include/asm/global_data.h | 3 -- arch/riscv/lib/andes_plmt.c | 44 +++++++++++++--------------- 5 files changed, 23 insertions(+), 30 deletions(-)
arch/riscv/Kconfig +0 -4
@@ -177,10 +177,6 @@ config ANDES_PLIC config ANDES_PLMT bool depends on RISCV_MMODE || SPL_RISCV_MMODE - select REGMAP - select SYSCON - select SPL_REGMAP if SPL - select SPL_SYSCON if SPL help The Andes PLMT block holds memory-mapped mtime register associated with timer tick.
arch/riscv/dts/ae350_32.dts +1 -0
@@ -162,6 +162,7 @@ &CPU2_intc 7 &CPU3_intc 7>; reg = <0xe6000000 0x100000>; + clock-frequency = <60000000>; }; };
arch/riscv/dts/ae350_64.dts +1 -0
@@ -162,6 +162,7 @@ &CPU2_intc 7 &CPU3_intc 7>; reg = <0x0 0xe6000000 0x0 0x100000>; + clock-frequency = <60000000>; }; };
arch/riscv/include/asm/global_data.h +0 -3
@@ -24,9 +24,6 @@ struct arch_global_data {#ifdef CONFIG_ANDES_PLIC void __iomem *plic;/* plic base address */ #endif -#ifdef CONFIG_ANDES_PLMT -void __iomem *plmt;/* plmt base address */ -#endif #if CONFIG_IS_ENABLED (SMP )struct ipi_data ipi[CONFIG_NR_CPUS ];#endif
arch/riscv/lib/andes_plmt.c +21 -23
73 lines not on this page · raw message
Signature · 1 line
2.28.0
PATCH v4 4/8 riscv: Clean up initialization in Andes PLIC
In reply to Sean AndersonThis merges the PLIC initialization code from two functions into one.
---
This patch builds but has NOT been tested.
(no changes since v1)
arch/riscv/lib/andes_plic.c | 58 ++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 33 deletions(-)
arch/riscv/lib/andes_plic.c +25 -33
@@ -41,53 +41,45 @@ static int enable_ipi(int hart)return 0 ; } -static int init_plic (void ) +int riscv_init_ipi (void ) { -struct udevice *dev; -ofnode node;int ret; +long *base =syscon_get_first_range (RISCV_SYSCON_PLIC ); +ofnode node; +struct udevice *dev;u32 reg; +if (IS_ERR (base)) +return PTR_ERR (base); + gd->arch.plic = base; + ret =uclass_find_first_device (UCLASS_CPU , &dev);if (ret)return ret; +else if (!dev) +return -ENODEV ; -if (dev) { -ofnode_for_each_subnode (node,dev_ofnode (dev->parent)) { -const char *device_type; +ofnode_for_each_subnode (node,dev_ofnode (dev->parent)) { +const char *device_type; - device_type =ofnode_read_string (node,"device_type" ); -if (!device_type) -continue ; + device_type =ofnode_read_string (node,"device_type" ); +if (!device_type) +continue ; -if (strcmp (device_type,"cpu" )) -continue ; +if (strcmp (device_type,"cpu" )) +continue ; -/* skip if hart is marked as not available */ -if (!ofnode_is_available (node)) -continue ; +/* skip if hart is marked as not available */ +if (!ofnode_is_available (node)) +continue ; -/* read hart ID of CPU */ - ret =ofnode_read_u32 (node,"reg" , ®); -if (ret ==0 ) -enable_ipi (reg); - } - -return 0 ; +/* read hart ID of CPU */ + ret =ofnode_read_u32 (node,"reg" , ®); +if (ret ==0 ) +enable_ipi (reg); } -return -ENODEV ; -} - -int riscv_init_ipi (void ) -{ -long *ret =syscon_get_first_range (RISCV_SYSCON_PLIC ); - -if (IS_ERR (ret)) -return PTR_ERR (ret); - gd->arch.plic = ret; - -return init_plic (); +return 0 ; }int riscv_send_ipi (int hart)
Signature · 1 line
2.28.0
PATCH v4 5/8 riscv: Rework Sifive CLINT as UCLASS_TIMER driver
In reply to Sean AndersonThis converts the clint driver from the riscv-specific interface to be a DM-based UCLASS_TIMER driver. In addition, the SiFive DDR driver previously implicitly depended on the CLINT to select REGMAP.
Unlike Andes's PLMT/PLIC (which AFAIK never have anything pass it a dtb), the SiFive CLINT is part of the device tree passed in by qemu. This device tree doesn't have a clocks or clock-frequency property on clint, so we need to fall back on the timebase-frequency property. Perhaps in the future we can get a clock-frequency property added to the qemu dtb.
Unlike with the Andes PLMT, the Sifive CLINT is also an IPI controller. RISCV_SYSCON_CLINT is retained for this purpose.
---
This patch builds but has only been tested on the K210 and QEMU. It has NOT been tested on a HiFive.
Changes in v4:
- Use timer_timebase_fallback
Changes in v3:
- Don't initialize the IPI in spl_invoke_opensbi. Further testing has revealed it to be unnecessary.
arch/riscv/Kconfig | 4 --- arch/riscv/lib/sifive_clint.c | 66 +++++++++++++++++++---------------- drivers/ram/sifive/Kconfig | 2 ++ 3 files changed, 38 insertions(+), 34 deletions(-)
arch/riscv/Kconfig +0 -4
@@ -155,10 +155,6 @@ config 64BIT config SIFIVE_CLINT bool depends on RISCV_MMODE || SPL_RISCV_MMODE - select REGMAP - select SYSCON - select SPL_REGMAP if SPL - select SPL_SYSCON if SPL help The SiFive CLINT block holds memory-mapped control and status registers associated with software and timer interrupts.
arch/riscv/lib/sifive_clint.c +36 -30
94 lines not on this page · raw message
drivers/ram/sifive/Kconfig +2 -0
@@ -9,5 +9,7 @@ config SIFIVE_FU540_DDR bool "SiFive FU540 DDR driver" depends on RAM_SIFIVE default y if TARGET_SIFIVE_FU540 + select REGMAP + select SPL_REGMAP if SPL help This enables DDR support for the platforms based on SiFive FU540 SoC.
Signature · 1 line
2.28.0
PATCH v4 6/8 riscv: clk: Add CLINT clock to kendryte clock driver
In reply to Sean AndersonAnother "virtual" clock (in the sense that it isn't configurable). This could possibly be done as a clock in the device tree, but I think this is a bit cleaner.
---
checkpatch still complains about this one, but I don't see any reason to break it up even further. It doesn't make sense to me to split the header file change from everything else.
(no changes since v2)
Changes in v2:
- Split Kendryte binding changes into their own commit
drivers/clk/kendryte/clk.c | 4 ++++ include/dt-bindings/clock/k210-sysctl.h | 1 + 2 files changed, 5 insertions(+)
drivers/clk/kendryte/clk.c +4 -0
@@ -646,6 +646,10 @@ static int k210_clk_probe(struct udevice *dev)REGISTER_GATE (K210_CLK_RTC ,"rtc" , in0);#undef REGISTER_GATE +/* The MTIME register in CLINT runs at one 50th the CPU clock speed */ +clk_dm (K210_CLK_CLINT , +clk_register_fixed_factor (NULL ,"clint" ,"cpu" ,0 ,1 ,50 )); +return 0 ; }
include/dt-bindings/clock/k210-sysctl.h +1 -0
@@ -55,5 +55,6 @@#define K210_CLK_OTP 43#define K210_CLK_RTC 44#define K210_CLK_ACLK 45 +#define K210_CLK_CLINT 46#endif /* CLOCK_K210_SYSCTL_H */
Signature · 1 line
2.28.0
PATCH v4 7/8 riscv: Update Kendryte device tree for new CLINT driver
In reply to Sean AndersonThe interrupt controller property is removed from the clint binding because the clint is not an interrupt-controller. That is, no other devices have an interrupt which is controlled by the clint.
---
Changes in v4:
- Remove clock-frequency property from k210 clint binding because we fall back on timebase-frequency
Changes in v2:
- New
arch/riscv/dts/k210.dtsi | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
arch/riscv/dts/k210.dtsi +4 -3
@@ -17,6 +17,8 @@ compatible = "kendryte,k210"; aliases { + cpu0 = &cpu0; + cpu1 = &cpu1; dma0 = &dmac0; gpio0 = &gpio0; gpio1 = &gpio1_0;
@@ -126,14 +128,13 @@ read-only; }; - clint0: interrupt-controller at 2000000 { + clint0: clint at 2000000 { #interrupt-cells = <1>; compatible = "kendryte,k210-clint", "riscv,clint0"; reg = <0x2000000 0xC000>; - interrupt-controller; interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>, <&cpu1_intc 3>, <&cpu1_intc 7>; - clocks = <&sysclk K210_CLK_CPU>; + clocks = <&sysclk K210_CLK_CLINT>; }; plic0: interrupt-controller at C000000 {
Signature · 1 line
2.28.0
PATCH v4 8/8 riscv: Update SiFive device tree for new CLINT driver
In reply to Sean AndersonWe currently do this in a u-boot specific dts, but hopefully we can get these bindings added in Linux in the future.
---
This patch builds but has NOT been tested.
Changes in v4:
- Both the Andes PMLT and Sifive CLINT now fall back on timebase-frequency, per discussion with Anup Patel
- Rebase
Changes in v3:
- Rebase
Changes in v2:
- Fix SiFive CLINT not getting tick-rate from rtcclk
arch/riscv/dts/fu540-c000-u-boot.dtsi | 8 ++++++-- arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 4 ++++ 2 files changed, 10 insertions(+), 2 deletions(-)
arch/riscv/dts/fu540-c000-u-boot.dtsi +6 -2
@@ -55,9 +55,13 @@ reg = <0x0 0x10070000 0x0 0x1000>; fuse-count = <0x1000>; }; - clint at 2000000 { + clint: clint at 2000000 { compatible = "riscv,clint0"; - interrupts-extended = <&cpu0_intc 3 &cpu0_intc 7 &cpu1_intc 3 &cpu1_intc 7 &cpu2_intc 3 &cpu2_intc 7 &cpu3_intc 3 &cpu3_intc 7 &cpu4_intc 3 &cpu4_intc 7>; + interrupts-extended = <&cpu0_intc 3 &cpu0_intc 7 + &cpu1_intc 3 &cpu1_intc 7 + &cpu2_intc 3 &cpu2_intc 7 + &cpu3_intc 3 &cpu3_intc 7 + &cpu4_intc 3 &cpu4_intc 7>; reg = <0x0 0x2000000 0x0 0xc0000>; u-boot,dm-spl; };
arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi +4 -0
@@ -34,6 +34,10 @@ }; +&clint { + clocks = <&rtcclk>; +}; + &qspi0 { u-boot,dm-spl;
Signature · 1 line
2.28.0
PATCH v4 2/8 timer: Add helper for drivers using timebase fallback
In reply to Sean AndersonQuoted 8 lines · Sean Anderson
This function is designed to be used when a timer used to be initialized by the cpu (e.g. RISC-V timers), but now is initialized by
dm_timer_init. In such a case, the timer may prefer to use the clocks and clock-frequency properties, but should be able to fall back on using the cpu's timebase-frequency.Signed-off-by Sean Anderson <[email protected]>
Quoted 9 lines
---
Changes in v4:
- Newdrivers/timer/timer-uclass.c | 25 +++++++++++++++++++++++++ include/timer.h | 15 +++++++++++++++ 2 files changed, 40 insertions(+)
Can this be tested with sandbox?
PATCH v4 2/8 timer: Add helper for drivers using timebase fallback
Quoted 14 lines · Simon Glass
Quoted 13 lines · Sean Anderson
This function is designed to be used when a timer used to be initialized by the cpu (e.g. RISC-V timers), but now is initialized by
dm_timer_init. In such a case, the timer may prefer to use the clocks and clock-frequency properties, but should be able to fall back on using the cpu's timebase-frequency.Signed-off-by Sean Anderson <[email protected]>---
Changes in v4:
- New
Quoted 9 lines
Quoted 4 lines
drivers/timer/timer-uclass.c | 25 +++++++++++++++++++++++++ include/timer.h | 15 +++++++++++++++ 2 files changed, 40 insertions(+)Reviewed-by Simon Glass <[email protected]>Can this be tested with sandbox?
Probably. I can add a test in the next revision.
--Sean
PATCH v4 2/8 timer: Add helper for drivers using timebase fallback
In reply to Sean AndersonQuoted 8 lines · Sean Anderson
This function is designed to be used when a timer used to be initialized by the cpu (e.g. RISC-V timers), but now is initialized by
dm_timer_init. In such a case, the timer may prefer to use the clocks and clock-frequency properties, but should be able to fall back on using the cpu's timebase-frequency.Signed-off-by Sean Anderson <[email protected]>
Quoted 9 lines
---
Changes in v4:
- Newdrivers/timer/timer-uclass.c | 25 +++++++++++++++++++++++++ include/timer.h | 15 +++++++++++++++ 2 files changed, 40 insertions(+)
PATCH v4 3/8 riscv: Rework Andes PLMT as a UCLASS_TIMER driver
In reply to Sean AndersonHi Sean,
Quoted 48 lines · Sean Anderson
This converts the PLMT driver from the riscv-specific timer interface to be a DM-based
UCLASS_TIMERdriver.The clock-frequency/clocks properties are preferred over timebase-frequency for two reasons. First, properties which affect a device should be located near its binding in the device tree. Using timebase-frequency only really makes sense when the cpu itself is the timer device. This is the case when we read the time from a CSR, but not when there is a separate device. Second, it lets the device use the clock subsystem which adds flexibility. If the device is configured for a different clock speed, the timer can adjust itself.
Signed-off-by Sean Anderson <[email protected]>Reviewed-by Rick Chen <[email protected]>---
This patch builds but has NOT been tested.Changes in v4:
- Usetimer_timebase_fallbackarch/riscv/Kconfig | 4 --- arch/riscv/dts/ae350_32.dts | 1 + arch/riscv/dts/ae350_64.dts | 1 + arch/riscv/include/asm/global_data.h | 3 -- arch/riscv/lib/andes_plmt.c | 44 +++++++++++++--------------- 5 files changed, 23 insertions(+), 30 deletions(-)arch/riscv/Kconfig +0
-4@@ -177,10 +177,6 @@ config ANDES_PLIC config ANDES_PLMT bool depends on RISCV_MMODE || SPL_RISCV_MMODE - select REGMAP - select SYSCON - select SPL_REGMAP if SPL - select SPL_SYSCON if SPL help The Andes PLMT block holds memory-mapped mtime register associated with timer tick.arch/riscv/dts/ae350_32.dts +0
-0
arch/riscv/dts/ae350_32.dts line 165
Quoted 4 lines
arch/riscv/dts/ae350_32.dts +1
-0@@ -162,6 +162,7 @@ &CPU2_intc 7 &CPU3_intc 7>; reg = <0xe6000000 0x100000>; + clock-frequency = <60000000>;
Is this change required to make the PLMT timer work?
Quoted 85 lines
arch/riscv/dts/ae350_32.dts +0
-0}; };arch/riscv/dts/ae350_64.dts +1
-0@@ -162,6 +162,7 @@ &CPU2_intc 7 &CPU3_intc 7>; reg = <0x0 0xe6000000 0x0 0x100000>; + clock-frequency = <60000000>; }; };arch/riscv/include/asm/global_data.h +0
-3@@ -24,9 +24,6 @@ struct arch_global_data {#ifdef CONFIG_ANDES_PLIC void __iomem *plic;/* plic base address */ #endif -#ifdef CONFIG_ANDES_PLMT -void __iomem *plmt;/* plmt base address */ -#endif #if CONFIG_IS_ENABLED (SMP )struct ipi_data ipi[CONFIG_NR_CPUS ];#endif arch/riscv/lib/andes_plmt.c +9
-21@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0+ /* * Copyright (C) 2019, Rick Chen <[email protected]> +* Copyright (C) 2020, Sean Anderson <[email protected]> * * U-Boot syscon driver for Andes's Platform Level Machine Timer (PLMT). * The PLMT block holds memory-mapped mtime register @@ -9,46 +10,43 @@#include <common.h> #include <dm.h> -#include <regmap.h> -#include <syscon.h> +#include <timer.h> #include <asm/io.h> -#include <asm/syscon.h> #include <linux/err.h> /* mtime register */ #define MTIME_REG (base) ((ulong)(base)) -DECLARE_GLOBAL_DATA_PTR ; - -#define PLMT_BASE_GET (void) \ - do { \ - long *ret; \ - \ - if (!gd->arch.plmt) { \ - ret = syscon_get_first_range(RISCV_SYSCON_PLMT); \ - if (IS_ERR(ret)) \ - return PTR_ERR(ret); \ - gd->arch.plmt = ret; \ - } \ - } while (0) - -int riscv_get_time (u64 *time) +static int andes_plmt_get_count (struct udevice *dev,u64 *count) { -PLMT_BASE_GET (); - - *time =readq ((void __iomem *)MTIME_REG (gd->arch.plmt)); + *count =readq ((void __iomem *)MTIME_REG (dev->priv));return 0 ; } +static const struct timer_ops andes_plmt_ops = { + .get_count = andes_plmt_get_count, +}; + +static int andes_plmt_probe (struct udevice *dev)
arch/riscv/lib/andes_plmt.c line 45
Quoted 10 lines
arch/riscv/lib/andes_plmt.c +8
-1+{ + dev->priv =dev_read_addr_ptr (dev); +if (!dev->priv) +return -EINVAL ; + +return timer_timebase_fallback (dev); +} +static const struct udevice_id andes_plmt_ids[] = { - { .compatible ="riscv,plmt0" , .data =RISCV_SYSCON_PLMT },
RISCV_SYSCON_PLMT should be removed from arch/riscv/include/asm/syscon.h
Quoted 4 lines
arch/riscv/lib/andes_plmt.c +1
-0+ { .compatible = "riscv,plmt0" }, { } };
arch/riscv/lib/andes_plmt.c
Quoted 10 lines
arch/riscv/lib/andes_plmt.c +3
-2U_BOOT_DRIVER (andes_plmt) = { .name ="andes_plmt" , - .id =UCLASS_SYSCON , + .id =UCLASS_TIMER , .of_match = andes_plmt_ids, + .ops = &andes_plmt_ops, + .probe = andes_plmt_probe, .flags =DM_FLAG_PRE_RELOC , }; --
Regards,
Bin
PATCH v4 5/8 riscv: Rework Sifive CLINT as UCLASS_TIMER driver
In reply to Sean AndersonHi Sean,
Quoted 153 lines · Sean Anderson
This converts the clint driver from the riscv-specific interface to be a DM-based
UCLASS_TIMERdriver. In addition, the SiFive DDR driver previously implicitly depended on the CLINT to select REGMAP.Unlike Andes's PLMT/PLIC (which AFAIK never have anything pass it a dtb), the SiFive CLINT is part of the device tree passed in by qemu. This device tree doesn't have a clocks or clock-frequency property on clint, so we need to fall back on the timebase-frequency property. Perhaps in the future we can get a clock-frequency property added to the qemu dtb.
Unlike with the Andes PLMT, the Sifive CLINT is also an IPI controller.
RISCV_SYSCON_CLINTis retained for this purpose.Signed-off-by Sean Anderson <[email protected]>Reviewed-by Pragnesh Patel <[email protected]>---
This patch builds but has only been tested on the K210 and QEMU. It has NOT been tested on a HiFive.Changes in v4:
- Usetimer_timebase_fallbackChanges in v3:
- Don't initialize the IPI inspl_invoke_opensbi. Further testing has revealed it to be unnecessary.arch/riscv/Kconfig | 4 --- arch/riscv/lib/sifive_clint.c | 66 +++++++++++++++++++---------------- drivers/ram/sifive/Kconfig | 2 ++ 3 files changed, 38 insertions(+), 34 deletions(-)arch/riscv/Kconfig +0
-4@@ -155,10 +155,6 @@ config 64BIT config SIFIVE_CLINT bool depends on RISCV_MMODE || SPL_RISCV_MMODE - select REGMAP - select SYSCON - select SPL_REGMAP if SPL - select SPL_SYSCON if SPL help The SiFive CLINT block holds memory-mapped control and status registers associated with software and timer interrupts.arch/riscv/lib/sifive_clint.c +36
-30@@ -8,9 +8,9 @@*/ #include <common.h> +#include <clk.h> #include <dm.h> -#include <regmap.h> -#include <syscon.h> +#include <timer.h> #include <asm/io.h> #include <asm/syscon.h> #include <linux/err.h> @@ -24,35 +24,19 @@DECLARE_GLOBAL_DATA_PTR ; -int riscv_get_time (u64 *time) -{ -/* ensure timer register base has a sane value */ -riscv_init_ipi (); - - *time =readq ((void __iomem *)MTIME_REG (gd->arch.clint)); - -return 0 ; -} - -int riscv_set_timecmp (int hart,u64 cmp) -{ -/* ensure timer register base has a sane value */ -riscv_init_ipi (); - -writeq (cmp, (void __iomem *)MTIMECMP_REG (gd->arch.clint, hart)); - -return 0 ; -} -int riscv_init_ipi (void ) { -if (!gd->arch.clint) { -long *ret =syscon_get_first_range (RISCV_SYSCON_CLINT ); +int ret; +struct udevice *dev; -if (IS_ERR (ret)) -return PTR_ERR (ret); - gd->arch.clint = ret; - } + ret =uclass_get_device_by_driver (UCLASS_TIMER , +DM_GET_DRIVER (sifive_clint), &dev); +if (ret) +return ret; + + gd->arch.clint =dev_read_addr_ptr (dev); +if (!gd->arch.clint) +return -EINVAL ;return 0 ; }@@ -78,14 +62,36 @@ int riscv_get_ipi(int hart, int *pending)return 0 ; } +static int sifive_clint_get_count (struct udevice *dev,u64 *count) +{ + *count =readq ((void __iomem *)MTIME_REG (dev->priv)); + +return 0 ; +} + +static const struct timer_ops sifive_clint_ops = { + .get_count = sifive_clint_get_count, +}; + +static int sifive_clint_probe (struct udevice *dev) +{ + dev->priv =dev_read_addr_ptr (dev); +if (!dev->priv) +return -EINVAL ; + +return timer_timebase_fallback (dev); +} +static const struct udevice_id sifive_clint_ids[] = { - { .compatible ="riscv,clint0" , .data =RISCV_SYSCON_CLINT }, + { .compatible ="riscv,clint0" }, { } };U_BOOT_DRIVER (sifive_clint) = { .name ="sifive_clint" , - .id =UCLASS_SYSCON , + .id =UCLASS_TIMER , .of_match = sifive_clint_ids, + .probe = sifive_clint_probe, + .ops = &sifive_clint_ops, .flags =DM_FLAG_PRE_RELOC , };drivers/ram/sifive/Kconfig +0
-0
drivers/ram/sifive/Kconfig config SIFIVE_FU540_DDR · line 13
Quoted 5 lines
drivers/ram/sifive/Kconfig +2
-0@@ -9,5 +9,7 @@ config SIFIVE_FU540_DDR bool "SiFive FU540 DDR driver" depends on RAM_SIFIVE default y if TARGET_SIFIVE_FU540 + select REGMAP + select SPL_REGMAP if SPL
This should be dropped. Please see the patch below:
http://patchwork.ozlabs.org/project/uboot/patch/1600157107-57175-2-git-send-email-bmeng.cn at gmail.com/
drivers/ram/sifive/Kconfig config SIFIVE_FU540_DDR
Quoted 3 lines
drivers/ram/sifive/Kconfig +0
-1help This enables DDR support for the platforms based on SiFive FU540 SoC. --
Regards,
Bin
PATCH v4 7/8 riscv: Update Kendryte device tree for new CLINT driver
In reply to Sean AndersonQuoted 12 lines · Sean Anderson
The interrupt controller property is removed from the clint binding because the clint is not an interrupt-controller. That is, no other devices have an interrupt which is controlled by the clint.
Signed-off-by Sean Anderson <[email protected]>---
Changes in v4:
- Remove clock-frequency property from k210 clint binding because we fall back on timebase-frequency
Quoted 6 lines
Changes in v2:
- Newarch/riscv/dts/k210.dtsi | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
LGTM
PATCH v4 8/8 riscv: Update SiFive device tree for new CLINT driver
In reply to Sean AndersonQuoted 17 lines · Sean Anderson
We currently do this in a u-boot specific dts, but hopefully we can get these bindings added in Linux in the future.
Signed-off-by Sean Anderson <[email protected]>Reviewed-by Pragnesh Patel <[email protected]>---
This patch builds but has NOT been tested.Changes in v4:
- Both the Andes PMLT and Sifive CLINT now fall back on timebase-frequency, per discussion with Anup Patel
- RebaseChanges in v3:
- Rebase
Quoted 7 lines
Changes in v2:
- Fix SiFive CLINT not getting tick-rate from rtcclkarch/riscv/dts/fu540-c000-u-boot.dtsi | 8 ++++++-- arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 4 ++++ 2 files changed, 10 insertions(+), 2 deletions(-)
PATCH v4 3/8 riscv: Rework Andes PLMT as a UCLASS_TIMER driver
In reply to Bin MengQuoted 49 lines · Bin Meng
Hi Sean,
Quoted 46 lines · Sean Anderson
This converts the PLMT driver from the riscv-specific timer interface to be a DM-based
UCLASS_TIMERdriver.The clock-frequency/clocks properties are preferred over timebase-frequency for two reasons. First, properties which affect a device should be located near its binding in the device tree. Using timebase-frequency only really makes sense when the cpu itself is the timer device. This is the case when we read the time from a CSR, but not when there is a separate device. Second, it lets the device use the clock subsystem which adds flexibility. If the device is configured for a different clock speed, the timer can adjust itself.
Signed-off-by Sean Anderson <[email protected]>Reviewed-by Rick Chen <[email protected]>---
This patch builds but has NOT been tested.Changes in v4:
- Usetimer_timebase_fallbackarch/riscv/Kconfig | 4 --- arch/riscv/dts/ae350_32.dts | 1 + arch/riscv/dts/ae350_64.dts | 1 + arch/riscv/include/asm/global_data.h | 3 -- arch/riscv/lib/andes_plmt.c | 44 +++++++++++++--------------- 5 files changed, 23 insertions(+), 30 deletions(-)arch/riscv/Kconfig +0
-4@@ -177,10 +177,6 @@ config ANDES_PLIC config ANDES_PLMT bool depends on RISCV_MMODE || SPL_RISCV_MMODE - select REGMAP - select SYSCON - select SPL_REGMAP if SPL - select SPL_SYSCON if SPL help The Andes PLMT block holds memory-mapped mtime register associated with timer tick.arch/riscv/dts/ae350_32.dts +0
-1--- a/arch/riscv/dts/ae350_32.dts
Quoted 8 lines
arch/riscv/dts/ae350_32.dts line 165
Quoted 6 lines
+++
b/arch/riscv/dts/ae350_32.dtsarch/riscv/dts/ae350_32.dts +1
-0@@ -162,6 +162,7 @@ &CPU2_intc 7 &CPU3_intc 7>; reg = <0xe6000000 0x100000>; + clock-frequency = <60000000>;Is this change required to make the PLMT timer work?
With the addition of timer_timebase_fallback it is not.
Quoted 116 lines
Quoted 85 lines
arch/riscv/dts/ae350_32.dts +0
-0}; };arch/riscv/dts/ae350_64.dts +1
-0@@ -162,6 +162,7 @@ &CPU2_intc 7 &CPU3_intc 7>; reg = <0x0 0xe6000000 0x0 0x100000>; + clock-frequency = <60000000>; }; };arch/riscv/include/asm/global_data.h +0
-3@@ -24,9 +24,6 @@ struct arch_global_data {#ifdef CONFIG_ANDES_PLIC void __iomem *plic;/* plic base address */ #endif -#ifdef CONFIG_ANDES_PLMT -void __iomem *plmt;/* plmt base address */ -#endif #if CONFIG_IS_ENABLED (SMP )struct ipi_data ipi[CONFIG_NR_CPUS ];#endif arch/riscv/lib/andes_plmt.c +9
-21@@ -1,6 +1,7 @@// SPDX-License-Identifier: GPL-2.0+ /* * Copyright (C) 2019, Rick Chen <[email protected]> +* Copyright (C) 2020, Sean Anderson <[email protected]> * * U-Boot syscon driver for Andes's Platform Level Machine Timer (PLMT). * The PLMT block holds memory-mapped mtime register @@ -9,46 +10,43 @@#include <common.h> #include <dm.h> -#include <regmap.h> -#include <syscon.h> +#include <timer.h> #include <asm/io.h> -#include <asm/syscon.h> #include <linux/err.h> /* mtime register */ #define MTIME_REG (base) ((ulong)(base)) -DECLARE_GLOBAL_DATA_PTR ; - -#define PLMT_BASE_GET (void) \ - do { \ - long *ret; \ - \ - if (!gd->arch.plmt) { \ - ret = syscon_get_first_range(RISCV_SYSCON_PLMT); \ - if (IS_ERR(ret)) \ - return PTR_ERR(ret); \ - gd->arch.plmt = ret; \ - } \ - } while (0) - -int riscv_get_time (u64 *time) +static int andes_plmt_get_count (struct udevice *dev,u64 *count) { -PLMT_BASE_GET (); - - *time =readq ((void __iomem *)MTIME_REG (gd->arch.plmt)); + *count =readq ((void __iomem *)MTIME_REG (dev->priv));return 0 ; } +static const struct timer_ops andes_plmt_ops = { + .get_count = andes_plmt_get_count, +}; + +static int andes_plmt_probe (struct udevice *dev)arch/riscv/lib/andes_plmt.c line 45
Quoted 10 lines
arch/riscv/lib/andes_plmt.c +8
-1+{ + dev->priv =dev_read_addr_ptr (dev); +if (!dev->priv) +return -EINVAL ; + +return timer_timebase_fallback (dev); +} +static const struct udevice_id andes_plmt_ids[] = { - { .compatible ="riscv,plmt0" , .data =RISCV_SYSCON_PLMT },
RISCV_SYSCON_PLMTshould be removed fromarch/riscv/include/asm/syscon.hQuoted 4 lines
arch/riscv/lib/andes_plmt.c +1
-0+ { .compatible = "riscv,plmt0" }, { } };arch/riscv/lib/andes_plmt.c
Quoted 10 lines
arch/riscv/lib/andes_plmt.c +3
-2U_BOOT_DRIVER (andes_plmt) = { .name ="andes_plmt" , - .id =UCLASS_SYSCON , + .id =UCLASS_TIMER , .of_match = andes_plmt_ids, + .ops = &andes_plmt_ops, + .probe = andes_plmt_probe, .flags =DM_FLAG_PRE_RELOC , }; --Regards,
Bin
PATCH v4 5/8 riscv: Rework Sifive CLINT as UCLASS_TIMER driver
In reply to Bin MengQuoted 156 lines · Bin Meng
Hi Sean,
Quoted 153 lines · Sean Anderson
This converts the clint driver from the riscv-specific interface to be a DM-based
UCLASS_TIMERdriver. In addition, the SiFive DDR driver previously implicitly depended on the CLINT to select REGMAP.Unlike Andes's PLMT/PLIC (which AFAIK never have anything pass it a dtb), the SiFive CLINT is part of the device tree passed in by qemu. This device tree doesn't have a clocks or clock-frequency property on clint, so we need to fall back on the timebase-frequency property. Perhaps in the future we can get a clock-frequency property added to the qemu dtb.
Unlike with the Andes PLMT, the Sifive CLINT is also an IPI controller.
RISCV_SYSCON_CLINTis retained for this purpose.Signed-off-by Sean Anderson <[email protected]>Reviewed-by Pragnesh Patel <[email protected]>---
This patch builds but has only been tested on the K210 and QEMU. It has NOT been tested on a HiFive.Changes in v4:
- Usetimer_timebase_fallbackChanges in v3:
- Don't initialize the IPI inspl_invoke_opensbi. Further testing has revealed it to be unnecessary.arch/riscv/Kconfig | 4 --- arch/riscv/lib/sifive_clint.c | 66 +++++++++++++++++++---------------- drivers/ram/sifive/Kconfig | 2 ++ 3 files changed, 38 insertions(+), 34 deletions(-)arch/riscv/Kconfig +0
-4@@ -155,10 +155,6 @@ config 64BIT config SIFIVE_CLINT bool depends on RISCV_MMODE || SPL_RISCV_MMODE - select REGMAP - select SYSCON - select SPL_REGMAP if SPL - select SPL_SYSCON if SPL help The SiFive CLINT block holds memory-mapped control and status registers associated with software and timer interrupts.arch/riscv/lib/sifive_clint.c +36
-30@@ -8,9 +8,9 @@*/ #include <common.h> +#include <clk.h> #include <dm.h> -#include <regmap.h> -#include <syscon.h> +#include <timer.h> #include <asm/io.h> #include <asm/syscon.h> #include <linux/err.h> @@ -24,35 +24,19 @@DECLARE_GLOBAL_DATA_PTR ; -int riscv_get_time (u64 *time) -{ -/* ensure timer register base has a sane value */ -riscv_init_ipi (); - - *time =readq ((void __iomem *)MTIME_REG (gd->arch.clint)); - -return 0 ; -} - -int riscv_set_timecmp (int hart,u64 cmp) -{ -/* ensure timer register base has a sane value */ -riscv_init_ipi (); - -writeq (cmp, (void __iomem *)MTIMECMP_REG (gd->arch.clint, hart)); - -return 0 ; -} -int riscv_init_ipi (void ) { -if (!gd->arch.clint) { -long *ret =syscon_get_first_range (RISCV_SYSCON_CLINT ); +int ret; +struct udevice *dev; -if (IS_ERR (ret)) -return PTR_ERR (ret); - gd->arch.clint = ret; - } + ret =uclass_get_device_by_driver (UCLASS_TIMER , +DM_GET_DRIVER (sifive_clint), &dev); +if (ret) +return ret; + + gd->arch.clint =dev_read_addr_ptr (dev); +if (!gd->arch.clint) +return -EINVAL ;return 0 ; }@@ -78,14 +62,36 @@ int riscv_get_ipi(int hart, int *pending)return 0 ; } +static int sifive_clint_get_count (struct udevice *dev,u64 *count) +{ + *count =readq ((void __iomem *)MTIME_REG (dev->priv)); + +return 0 ; +} + +static const struct timer_ops sifive_clint_ops = { + .get_count = sifive_clint_get_count, +}; + +static int sifive_clint_probe (struct udevice *dev) +{ + dev->priv =dev_read_addr_ptr (dev); +if (!dev->priv) +return -EINVAL ; + +return timer_timebase_fallback (dev); +} +static const struct udevice_id sifive_clint_ids[] = { - { .compatible ="riscv,clint0" , .data =RISCV_SYSCON_CLINT }, + { .compatible ="riscv,clint0" }, { } };U_BOOT_DRIVER (sifive_clint) = { .name ="sifive_clint" , - .id =UCLASS_SYSCON , + .id =UCLASS_TIMER , .of_match = sifive_clint_ids, + .probe = sifive_clint_probe, + .ops = &sifive_clint_ops, .flags =DM_FLAG_PRE_RELOC , };drivers/ram/sifive/Kconfig +0
-0@@ -9,5 +9,7 @@ config SIFIVE_FU540_DDR
Quoted 8 lines
drivers/ram/sifive/Kconfig config SIFIVE_FU540_DDR · line 13
Quoted 5 lines
drivers/ram/sifive/Kconfig +2
-0bool "SiFive FU540 DDR driver" depends on RAM_SIFIVE default y if TARGET_SIFIVE_FU540 + select REGMAP + select SPL_REGMAP if SPLThis should be dropped. Please see the patch below:
http://patchwork.ozlabs.org/project/uboot/patch/1600157107-57175-2-git-send-email-bmeng.cn at gmail.com/
Ok, I can drop this and add a dependency.
Quoted 7 lines
drivers/ram/sifive/Kconfig config SIFIVE_FU540_DDR
Quoted 3 lines
drivers/ram/sifive/Kconfig +0
-1help This enables DDR support for the platforms based on SiFive FU540 SoC. --Regards,
Bin