Skip to contentSkip to conversation

arm64: tegra: Wrong hsp_aon reg property size

PATCH Superseded Dipen Patel 2 participants 3 messages Sep 10, 2020 – Sep 11, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: tegra: Wrong hsp_aon reg property size

The hsp_aon node reg property size 0xa0000 will overlap with other resources. This patch fixes that wrong value with correct size 0x90000.

Fixes a38570c22e9d ("arm64: tegra: Add nodes for TCU on Tegra194")
---
 arch/arm64/boot/dts/nvidia/tegra194.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra194.dtsi +1 -1
index e9c90f0f44ff..93438d2b9469 100644
@@ -1161,7 +1161,7 @@
 
 		hsp_aon: hsp@c150000 {
 			compatible = "nvidia,tegra194-hsp", "nvidia,tegra186-hsp";
-			reg = <0x0c150000 0xa0000>;
+			reg = <0x0c150000 0x90000>;
 			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>,
 			             <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
 			             <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>,
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Dipen Patel

The hsp_aon node reg property size 0xa0000 will overlap with other resources. This patch fixes that wrong value with correct size 0x90000.

Fixes a38570c22e9d ("arm64: tegra: Add nodes for TCU on Tegra194")

I think there shouldn't be a newline between Signed-off-by and Fixes; otherwise,

Quoted 18 lines
---
  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra194.dtsi +1 -1
index e9c90f0f44ff..93438d2b9469 100644
@@ -1161,7 +1161,7 @@
 
  		hsp_aon: hsp@c150000 {
  			compatible = "nvidia,tegra194-hsp", "nvidia,tegra186-hsp";
-			reg = <0x0c150000 0xa0000>;
+			reg = <0x0c150000 0x90000>;
  			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>,
  			             <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
  			             <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>,
#2 lore raw
Quoted 4 lines · Mikko Perttunen
Quoted 3 lines · Dipen Patel

The hsp_aon node reg property size 0xa0000 will overlap with other resources. This patch fixes that wrong value with correct size 0x90000.

Quoted 8 lines
Quoted 3 lines
Fixes a38570c22e9d ("arm64: tegra: Add nodes for TCU on Tegra194")

I think there shouldn't be a newline between Signed-off-by and Fixes; otherwise,

Ok, will fix it in next version.

Quoted 17 lines
Quoted 17 lines

---
  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/nvidia/tegra194.dtsi +1 -1
index e9c90f0f44ff..93438d2b9469 100644
@@ -1161,7 +1161,7 @@
             hsp_aon: hsp@c150000 {
               compatible = "nvidia,tegra194-hsp", "nvidia,tegra186-hsp";
-            reg = <0x0c150000 0xa0000>;
+            reg = <0x0c150000 0x90000>;
               interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>,
                            <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>,
                            <GIC_SPI 135 IRQ_TYPE_LEVEL_HIGH>,