ARM: samsung: fix PM debug build with DEBUG_LL but !MMU
Subsystems (4)
Krzysztof Kozlowski
maintainerPATCH 1/2 ARM: samsung: fix PM debug build with DEBUG_LL but !MMU
Selecting CONFIG_SAMSUNG_PM_DEBUG (depending on CONFIG_DEBUG_LL) but without CONFIG_MMU leads to build errors:
arch/arm/plat-samsung/pm-debug.c: In function ‘s3c_pm_uart_base’:
arch/arm/plat-samsung/pm-debug.c:57:2: error:
implicit declaration of function ‘debug_ll_addr’ [-Werror=implicit-function-declaration]
---
Patchset is rebased on v5.9-rc1.
--- arch/arm/plat-samsung/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/plat-samsung/Kconfig +1 -0
@@ -241,6 +241,7 @@ config SAMSUNG_PM_DEBUG depends on PM && DEBUG_KERNEL depends on PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210 depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART + depends on DEBUG_LL && MMU help Say Y here if you want verbose debugging from the PM Suspend and Resume code. See <file:Documentation/arm/samsung-s3c24xx/suspend.rst>
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerPATCH 2/2 ARM: s3c24xx: fix Wunused-variable warning on !MMU
If S3C24xx machine code is build without CONFIG_MMU, the iotable() macros do nothing so annotate structures to get rid of warnings:
arch/arm/mach-s3c24xx/common.c:140:24: warning: ‘s3c_iodesc’ defined but not used [-Wunused-variable] arch/arm/mach-s3c24xx/s3c2410.c:49:24: warning: ‘s3c2410_iodesc’ defined but not used [-Wunused-variable] arch/arm/mach-s3c24xx/s3c2412.c:60:24: warning: ‘s3c2412_iodesc’ defined but not used [-Wunused-variable] arch/arm/mach-s3c24xx/s3c2416.c:54:24: warning: ‘s3c2416_iodesc’ defined but not used [-Wunused-variable] arch/arm/mach-s3c24xx/s3c2443.c:45:24: warning: ‘s3c2443_iodesc’ defined but not used [-Wunused-variable] arch/arm/mach-s3c24xx/s3c244x.c:44:24: warning: ‘s3c244x_iodesc’ defined but not used [-Wunused-variable]
--- arch/arm/mach-s3c24xx/common.c | 2 +- arch/arm/mach-s3c24xx/s3c2410.c | 2 +- arch/arm/mach-s3c24xx/s3c2412.c | 2 +- arch/arm/mach-s3c24xx/s3c2416.c | 2 +- arch/arm/mach-s3c24xx/s3c2443.c | 2 +- arch/arm/mach-s3c24xx/s3c244x.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/mach-s3c24xx/common.c +1 -1
@@ -137,7 +137,7 @@ static struct cpu_table cpu_ids[] __initdata = {/* minimal IO mapping */ -static struct map_desc s3c_iodesc[]__initdata = { +static struct map_desc s3c_iodesc[]__initdata __maybe_unused = {IODESC_ENT (GPIO ),IODESC_ENT (IRQ ),IODESC_ENT (MEMCTRL ),
arch/arm/mach-s3c24xx/s3c2410.c +1 -1
@@ -46,7 +46,7 @@/* Initial IO mappings */ -static struct map_desc s3c2410_iodesc[]__initdata = { +static struct map_desc s3c2410_iodesc[]__initdata __maybe_unused = {IODESC_ENT (CLKPWR ),IODESC_ENT (TIMER ),IODESC_ENT (WATCHDOG ),
arch/arm/mach-s3c24xx/s3c2412.c +1 -1
@@ -57,7 +57,7 @@ static inline void s3c2412_init_gpio2(void)/* Initial IO mappings */ -static struct map_desc s3c2412_iodesc[]__initdata = { +static struct map_desc s3c2412_iodesc[]__initdata __maybe_unused = {IODESC_ENT (CLKPWR ),IODESC_ENT (TIMER ),IODESC_ENT (WATCHDOG ),
arch/arm/mach-s3c24xx/s3c2416.c +1 -1
@@ -51,7 +51,7 @@#include "nand-core.h" #include "spi-core.h" -static struct map_desc s3c2416_iodesc[]__initdata = { +static struct map_desc s3c2416_iodesc[]__initdata __maybe_unused = {IODESC_ENT (WATCHDOG ),IODESC_ENT (CLKPWR ),IODESC_ENT (TIMER ),
arch/arm/mach-s3c24xx/s3c2443.c +1 -1
@@ -42,7 +42,7 @@#include "nand-core.h" #include "spi-core.h" -static struct map_desc s3c2443_iodesc[]__initdata = { +static struct map_desc s3c2443_iodesc[]__initdata __maybe_unused = {IODESC_ENT (WATCHDOG ),IODESC_ENT (CLKPWR ),IODESC_ENT (TIMER ),
arch/arm/mach-s3c24xx/s3c244x.c +1 -1
@@ -41,7 +41,7 @@#include "nand-core.h" #include "regs-dsc.h" -static struct map_desc s3c244x_iodesc[]__initdata = { +static struct map_desc s3c244x_iodesc[]__initdata __maybe_unused = {IODESC_ENT (CLKPWR ),IODESC_ENT (TIMER ),IODESC_ENT (WATCHDOG ),
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 12 lines · Krzysztof Kozlowski
Selecting
CONFIG_SAMSUNG_PM_DEBUG(depending onCONFIG_DEBUG_LL) but withoutCONFIG_MMUleads to build errors:
arch/arm/plat-samsung/pm-debug.c: In function ‘s3c_pm_uart_base’:
arch/arm/plat-samsung/pm-debug.c:57:2: error:
implicit declaration of function ‘debug_ll_addr’ [-Werror=implicit-function-declaration]Reported-by kernel test robot <[email protected]>Fixes 99b2fc2b8b40 ("ARM: SAMSUNG: Use debug_ll_addr() to get UART base address")Cc <[email protected]>Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 5 lines
---
Patchset is rebased on v5.9-rc1.
--- arch/arm/plat-samsung/Kconfig | 1 +
Applied.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH 2/2] ARM: s3c24xx: fix Wunused-variable warning on !MMU
In reply to Krzysztof KozlowskiQuoted 11 lines · Krzysztof Kozlowski
If S3C24xx machine code is build without
CONFIG_MMU, theiotable()macros do nothing so annotate structures to get rid of warnings:
arch/arm/mach-s3c24xx/common.c:140:24: warning: ‘s3c_iodesc’ defined but not used [-Wunused-variable]arch/arm/mach-s3c24xx/s3c2410.c:49:24: warning: ‘s3c2410_iodesc’ defined but not used [-Wunused-variable]arch/arm/mach-s3c24xx/s3c2412.c:60:24: warning: ‘s3c2412_iodesc’ defined but not used [-Wunused-variable]arch/arm/mach-s3c24xx/s3c2416.c:54:24: warning: ‘s3c2416_iodesc’ defined but not used [-Wunused-variable]arch/arm/mach-s3c24xx/s3c2443.c:45:24: warning: ‘s3c2443_iodesc’ defined but not used [-Wunused-variable]arch/arm/mach-s3c24xx/s3c244x.c:44:24: warning: ‘s3c244x_iodesc’ defined but not used [-Wunused-variable]Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 8 lines
--- arch/arm/mach-s3c24xx/common.c | 2 +- arch/arm/mach-s3c24xx/s3c2410.c | 2 +- arch/arm/mach-s3c24xx/s3c2412.c | 2 +- arch/arm/mach-s3c24xx/s3c2416.c | 2 +- arch/arm/mach-s3c24xx/s3c2443.c | 2 +- arch/arm/mach-s3c24xx/s3c244x.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
Applied.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel