Skip to contentSkip to conversation

nitro_enclaves: Add Kconfig for the Nitro Enclaves driver

PATCH Greg KH 2 participants 6 messages Sep 14, 2020 – Sep 22, 2020 2 messages not in the archive KVM

lore
Share & tools
lore
#3 lore raw
Quoted 7 lines · Greg KH
Quoted 2 lines · Andra Paraschiv

I can't take patches without any changelog text at all, sorry.

Same for a few other patches in this series :(

I can move the changelog text before the Sob tag(s) for all the patches. I also can add a summary phrase in the commit message for the commits like this one that have only the commit title and Sob & Rb tags.

Would these updates to the commit messages match the expectations?

Let me know if remaining feedback to discuss and I should include as updates in v10. Otherwise, I can send the new revision with the updated commit messages.

Thanks for review.

Andra

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

#4 lore raw
Quoted 11 lines · Andra-Irina
Quoted 7 lines · Greg KH
Quoted 2 lines · Andra Paraschiv

I can't take patches without any changelog text at all, sorry.

Same for a few other patches in this series :(

Quoted 7 lines

I can move the changelog text before the Sob tag(s) for all the patches. I also can add a summary phrase in the commit message for the commits like this one that have only the commit title and Sob & Rb tags.

Would these updates to the commit messages match the expectations?

Let me know if remaining feedback to discuss and I should include as updates in v10. Otherwise, I can send the new revision with the updated commit messages.

Thanks for review.

Here we go, I published v10, including the updated commit messages and rebased on top of v5.9-rc6.

https://lore.kernel.org/lkml/[email protected]/

Any additional feedback, open to discuss.

If all looks good, we can move forward as we've talked before, to have the patch series on the char-misc branch and target v5.10-rc1.

Thanks,
Andra

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

#5 lore raw
Quoted 22 lines · Andra-Irina
Quoted 11 lines · Andra-Irina
Quoted 7 lines · Greg KH
Quoted 2 lines · Andra Paraschiv

I can't take patches without any changelog text at all, sorry.

Same for a few other patches in this series :(

Quoted 7 lines

I can move the changelog text before the Sob tag(s) for all the patches. I also can add a summary phrase in the commit message for the commits like this one that have only the commit title and Sob & Rb tags.

Would these updates to the commit messages match the expectations?

Let me know if remaining feedback to discuss and I should include as updates in v10. Otherwise, I can send the new revision with the updated commit messages.

Thanks for review.

Quoted 7 lines

Here we go, I published v10, including the updated commit messages and rebased on top of v5.9-rc6.

https://lore.kernel.org/lkml/[email protected]/

Any additional feedback, open to discuss.

If all looks good, we can move forward as we've talked before, to have the patch series on the char-misc branch and target v5.10-rc1.

Thanks for merging the patch series on the char-misc-testing branch and for the review sessions we've had.

Let's see how all goes next; if anything in the meantime to be done (e.g. and not coming via auto-generated mails), just let me know.

Andra

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.

author
#6 lore raw
Quoted 37 lines · Andra-Irina
Quoted 34 lines · Andra-Irina
Quoted 16 lines · Andra-Irina
Quoted 7 lines · Greg KH
Quoted 2 lines · Andra Paraschiv

I can't take patches without any changelog text at all, sorry.

Same for a few other patches in this series :(

I can move the changelog text before the Sob tag(s) for all the patches. I also can add a summary phrase in the commit message for the commits like this one that have only the commit title and Sob & Rb tags.

Quoted 7 lines

Would these updates to the commit messages match the expectations?

Let me know if remaining feedback to discuss and I should include as updates in v10. Otherwise, I can send the new revision with the updated commit messages.

Thanks for review.

Here we go, I published v10, including the updated commit messages and rebased on top of v5.9-rc6.

https://lore.kernel.org/lkml/[email protected]/

Any additional feedback, open to discuss.

Quoted 8 lines
Quoted 2 lines

If all looks good, we can move forward as we've talked before, to have the patch series on the char-misc branch and target v5.10-rc1.

Thanks for merging the patch series on the char-misc-testing branch and for the review sessions we've had.

Let's see how all goes next; if anything in the meantime to be done (e.g. and not coming via auto-generated mails), just let me know.

Will do, thanks for sticking with this and cleaning it up to look a lot better than the original submission.

Now comes the real work, maintaining it for the next 10 years :)

greg k-h

#7 lore raw
Quoted 35 lines · Greg KH
Quoted 34 lines · Andra-Irina
Quoted 32 lines · Andra-Irina
Quoted 14 lines · Andra-Irina
Quoted 7 lines · Greg KH
Quoted 2 lines · Andra Paraschiv

I can't take patches without any changelog text at all, sorry.

Same for a few other patches in this series :(

I can move the changelog text before the Sob tag(s) for all the patches. I also can add a summary phrase in the commit message for the commits like this one that have only the commit title and Sob & Rb tags.

Quoted 7 lines

Would these updates to the commit messages match the expectations?

Let me know if remaining feedback to discuss and I should include as updates in v10. Otherwise, I can send the new revision with the updated commit messages.

Thanks for review.

Here we go, I published v10, including the updated commit messages and rebased on top of v5.9-rc6.

https://lore.kernel.org/lkml/[email protected]/

Any additional feedback, open to discuss.

If all looks good, we can move forward as we've talked before, to have the patch series on the char-misc branch and target v5.10-rc1.

Quoted 7 lines
Quoted 5 lines

Thanks for merging the patch series on the char-misc-testing branch and for the review sessions we've had.

Let's see how all goes next; if anything in the meantime to be done (e.g. and not coming via auto-generated mails), just let me know.

Will do, thanks for sticking with this and cleaning it up to look a lot better than the original submission.

And this also came with a couple of lessons learnt that I've applied or will apply for other pieces of codebase as well, either for the Linux kernel or other projects.

Quoted 2 lines

Now comes the real work, maintaining it for the next 10 years :)

I agree, maintenance is equally important. There is an ongoing process to make sure the whole ecosystem continues to work.

Andra

Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.