Skip to contentSkip to conversation

nvme-fc: soften messages logged by error_recovery

PATCH In review James Smart 3 participants 3 messages Sep 11, 2020 – Oct 22, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-fc: soften messages logged by error_recovery

Several of the messages logged vi nvme_fc_error_recovery() come across as rather strong events due to the use of the word "error". This is causing some interpretations to be overly worried.

Soften the wording of the messages.

---
 drivers/nvme/host/fc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/host/fc.c +2 -2
index e8ef42b9d50c..bc4e1af587cc 100644
@@ -2433,7 +2433,7 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg)
 		return;
 
 	dev_warn(ctrl->ctrl.device,
-		"NVME-FC{%d}: transport association error detected: %s\n",
+		"NVME-FC{%d}: transport association event: %s\n",
 		ctrl->cnum, errmsg);
 	dev_warn(ctrl->ctrl.device,
 		"NVME-FC{%d}: resetting controller\n", ctrl->cnum);
@@ -2454,7 +2454,7 @@ nvme_fc_timeout(struct request *rq, bool reserved)
 	 * the host/io stack, terminate the association on the link,
 	 * and recreate an association on the link.
 	 */
-	nvme_fc_error_recovery(ctrl, "io timeout error");
+	nvme_fc_error_recovery(ctrl, "io timeout");
 
 	/*
 	 * the io abort has been initiated. Have the reset timer
Signature · 7 lines
2.26.2


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Reviewed-by on v1 1/1
#1 lore raw
Quoted 45 lines · James Smart

Several of the messages logged vi nvme_fc_error_recovery() come across as rather strong events due to the use of the word "error". This is causing some interpretations to be overly worried.

Soften the wording of the messages.

---
drivers/nvme/host/fc.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/host/fc.c +2 -2
index e8ef42b9d50c..bc4e1af587cc 100644
@@ -2433,7 +2433,7 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg)
 		return;
 
 	dev_warn(ctrl->ctrl.device,
-		"NVME-FC{%d}: transport association error detected: %s\n",
+		"NVME-FC{%d}: transport association event: %s\n",
 		ctrl->cnum, errmsg);
 	dev_warn(ctrl->ctrl.device,
 		"NVME-FC{%d}: resetting controller\n", ctrl->cnum);
@@ -2454,7 +2454,7 @@ nvme_fc_timeout(struct request *rq, bool reserved)
 	 * the host/io stack, terminate the association on the link,
 	 * and recreate an association on the link.
 	 */
-	nvme_fc_error_recovery(ctrl, "io timeout error");
+	nvme_fc_error_recovery(ctrl, "io timeout");
 
 	/*
 	 * the io abort has been initiated. Have the reset timer
Signature · 7 lines
2.26.2


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

Looks Good.

--
Himanshu Madhani Oracle Linux Engineering

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme