Skip to contentSkip to conversation

MAINTAINERS: make linux-mediatek list remarks consistent

PATCH In review Lukas Bulwahn 3 participants 14 messages Sep 14, 2020 – Sep 15, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: make linux-mediatek list remarks consistent

Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller support") does not mention that [email protected] is moderated for non-subscribers, but the other eight entries for [email protected] do.

Adjust this entry to be consistent with all others.

---
applies cleanly on v5.9-rc5 and next-20200911

Ryder, please ack.

Bjorn, Matthias, please pick this minor non-urgent clean-up patch.

This patch submission will also show me if linux-mediatek is moderated or not. I have not subscribed to linux-mediatek and if it shows up quickly in the archive, the list is probably not moderated; and if it takes longer, it is moderated, and hence, validating the patch.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 5e6e36542c62..83c83d7ef2a5 100644
@@ -13485,7 +13485,7 @@ F:	drivers/pci/controller/dwc/pcie-histb.c
 PCIE DRIVER FOR MEDIATEK
 M:	Ryder Lee <[email protected]>
 L:	[email protected]
-L:	[email protected]
+L:	[email protected] (moderated for non-subscribers)
 S:	Supported
 F:	Documentation/devicetree/bindings/pci/mediatek*
 F:	drivers/pci/controller/*mediatek*
Signature · 1 line
2.17.1
#1 lore raw
Quoted 11 lines · Lukas Bulwahn

Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller support") does not mention that [email protected] is moderated for non-subscribers, but the other eight entries for [email protected] do.

Adjust this entry to be consistent with all others.

---
applies cleanly on v5.9-rc5 and next-20200911

Quoted 9 lines

Ryder, please ack.

Bjorn, Matthias, please pick this minor non-urgent clean-up patch.

This patch submission will also show me if linux-mediatek is moderated or not. I have not subscribed to linux-mediatek and if it shows up quickly in the archive, the list is probably not moderated; and if it takes longer, it is moderated, and hence, validating the patch.

Okay, my patch showed up within seconds in the archive:

https://lore.kernel.org/linux-mediatek/[email protected]/

I think the linux-mediatek list is actually NOT _moderated for non-subscribers_.

Please IGNORE this patch until someone can confirm if it is moderated or not. I will then send the patch that reflects the actual state.

Thanks, Lukas

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Lukas Bulwahn
Quoted 8 lines · Lukas Bulwahn

Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller support") does not mention that [email protected] is moderated for non-subscribers, but the other eight entries for [email protected] do.

Adjust this entry to be consistent with all others.

Maybe rephrase the commit message to something like:
"Mark [email protected] as moderated for the MediaTek PCIe host controller entry, as the list actually is moderated."

Anyway:

Quoted 11 lines

---
applies cleanly on v5.9-rc5 and next-20200911

Ryder, please ack.

Bjorn, Matthias, please pick this minor non-urgent clean-up patch.

This patch submission will also show me if linux-mediatek is moderated or not. I have not subscribed to linux-mediatek and if it shows up quickly in the archive, the list is probably not moderated; and if it takes longer, it is moderated, and hence, validating the patch.

I can affirm the list is moderated :)

Quoted 18 lines
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index 5e6e36542c62..83c83d7ef2a5 100644
@@ -13485,7 +13485,7 @@ F:	drivers/pci/controller/dwc/pcie-histb.c
  PCIE DRIVER FOR MEDIATEK
  M:	Ryder Lee <[email protected]>
  L:	[email protected]
-L:	[email protected]
+L:	[email protected] (moderated for non-subscribers)
  S:	Supported
  F:	Documentation/devicetree/bindings/pci/mediatek*
  F:	drivers/pci/controller/*mediatek*
#3 lore raw
Quoted 24 lines · Matthias Brugger
Quoted 8 lines · Lukas Bulwahn

Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller support") does not mention that [email protected] is moderated for non-subscribers, but the other eight entries for [email protected] do.

Adjust this entry to be consistent with all others.

Maybe rephrase the commit message to something like:
"Mark [email protected] as moderated for the MediaTek PCIe host controller entry, as the list actually is moderated."

Anyway:

Quoted 5 lines

---
applies cleanly on v5.9-rc5 and next-20200911

Ryder, please ack.

Quoted 9 lines
Quoted 6 lines

Bjorn, Matthias, please pick this minor non-urgent clean-up patch.

This patch submission will also show me if linux-mediatek is moderated or not. I have not subscribed to linux-mediatek and if it shows up quickly in the archive, the list is probably not moderated; and if it takes longer, it is moderated, and hence, validating the patch.

I can affirm the list is moderated :)

Hmm, do we mean the same "moderation" here?

I believe a mailing list with the remark "moderated for non-subscribers" means that a mail from an address that has not subscribed to the mailing list is put on hold and needs to be manually permitted to be seen on the mailing list.

Matthias, is that also your understanding of "moderated for non-subscribers" for your Reviewed-by tag?

I am not subscribed to linux-mediatek. When I sent an email to the list, it showed up really seconds later in the lore.kernel.org of the linux-mediatek public-inbox repository. So, either it was delivered quickly as it is not moderated or my check with lore.kernel.org is wrong, e.g., mails show up in the lore.kernel.org archive, even they were not yet permitted on the actual list.

Lukas

maintainer
#4 lore raw
Quoted 40 lines · Lukas Bulwahn
Quoted 24 lines · Matthias Brugger
Quoted 8 lines · Lukas Bulwahn

Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller support") does not mention that [email protected] is moderated for non-subscribers, but the other eight entries for [email protected] do.

Adjust this entry to be consistent with all others.

Maybe rephrase the commit message to something like:
"Mark [email protected] as moderated for the MediaTek PCIe host controller entry, as the list actually is moderated."

Anyway:

Quoted 5 lines

---
applies cleanly on v5.9-rc5 and next-20200911

Ryder, please ack.

Quoted 9 lines
Quoted 6 lines

Bjorn, Matthias, please pick this minor non-urgent clean-up patch.

This patch submission will also show me if linux-mediatek is moderated or not. I have not subscribed to linux-mediatek and if it shows up quickly in the archive, the list is probably not moderated; and if it takes longer, it is moderated, and hence, validating the patch.

I can affirm the list is moderated :)

Hmm, do we mean the same "moderation" here?

Quoted 7 lines

I believe a mailing list with the remark "moderated for non-subscribers" means that a mail from an address that has not subscribed to the mailing list is put on hold and needs to be manually permitted to be seen on the mailing list.

Matthias, is that also your understanding of "moderated for non-subscribers" for your Reviewed-by tag?

Yes.

Quoted 8 lines

I am not subscribed to linux-mediatek. When I sent an email to the list, it showed up really seconds later in the lore.kernel.org of the linux-mediatek public-inbox repository. So, either it was delivered quickly as it is not moderated or my check with lore.kernel.org is wrong, e.g., mails show up in the lore.kernel.org archive, even they were not yet permitted on the actual list.

I'm the moderator and I get requests to moderate emails. I suppose I added you to the accepted list because of earlier emails you send.

Regards,
Matthias

#5 lore raw
Quoted 51 lines · Matthias Brugger
Quoted 48 lines · Lukas Bulwahn
Quoted 34 lines · Matthias Brugger
Quoted 8 lines · Lukas Bulwahn

Commit 637cfacae96f ("PCI: mediatek: Add MediaTek PCIe host controller support") does not mention that [email protected] is moderated for non-subscribers, but the other eight entries for [email protected] do.

Adjust this entry to be consistent with all others.

Maybe rephrase the commit message to something like:
"Mark [email protected] as moderated for the MediaTek PCIe host controller entry, as the list actually is moderated."

Anyway:

Quoted 7 lines

---
applies cleanly on v5.9-rc5 and next-20200911

Ryder, please ack.

Bjorn, Matthias, please pick this minor non-urgent clean-up patch.

Quoted 7 lines

This patch submission will also show me if linux-mediatek is moderated or
not. I have not subscribed to linux-mediatek and if it shows up quickly in
the archive, the list is probably not moderated; and if it takes longer, it
is moderated, and hence, validating the patch.

Quoted 2 lines

I can affirm the list is moderated :)

Hmm, do we mean the same "moderation" here?

I believe a mailing list with the remark "moderated for non-subscribers" means that a mail from an address that has not subscribed to the mailing list is put on hold and needs to be manually permitted to be seen on the mailing list.

Quoted 5 lines
Quoted 2 lines

Matthias, is that also your understanding of "moderated for non-subscribers" for your Reviewed-by tag?

Yes.

Okay, then I guess my patch is actually VALID and can be applied.

Quoted 9 lines
Quoted 8 lines

I am not subscribed to linux-mediatek. When I sent an email to the list, it showed up really seconds later in the lore.kernel.org of the linux-mediatek public-inbox repository. So, either it was delivered quickly as it is not moderated or my check with lore.kernel.org is wrong, e.g., mails show up in the lore.kernel.org archive, even they were not yet permitted on the actual list.

Quoted 3 lines

I'm the moderator and I get requests to moderate emails. I suppose I added you to the accepted list because of earlier emails you send.

Okay, I see. I did send some clean-up patch in the past, but I completely forgot that, but my mailbox did not forget. So, now it is clear to me why that mail showed up so quickly.

Thanks for the explanation.

Bjorn, with that confirmation and Reviewed-by from Matthias, could you please pick this patch?

Lukas

#6 lore raw
Quoted 12 lines · Lukas Bulwahn
Quoted 11 lines
Quoted 7 lines

I am not subscribed to linux-mediatek. When I sent an email to the list, it showed up really seconds later in the lore.kernel.org of the linux-mediatek public-inbox repository. So, either it was delivered quickly as it is not moderated or my check with lore.kernel.org is wrong, e.g., mails show up in the lore.kernel.org archive, even they were not yet permitted on the actual list.

I'm the moderator and I get requests to moderate emails. I suppose I added you to the accepted list because of earlier emails you send.

Quoted 5 lines

Okay, I see. I did send some clean-up patch in the past, but I completely forgot that, but my mailbox did not forget. So, now it is clear to me why that mail showed up so quickly.

Thanks for the explanation.

AFAICT the linux-mediatek list isn't configured to automatically moderate messages from non-subscribers. Its generic_nonmember_action setting is 'Accept'. That is the default setting for lists on infradead.org and I strongly encourage list maintainers to leave it that way.

Lukas, I don't see your address in the allowlist either.

There are other reasons why some messages get might trapped for moderation — the message size, number of recipients, spam score, etc.

The mere fact that *some* messages are moderated does not mean that the list is "moderated for non-subscribers" in the sense that the MAINTAINERS file lists.

Quoted 2 lines

Bjorn, with that confirmation and Reviewed-by from Matthias, could you please pick this patch?

I think we should be fixing the ones that *do* say it's moderated for non-subscribers, not the one that correctly didn't :)

#7 lore raw
Quoted 34 lines · David Woodhouse
Quoted 12 lines · Lukas Bulwahn
Quoted 11 lines
Quoted 7 lines

I am not subscribed to linux-mediatek. When I sent an email to the list, it showed up really seconds later in the lore.kernel.org of the linux-mediatek public-inbox repository. So, either it was delivered quickly as it is not moderated or my check with lore.kernel.org is wrong, e.g., mails show up in the lore.kernel.org archive, even they were not yet permitted on the actual list.

I'm the moderator and I get requests to moderate emails. I suppose I added you to the accepted list because of earlier emails you send.

Quoted 5 lines

Okay, I see. I did send some clean-up patch in the past, but I completely forgot that, but my mailbox did not forget. So, now it is clear to me why that mail showed up so quickly.

Thanks for the explanation.

AFAICT the linux-mediatek list isn't configured to automatically moderate messages from non-subscribers. Its generic_nonmember_action setting is 'Accept'. That is the default setting for lists on infradead.org and I strongly encourage list maintainers to leave it that way.

Lukas, I don't see your address in the allowlist either.

There are other reasons why some messages get might trapped for moderation — the message size, number of recipients, spam score, etc.

The mere fact that *some* messages are moderated does not mean that the list is "moderated for non-subscribers" in the sense that the MAINTAINERS file lists.

Quoted 6 lines
Quoted 2 lines

Bjorn, with that confirmation and Reviewed-by from Matthias, could you please pick this patch?

I think we should be fixing the ones that *do* say it's moderated for non-subscribers, not the one that correctly didn't :)

Well, I am happy to send any PATCH v2. I guess we, you, David, Matthias and I, now just need to determine if the list is moderated or not.

I will then adjust MAINTAINERS to the final conclusion.

Lukas

#8 lore raw
Quoted 2 lines · Lukas Bulwahn

Well, I am happy to send any PATCH v2. I guess we, you, David, Matthias and I, now just need to determine if the list is moderated or not.

It really isn't.

 # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action
# legal values are:
#    0 = "Accept"
#    1 = "Hold"
#    2 = "Reject"
#    3 = "Discard"
generic_nonmember_action = 0
#9 lore raw
Quoted 6 lines · David Woodhouse
Quoted 2 lines · Lukas Bulwahn

Well, I am happy to send any PATCH v2. I guess we, you, David, Matthias and I, now just need to determine if the list is moderated or not.

It really isn't.

Quoted 8 lines
 # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action
# legal values are:
#    0 = "Accept"
#    1 = "Hold"
#    2 = "Reject"
#    3 = "Discard"
generic_nonmember_action = 0

David, I guess if you have access to the ground truth on lists.infradead.org, maybe you can dump the actual setting for all those lists?

$ grep "lists.infradead.org" MAINTAINERS | sort | uniq

L: [email protected]
L: [email protected]
L: [email protected]
L: [email protected]
L: [email protected]
L: [email protected]
L: [email protected]
L: [email protected]
L: [email protected] (moderated for non-subscribers)
L: [email protected] (moderated for non-subscribers)
L: [email protected] (moderated for non-subscribers)
L: [email protected]
L: [email protected] (moderated for non-subscribers)
L: [email protected]
L: [email protected]
L: [email protected] (subscribers-only)
L: [email protected] (moderated for non-subscribers)
L: [email protected]
L: [email protected]
L: [email protected] (moderated for non-subscribers)
L: [email protected]
L: [email protected]
L: [email protected] (moderated for non-subscribers)
L: [email protected]

They are all reporting different settings and linux-mediatek and linux-arm-kernel even inconsistently. The inconsistency and a poor attempt to resolve that is what started this discussion.

I can then send out the patch to adjust MAINTAINERS to your ground truth from the server.

Thanks for your support,

Lukas

#10 lore raw
Quoted 11 lines · Lukas Bulwahn
Quoted 7 lines
 # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action
# legal values are:
#    0 = "Accept"
#    1 = "Hold"
#    2 = "Reject"
#    3 = "Discard"
generic_nonmember_action = 0

David, I guess if you have access to the ground truth on lists.infradead.org, maybe you can dump the actual setting for all those lists?

ath10k:generic_nonmember_action = 0
ath11k:generic_nonmember_action = 0
b43-dev:generic_nonmember_action = 0
kexec:generic_nonmember_action = 0
libertas-dev:generic_nonmember_action = 0
linux-afs:generic_nonmember_action = 0
linux-amlogic:generic_nonmember_action = 0
linux-arm-kernel:generic_nonmember_action = 0
linux-geode:generic_nonmember_action = 1
linux-i3c:generic_nonmember_action = 1
linux-mediatek:generic_nonmember_action = 0
linux-mtd:generic_nonmember_action = 0
linux-nvme:generic_nonmember_action = 0
linux-parport:generic_nonmember_action = 1
linux-realtek-soc:generic_nonmember_action = 1
linux-riscv:generic_nonmember_action = 0
linux-rockchip:generic_nonmember_action = 0
linux-rpi-kernel:generic_nonmember_action = 0
linux-snps-arc:generic_nonmember_action = 0
linux-um:generic_nonmember_action = 0
linux-unisoc:generic_nonmember_action = 1
wcn36xx:generic_nonmember_action = 0

#11 lore raw
Quoted 27 lines · David Woodhouse
Quoted 11 lines · Lukas Bulwahn
Quoted 7 lines
 # /usr/lib/mailman/bin/config_list -o- linux-mediatek | grep -B5 ^generic_nonmember_action
# legal values are:
#    0 = "Accept"
#    1 = "Hold"
#    2 = "Reject"
#    3 = "Discard"
generic_nonmember_action = 0

David, I guess if you have access to the ground truth on lists.infradead.org, maybe you can dump the actual setting for all those lists?

ath10k:generic_nonmember_action = 0
ath11k:generic_nonmember_action = 0
b43-dev:generic_nonmember_action = 0
kexec:generic_nonmember_action = 0
libertas-dev:generic_nonmember_action = 0
linux-afs:generic_nonmember_action = 0
linux-amlogic:generic_nonmember_action = 0
linux-arm-kernel:generic_nonmember_action = 0
linux-geode:generic_nonmember_action = 1
linux-i3c:generic_nonmember_action = 1
linux-mediatek:generic_nonmember_action = 0
linux-mtd:generic_nonmember_action = 0
linux-nvme:generic_nonmember_action = 0
linux-parport:generic_nonmember_action = 1

Quoted 9 lines

linux-realtek-soc:generic_nonmember_action = 1
linux-riscv:generic_nonmember_action = 0
linux-rockchip:generic_nonmember_action = 0
linux-rpi-kernel:generic_nonmember_action = 0
linux-snps-arc:generic_nonmember_action = 0
linux-um:generic_nonmember_action = 0
linux-unisoc:generic_nonmember_action = 1
wcn36xx:generic_nonmember_action = 0

Thanks, I will provide a suitable patch for MAINTAINERS.

Lukas

#12 lore raw
In reply to David Woodhouse
Quoted 24 lines · David Woodhouse

AFAICT the linux-mediatek list isn't configured to automatically moderate messages from non-subscribers. Its generic_nonmember_action setting is 'Accept'. That is the default setting for lists on infradead.org and I strongly encourage list maintainers to leave it that way.

Lukas, I don't see your address in the allowlist either.

There are other reasons why some messages get might trapped for moderation — the message size, number of recipients, spam score, etc.

The mere fact that *some* messages are moderated does not mean that the list is "moderated for non-subscribers" in the sense that the MAINTAINERS file lists.

Quoted 2 lines

Bjorn, with that confirmation and Reviewed-by from Matthias, could you please pick this patch?

I think we should be fixing the ones that *do* say it's moderated for non-subscribers, not the one that correctly didn't :)

maintainer
#13 lore raw
In reply to David Woodhouse
Quoted 17 lines · David Woodhouse
Quoted 16 lines · Lukas Bulwahn
Quoted 11 lines
Quoted 7 lines

I am not subscribed to linux-mediatek. When I sent an email to the list, it showed up really seconds later in the lore.kernel.org of the linux-mediatek public-inbox repository. So, either it was delivered quickly as it is not moderated or my check with lore.kernel.org is wrong, e.g., mails show up in the lore.kernel.org archive, even they were not yet permitted on the actual list.

I'm the moderator and I get requests to moderate emails. I suppose I added you to the accepted list because of earlier emails you send.

Okay, I see. I did send some clean-up patch in the past, but I completely forgot that, but my mailbox did not forget. So, now it is clear to me why that mail showed up so quickly.

Quoted 7 lines
Quoted 1 line

Thanks for the explanation.

AFAICT the linux-mediatek list isn't configured to automatically moderate messages from non-subscribers. Its generic_nonmember_action setting is 'Accept'. That is the default setting for lists on infradead.org and I strongly encourage list maintainers to leave it that way.

Ok, thanks for clarification. I never bothered too much with all the configuration option of the list. :|

Quoted 2 lines

Lukas, I don't see your address in the allowlist either.

I tried to find that in the web interface, but wasn't able to find the list.

Regards,
Matthias

Quoted 14 lines

There are other reasons why some messages get might trapped for moderation — the message size, number of recipients, spam score, etc.

The mere fact that *some* messages are moderated does not mean that the list is "moderated for non-subscribers" in the sense that the MAINTAINERS file lists.

Quoted 2 lines

Bjorn, with that confirmation and Reviewed-by from Matthias, could you please pick this patch?

I think we should be fixing the ones that *do* say it's moderated for non-subscribers, not the one that correctly didn't :)