media: marvell-ccic: Pass __maybe_unused to the PM hooks
PATCH 1/1 media: marvell-ccic: Pass __maybe_unused to the PM hooks
Building for the riscv allmodconfig target leads to the following build warnings:
drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: 'mmpcam_resume' defined but not used [-Wunused-function] drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: 'mmpcam_suspend' defined but not used [-Wunused-function]
This happens because the generated .config does not select CONFIG_PM and CONFIG_PM_SLEEP options.
Mark the PM hooks as __maybe_unused to avoid such warnings.
--- drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/platform/marvell-ccic/mmp-driver.c +4 -4
@@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)* Suspend/resume support. */ -static int mmpcam_runtime_resume (struct device *dev) +static __maybe_unused int mmpcam_runtime_resume (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);struct mcam_camera *mcam = &cam->mcam;
@@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)return 0 ; } -static int mmpcam_runtime_suspend (struct device *dev) +static __maybe_unused int mmpcam_runtime_suspend (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);struct mcam_camera *mcam = &cam->mcam;
@@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)return 0 ; } -static int mmpcam_suspend (struct device *dev) +static __maybe_unused int mmpcam_suspend (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);
@@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)return 0 ; } -static int mmpcam_resume (struct device *dev) +static __maybe_unused int mmpcam_resume (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);
Signature · 1 line
2.17.1
Quoted 6 lines · Fabio Estevam
Building for the riscv allmodconfig target leads to the following build warnings:
drivers/media/platform/marvell-ccic/mmp-driver.c:347:12: warning: 'mmpcam_resume' defined but not used [-Wunused-function]drivers/media/platform/marvell-ccic/mmp-driver.c:338:12: warning: 'mmpcam_suspend' defined but not used [-Wunused-function]
Quoted 7 lines
This happens because the generated .config does not select
CONFIG_PMandCONFIG_PM_SLEEPoptions.Mark the PM hooks as
__maybe_unusedto avoid such warnings.Reported-by Olof's autobuilder <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Thanks for the patch.
Two equivalent patches have been sent to linux-media@ before though.
Cheers
Lubo
Quoted 47 lines
--- drivers/media/platform/marvell-ccic/mmp-driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/media/platform/marvell-ccic/mmp-driver.c +4
-4@@ -307,7 +307,7 @@ static int mmpcam_platform_remove(struct platform_device *pdev)* Suspend/resume support. */ -static int mmpcam_runtime_resume (struct device *dev) +static __maybe_unused int mmpcam_runtime_resume (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);struct mcam_camera *mcam = &cam->mcam;@@ -321,7 +321,7 @@ static int mmpcam_runtime_resume(struct device *dev)return 0 ; } -static int mmpcam_runtime_suspend (struct device *dev) +static __maybe_unused int mmpcam_runtime_suspend (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);struct mcam_camera *mcam = &cam->mcam;@@ -335,7 +335,7 @@ static int mmpcam_runtime_suspend(struct device *dev)return 0 ; } -static int mmpcam_suspend (struct device *dev) +static __maybe_unused int mmpcam_suspend (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);@@ -344,7 +344,7 @@ static int mmpcam_suspend(struct device *dev)return 0 ; } -static int mmpcam_resume (struct device *dev) +static __maybe_unused int mmpcam_resume (struct device *dev) {struct mmp_camera *cam =dev_get_drvdata (dev);Signature · 1 line
2.17.1