Skip to contentSkip to conversation

kbuild: Run syncconfig with -s

PATCH Alexey Dobriyan 2 participants 2 messages Sep 14, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines

BTW., there's another, rather spurious bug I recently triggered in kbuild.

Occasionally when I Ctrl-C a kernel build on a system with a lot of CPUs, the .o.cmd file gets corrupted:

Those are temporary files, truncated at page boundary.

	$ stat -c %s XXX.pata_sil680.mod.o.cmd
	12288

I tried to fix this by inserting shell 'trap' directive but it failed somewhere else.

	cmd_and_fixdep =                                                     \
        $(cmd);                                                              \
        scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
        rm -f $(depfile)
#1 lore raw
Quoted 11 lines · Alexey Dobriyan
Quoted 5 lines

BTW., there's another, rather spurious bug I recently triggered in kbuild.

Occasionally when I Ctrl-C a kernel build on a system with a lot of CPUs, the .o.cmd file gets corrupted:

Those are temporary files, truncated at page boundary.

        $ stat -c %s XXX.pata_sil680.mod.o.cmd
        12288
Quoted 7 lines

I tried to fix this by inserting shell 'trap' directive but it failed somewhere else.

        cmd_and_fixdep =                                                     \
        $(cmd);                                                              \
        scripts/basic/fixdep $(depfile) $@ '$(make-cmd)' > $(dot-target).cmd;\
        rm -f $(depfile)

No. It is *OK* to have broken .o.cmd files
as long as .o files are deleted on error or interruption (and this should be automatically handled by GNU Make).

.o.cmd is included only when the corresponding .o exists.

This is explained in the case [2] of commit
392885ee82d35d515ba2af7b72c5e357c3002113

Signature · 2 lines
Best Regards
Masahiro Yamada