Skip to contentSkip to conversation

iommu/arm: Add module parameter to set msi iova address

PATCH In review Vennila Megavannan 3 participants 5 messages Sep 14, 2020 – Sep 28, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 iommu/arm: Add module parameter to set msi iova address

From: Srinath Mannam <[email protected]>

Add provision to change default value of MSI IOVA base to platform's suitable IOVA using module parameter. The present hardcoded MSI IOVA base may not be the accessible IOVA ranges of platform.

If any platform has the limitaion to access default MSI IOVA, then it can be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.

---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++-
 drivers/iommu/arm/arm-smmu/arm-smmu.c       | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +4 -1
index c192544e874b..dfef0df66c19 100644
@@ -417,6 +417,9 @@ static bool disable_bypass = 1;
 module_param_named(disable_bypass, disable_bypass, bool, S_IRUGO);
 MODULE_PARM_DESC(disable_bypass,
 	"Disable bypass streams such that incoming transactions from devices that are not attached to an iommu domain will report an abort back to the device and will not be allowed to pass through the SMMU.");
+static unsigned long msi_iova_base = MSI_IOVA_BASE;
+module_param(msi_iova_base, ulong, S_IRUGO);
+MODULE_PARM_DESC(msi_iova_base, "set MSI IOVA base address if default (0x8000000) does not work for your platform.");
 
 enum pri_resp {
 	PRI_RESP_DENY = 0,
@@ -3102,7 +3105,7 @@ static void arm_smmu_get_resv_regions(struct device *dev,
 	struct iommu_resv_region *region;
 	int prot = IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_MMIO;
 
-	region = iommu_alloc_resv_region(MSI_IOVA_BASE, MSI_IOVA_LENGTH,
+	region = iommu_alloc_resv_region(msi_iova_base, MSI_IOVA_LENGTH,
 					 prot, IOMMU_RESV_SW_MSI);
 	if (!region)
 		return;
drivers/iommu/arm/arm-smmu/arm-smmu.c +4 -1
index 09c42af9f31e..9d46a2628dd5 100644
@@ -64,6 +64,9 @@ static bool disable_bypass =
 module_param(disable_bypass, bool, S_IRUGO);
 MODULE_PARM_DESC(disable_bypass,
 	"Disable bypass streams such that incoming transactions from devices that are not attached to an iommu domain will report an abort back to the device and will not be allowed to pass through the SMMU.");
+static unsigned long msi_iova_base = MSI_IOVA_BASE;
+module_param(msi_iova_base, ulong, S_IRUGO);
+MODULE_PARM_DESC(msi_iova_base, "set MSI IOVA base address if default (0x8000000) does not work for your platform.");
 
 struct arm_smmu_s2cr {
 	struct iommu_group		*group;
@@ -1603,7 +1606,7 @@ static void arm_smmu_get_resv_regions(struct device *dev,
 	struct iommu_resv_region *region;
 	int prot = IOMMU_WRITE | IOMMU_NOEXEC | IOMMU_MMIO;
 
-	region = iommu_alloc_resv_region(MSI_IOVA_BASE, MSI_IOVA_LENGTH,
+	region = iommu_alloc_resv_region(msi_iova_base, MSI_IOVA_LENGTH,
 					 prot, IOMMU_RESV_SW_MSI);
 	if (!region)
 		return;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 9 lines · Vennila Megavannan

From: Srinath Mannam <[email protected]>

Add provision to change default value of MSI IOVA base to platform's suitable IOVA using module parameter. The present hardcoded MSI IOVA base may not be the accessible IOVA ranges of platform.

If any platform has the limitaion to access default MSI IOVA, then it can be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.

Quoted 7 lines
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++-
 drivers/iommu/arm/arm-smmu/arm-smmu.c       | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

This feels pretty fragile. Wouldn't it be better to realise that there's a region conflict with iommu_dma_get_resv_regions() and move the MSI window accordingly at runtime?

Will

#2 lore raw

Sure, that's a great suggestion, I'll rework on the patch and post again.

Vennila

Quoted 22 lines · Will Deacon
Quoted 9 lines · Vennila Megavannan

From: Srinath Mannam <[email protected]>

Add provision to change default value of MSI IOVA base to platform's suitable IOVA using module parameter. The present hardcoded MSI IOVA base may not be the accessible IOVA ranges of platform.

If any platform has the limitaion to access default MSI IOVA, then it can be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.

Quoted 7 lines
---
  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++-
  drivers/iommu/arm/arm-smmu/arm-smmu.c       | 5 ++++-
  2 files changed, 8 insertions(+), 2 deletions(-)

This feels pretty fragile. Wouldn't it be better to realise that there's a region conflict with iommu_dma_get_resv_regions() and move the MSI window accordingly at runtime?

Will

#3 lore raw
In reply to Will Deacon

Hi Will,

Quoted 18 lines · Will Deacon
Quoted 9 lines · Vennila Megavannan

From: Srinath Mannam <[email protected]>

Add provision to change default value of MSI IOVA base to platform's suitable IOVA using module parameter. The present hardcoded MSI IOVA base may not be the accessible IOVA ranges of platform.

If any platform has the limitaion to access default MSI IOVA, then it can be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.

Quoted 7 lines
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++-
 drivers/iommu/arm/arm-smmu/arm-smmu.c       | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)
Quoted 3 lines

This feels pretty fragile. Wouldn't it be better to realise that there's a region conflict with iommu_dma_get_resv_regions() and move the MSI window accordingly at runtime?

Since cd2c9fcf5c66 ("iommu/dma: Move PCI window region reservation back into dma specific path"), the PCI host bridge windows are not exposed by iommu_dma_get_resv_regions() anymore. If I understood correctly, what is attempted here is to avoid the collision between such PCI host bridge window and the MSI IOVA range.

Thanks

Eric

Quoted 8 lines

Will

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#4 lore raw
Quoted 23 lines · Auger Eric
Quoted 18 lines · Will Deacon
Quoted 9 lines · Vennila Megavannan

From: Srinath Mannam <[email protected]>

Add provision to change default value of MSI IOVA base to platform's suitable IOVA using module parameter. The present hardcoded MSI IOVA base may not be the accessible IOVA ranges of platform.

If any platform has the limitaion to access default MSI IOVA, then it can be changed using "arm-smmu.msi_iova_base=0xa0000000" command line argument.

Quoted 7 lines
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 5 ++++-
 drivers/iommu/arm/arm-smmu/arm-smmu.c       | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)
Quoted 3 lines

This feels pretty fragile. Wouldn't it be better to realise that there's a region conflict with iommu_dma_get_resv_regions() and move the MSI window accordingly at runtime?

Quoted 5 lines

Since cd2c9fcf5c66 ("iommu/dma: Move PCI window region reservation back into dma specific path"), the PCI host bridge windows are not exposed by iommu_dma_get_resv_regions() anymore. If I understood correctly, what is attempted here is to avoid the collision between such PCI host bridge window and the MSI IOVA range.

Either way, I think the kernel should figure this out at runtime and not rely on a cmdline option to tell it where to place the region.

Will