clock_gettime04: relax the time diff in VM
PATCH 1/1 clock_gettime04: relax the time diff in VM
To balance that the test inside a VM can NOT get enough CPU time, which result in sporadically fails with the time comparing.
clock_gettime04.c:155: PASS: CLOCK_REALTIME: Difference between successive readings is reasonable clock_gettime04.c:155: PASS: CLOCK_REALTIME_COARSE: Difference between successive readings is reasonable clock_gettime04.c:148: FAIL: CLOCK_MONOTONIC: Difference between successive readings greater than 5 ms (2): 22 clock_gettime04.c:155: PASS: CLOCK_MONOTONIC_COARSE: Difference between successive readings is reasonable clock_gettime04.c:148: FAIL: CLOCK_MONOTONIC_RAW: Difference between successive readings greater than 5 ms (1): 22 clock_gettime04.c:148: FAIL: CLOCK_BOOTTIME: Difference between successive readings greater than 5 ms (1): 29
--- .../kernel/syscalls/clock_gettime/clock_gettime04.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/clock_gettime/clock_gettime04.c +8 -1
@@ -92,6 +92,7 @@ static void run(unsigned int i)struct test_variants *tv;int count =10000 , ret;unsigned int j; +int virt_env =tst_is_virt (VIRT_ANY ); do { for (j = 0; j < ARRAY_SIZE(variants); j++) {
@@ -143,11 +144,17 @@ static void run(unsigned int i) diff /=1000000 ; -if (diff >=5 ) { +if (!virt_env && diff >=5 ) {tst_res (TFAIL ,"%s: Difference between successive readings greater than 5 ms (%d): %lld" ,tst_clock_name (clks[i]), j, diff);return ; } + +if (virt_env && diff >=50 ) { +tst_res (TFAIL ,"%s: Difference between successive readings(in VM) greater than 50 ms (%d): %lld" , +tst_clock_name (clks[i]), j, diff); +return ; + } } }while (--count);
Signature · 1 line
2.21.3
PATCH 1/1 clock_gettime04: relax the time diff in VM
Hi!
Quoted 10 lines
To balance that the test inside a VM can NOT get enough CPU time, which result in sporadically fails with the time comparing.
clock_gettime04.c:155: PASS:
CLOCK_REALTIME: Difference between successive readings is reasonable clock_gettime04.c:155: PASS:CLOCK_REALTIME_COARSE: Difference between successive readings is reasonable clock_gettime04.c:148: FAIL:CLOCK_MONOTONIC: Difference between successive readings greater than 5 ms (2): 22 clock_gettime04.c:155: PASS:CLOCK_MONOTONIC_COARSE: Difference between successive readings is reasonable clock_gettime04.c:148: FAIL:CLOCK_MONOTONIC_RAW: Difference between successive readings greater than 5 ms (1): 22 clock_gettime04.c:148: FAIL:CLOCK_BOOTTIME: Difference between successive readings greater than 5 ms (1): 29
Quoted 2 lines
Signed-off-by Li Wang <[email protected]>Cc Viresh Kumar <[email protected]>
The idea is good, but I think that the implementation could be better.
Why can't we just call the tst_is_virt() in test setup and if we detect that we are running on virtual machine print a TINFO message that maximal expected difference has been multiplied by 10?
Quoted 41 lines
--- .../kernel/syscalls/clock_gettime/clock_gettime04.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)testcases/kernel/syscalls/clock_gettime/clock_gettime04.c +8
-1@@ -92,6 +92,7 @@ static void run(unsigned int i)struct test_variants *tv;int count =10000 , ret;unsigned int j; +int virt_env =tst_is_virt (VIRT_ANY ); do { for (j = 0; j < ARRAY_SIZE(variants); j++) {@@ -143,11 +144,17 @@ static void run(unsigned int i) diff /=1000000 ; -if (diff >=5 ) { +if (!virt_env && diff >=5 ) {tst_res (TFAIL ,"%s: Difference between successive readings greater than 5 ms (%d): %lld" ,tst_clock_name (clks[i]), j, diff);return ; } + +if (virt_env && diff >=50 ) { +tst_res (TFAIL ,"%s: Difference between successive readings(in VM) greater than 50 ms (%d): %lld" , +tst_clock_name (clks[i]), j, diff); +return ; + } } }while (--count);Signature · 5 lines
2.21.3 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 2 lines
Cyril Hrubis [email protected]
PATCH 1/1 clock_gettime04: relax the time diff in VM
Quoted 6 lines
od, but I think that the implementation could be better.
Why can't we just call the
tst_is_virt()in test setup and if we detect that we are running on virtual machine print a TINFO message that maximal expected difference has been multiplied by 10?
Sounds good.
Signature · 5 lines
Regards, Li Wang -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linux.it/pipermail/ltp/attachments/20200915/092fe1b8/attachment.htm>