selftests/bpf: Fix endianness issue in test_sockopt_sk
Subsystems (3)
PATCH v2 1/1 selftests/bpf: Fix endianness issue in test_sockopt_sk
getsetsockopt() calls getsockopt() with optlen == 1, but then checks the resulting int. It is ok on little endian, but not on big endian.
Fix by checking char instead.
---
v1->v2: Also pass a single byte to log_err.
tools/testing/selftests/bpf/prog_tests/sockopt_sk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/bpf/prog_tests/sockopt_sk.c +2 -2
@@ -45,9 +45,9 @@ static int getsetsockopt(void) goto err; } -if (*(int *)big_buf !=0x08 ) { +if (*big_buf !=0x08 ) {log_err ("Unexpected getsockopt(IP_TOS) optval 0x%x != 0x08" , - *(int *)big_buf); + (int )*big_buf); goto err; }
Signature · 1 line
2.25.4
Quoted 4 lines · Ilya Leoshkevich
getsetsockopt()callsgetsockopt()with optlen == 1, but then checks the resulting int. It is ok on little endian, but not on big endian.
Quoted 8 lines
Fix by checking char instead.
Fixes 8a027dc0 ("selftests/bpf: add sockopt test that exercises sk helpers")Signed-off-by Ilya Leoshkevich <[email protected]>---
v1->v2: Also pass a single byte tolog_err.
Quoted 22 lines
tools/testing/selftests/bpf/prog_tests/sockopt_sk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)tools/testing/selftests/bpf/prog_tests/sockopt_sk.c +2
-3@@ -45,9 +45,9 @@ static int getsetsockopt(void) goto err; } -if (*(int *)big_buf !=0x08 ) { +if (*big_buf !=0x08 ) {log_err ("Unexpected getsockopt(IP_TOS) optval 0x%x != 0x08" , - *(int *)big_buf); + (int )*big_buf); goto err; } --2.25.4
Quoted 8 lines · Andrii Nakryiko
Quoted 6 lines · Ilya Leoshkevich
getsetsockopt()callsgetsockopt()with optlen == 1, but then checks the resulting int. It is ok on little endian, but not on big endian.Fix by checking char instead.
Quoted 8 lines
Quoted 6 lines
Fixes 8a027dc0 ("selftests/bpf: add sockopt test that exercises sk helpers")Signed-off-by Ilya Leoshkevich <[email protected]>---
v1->v2: Also pass a single byte tolog_err.Acked-by Andrii Nakryiko <[email protected]>
Quoted 7 lines · Ilya Leoshkevich
getsetsockopt()callsgetsockopt()with optlen == 1, but then checks the resulting int. It is ok on little endian, but not on big endian.Fix by checking char instead.
Fixes 8a027dc0 ("selftests/bpf: add sockopt test that exercises sk helpers")Signed-off-by Ilya Leoshkevich <[email protected]>
Applied, thanks!