droid 4: add special handling required for voice calls and SIM
PATCH 1/3 droid 4: add special handling required for voice calls and SIM
Droid 4 modem is "special" (aka broken) so it seems to need a bit of error handling.
--- drivers/atmodem/sim.c | 1 + drivers/atmodem/vendor.h | 1 + drivers/atmodem/voicecall.c | 4 ++++ 3 files changed, 6 insertions(+)
drivers/atmodem/sim.c +1 -0
@@ -199,6 +199,7 @@ static void at_sim_read_info(struct ofono_sim *sim, int fileid,case OFONO_VENDOR_SPEEDUP :case OFONO_VENDOR_QUALCOMM_MSM :case OFONO_VENDOR_SIMCOM : +case OFONO_VENDOR_DROID :/* Maximum possible length */ len +=sprintf (buf + len,",0,0,255" );break ;
drivers/atmodem/vendor.h +1 -0
@@ -27,6 +27,7 @@ enum ofono_vendor {OFONO_VENDOR_MBM ,OFONO_VENDOR_GOBI ,OFONO_VENDOR_QUALCOMM_MSM , +OFONO_VENDOR_DROID ,OFONO_VENDOR_OPTION_HSO ,OFONO_VENDOR_ZTE , OFONO_VENDOR_HUAWEI,
drivers/atmodem/voicecall.c +4 -0
@@ -160,6 +160,10 @@ static void clcc_poll_cb(gboolean ok, GAtResult *result, gpointer user_data) poll_again = TRUE; goto poll_again; } +if (vd->vendor ==OFONO_VENDOR_DROID ) { + poll_again = TRUE; + goto poll_again; + }ofono_error ("We are polling CLCC and received an error" );ofono_error ("All bets are off for call management" );
Signature · 5 lines
2.11.0 -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi Pavel,
Quoted 8 lines · Pavel Machek
Droid 4 modem is "special" (aka broken) so it seems to need a bit of error handling.
--- drivers/atmodem/sim.c | 1 + drivers/atmodem/vendor.h | 1 + drivers/atmodem/voicecall.c | 4 ++++ 3 files changed, 6 insertions(+)
<snip>
drivers/atmodem/voicecall.c static void clcc_poll_cb(gboolean ok, GAtResult *result, gpointer user_data) · line 162
Quoted 4 lines
drivers/atmodem/voicecall.c +0
-0@@ -160,6 +160,10 @@ static void clcc_poll_cb(gboolean ok, GAtResult *result, gpointer user_data) poll_again = TRUE; goto poll_again; }
applied with an extra newline here to satisfy doc/coding-style.txt item M1.
drivers/atmodem/voicecall.c static void clcc_poll_cb(gboolean ok, GAtResult *result, gpointer user_data) · line 169
Quoted 8 lines
drivers/atmodem/voicecall.c +4
-0+if (vd->vendor ==OFONO_VENDOR_DROID ) { + poll_again = TRUE; + goto poll_again; + }ofono_error ("We are polling CLCC and received an error" );ofono_error ("All bets are off for call management" );
Regards,
-Denis