Skip to contentSkip to conversation

soc: qcom: apr: Fixup the error displayed on lookup failure

PATCH In review Sibi Sankar 2 participants 2 messages Sep 15, 2020 – Sep 16, 2020

Subsystems (4)
Stable branch Arm Qualcomm mailing list Arm Qualcomm support Qualcomm audio (ASoC) drivers
lore
Share & tools
lore

Sibi Sankar

author
#0 lore raw

PATCH 1/1 soc: qcom: apr: Fixup the error displayed on lookup failure

APR client incorrectly prints out "ret" variable on pdr_add_lookup failure, it should be printing the error value returned by the lookup instead.

Fixes 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality")
Signed-off-by Sibi Sankar <[email protected]>
---
 drivers/soc/qcom/apr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/apr.c +1 -1
index 1f35b097c6356..7abfc8c4fdc72 100644
@@ -328,7 +328,7 @@ static int of_apr_add_pd_lookups(struct device *dev)
 
 		pds = pdr_add_lookup(apr->pdr, service_name, service_path);
 		if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
-			dev_err(dev, "pdr add lookup failed: %d\n", ret);
+			dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
 			return PTR_ERR(pds);
 		}
 	}
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer
#1 lore raw
Quoted 26 lines · Sibi Sankar

APR client incorrectly prints out "ret" variable on pdr_add_lookup failure, it should be printing the error value returned by the lookup instead.

Fixes 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality")
Signed-off-by Sibi Sankar <[email protected]>
---
 drivers/soc/qcom/apr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/apr.c +1 -1
index 1f35b097c6356..7abfc8c4fdc72 100644
@@ -328,7 +328,7 @@ static int of_apr_add_pd_lookups(struct device *dev)
 
 		pds = pdr_add_lookup(apr->pdr, service_name, service_path);
 		if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
-			dev_err(dev, "pdr add lookup failed: %d\n", ret);
+			dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
 			return PTR_ERR(pds);
 		}
 	}
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>