memory: tegra: Correct num_tlb_lines for tegra210
Subsystems (2)
PATCH 1/1 memory: tegra: Correct num_tlb_lines for tegra210
According to Tegra210 TRM, the default value of TLB_ACTIVE_LINES field of register MC_SMMU_TLB_CONFIG_0 is 0x30. So num_tlb_lines should be 48 (0x30) rather than 32 (0x20).
--- drivers/memory/tegra/tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memory/tegra/tegra210.c +1 -1
@@ -1074,7 +1074,7 @@ static const struct tegra_smmu_soc tegra210_smmu_soc = { .num_groups = ARRAY_SIZE(tegra210_groups), .supports_round_robin_arbitration = true, .supports_request_limit = true, - .num_tlb_lines = 32, + .num_tlb_lines = 48, .num_asids = 128, };
Signature · 1 line
2.17.1
Quoted 8 lines · Nicolin Chen
According to Tegra210 TRM, the default value of
TLB_ACTIVE_LINESfield of registerMC_SMMU_TLB_CONFIG_0is0x30. Sonum_tlb_linesshould be 48 (0x30) rather than 32 (0x20).Signed-off-by Nicolin Chen <[email protected]>--- drivers/memory/tegra/tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Please send this as part of a series including:
https://patchwork.ozlabs.org/project/linux-tegra/patch/[email protected]/
Adding Joerg for visibility. From the Tegra side:
Quoted 16 lines
drivers/memory/tegra/tegra210.c +1
-1@@ -1074,7 +1074,7 @@ static const struct tegra_smmu_soc tegra210_smmu_soc = { .num_groups = ARRAY_SIZE(tegra210_groups), .supports_round_robin_arbitration = true, .supports_request_limit = true, - .num_tlb_lines = 32, + .num_tlb_lines = 48, .num_asids = 128, };Signature · 1 line
2.17.1
Krzysztof Kozlowski
maintainerQuoted 11 lines · Thierry Reding
Quoted 8 lines · Nicolin Chen
According to Tegra210 TRM, the default value of
TLB_ACTIVE_LINESfield of registerMC_SMMU_TLB_CONFIG_0is0x30. Sonum_tlb_linesshould be 48 (0x30) rather than 32 (0x20).Signed-off-by Nicolin Chen <[email protected]>--- drivers/memory/tegra/tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines
Please send this as part of a series including:
https://patchwork.ozlabs.org/project/linux-tegra/patch/[email protected]/Adding Joerg for visibility. From the Tegra side:
Acked-by Thierry Reding <[email protected]>
So basically applying this one alone breaks existing platforms and makes history non-bisectable...
Nicolin, the bisectability is important requirement so you must always mention the dependencies between patches.
Best regards,
Krzysztof
Quoted 18 lines · Krzysztof Kozlowski
Quoted 17 lines · Thierry Reding
Quoted 8 lines · Nicolin Chen
According to Tegra210 TRM, the default value of
TLB_ACTIVE_LINESfield of registerMC_SMMU_TLB_CONFIG_0is0x30. Sonum_tlb_linesshould be 48 (0x30) rather than 32 (0x20).Signed-off-by Nicolin Chen <[email protected]>--- drivers/memory/tegra/tegra210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Please send this as part of a series including:
https://patchwork.ozlabs.org/project/linux-tegra/patch/[email protected]/Adding Joerg for visibility. From the Tegra side:
Quoted 7 lines
Quoted 1 line
Acked-by Thierry Reding <[email protected]>So basically applying this one alone breaks existing platforms and makes history non-bisectable...
Nicolin, the bisectability is important requirement so you must always mention the dependencies between patches.
Sorry. Will be careful next time.
And I am resending both in a series.
Thanks
Nic