Skip to contentSkip to conversation

vfio: add a singleton check for vfio_group_pin_pages

PATCH New Yan Zhao 1 participant 1 message Sep 16, 2020

Subsystems (2)
lore
Share & tools
lore

Yan Zhao

author
#0 lore raw

PATCH v2 1/1 vfio: add a singleton check for vfio_group_pin_pages

Page pinning is used both to translate and pin device mappings for DMA purpose, as well as to indicate to the IOMMU backend to limit the dirty page scope to those pages that have been pinned, in the case of an IOMMU backed device.
To support this, the vfio_pin_pages() interface limits itself to only singleton groups such that the IOMMU backend can consider dirty page scope only at the group level. Implement the same requirement for the vfio_group_pin_pages() interface.

Fixes 95fc87b44104 ("vfio: Selective dirty page tracking if IOMMU backed device pins pages")

---
v2:
1. updated the commit message to declare the issue clearly. (Alex)
2. updated the format of the Fixes: line.

---
 drivers/vfio/vfio.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/vfio/vfio.c +3 -0
index 5e6e0511b5aa..2f0fa272ebf2 100644
@@ -2053,6 +2053,9 @@ int vfio_group_pin_pages(struct vfio_group *group,
 	if (!group || !user_iova_pfn || !phys_pfn || !npage)
 		return -EINVAL;
 
+	if (group->dev_counter > 1)
+		return  -EINVAL;
+
 	if (npage > VFIO_PIN_PAGES_MAX_ENTRIES)
 		return -E2BIG;
 
Signature · 1 line
2.17.1