KVM: SVM: use __GFP_ZERO instead of clear_page()
PATCH 1/1 KVM: SVM: use __GFP_ZERO instead of clear_page()
From: Haiwei Li <[email protected]>
Use __GFP_ZERO while alloc_page().
Signed-off-by Haiwei Li <[email protected]>
--- arch/x86/kvm/svm/avic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
arch/x86/kvm/svm/avic.c +2 -4
@@ -153,20 +153,18 @@ int avic_vm_init(struct kvm *kvm)return 0 ;/* Allocating physical APIC ID table (4KB) */ - p_page =alloc_page (GFP_KERNEL_ACCOUNT ); + p_page =alloc_page (GFP_KERNEL_ACCOUNT | __GFP_ZERO);if (!p_page) goto free_avic; kvm_svm->avic_physical_id_table_page = p_page; -clear_page (page_address (p_page));/* Allocating logical APIC ID table (4KB) */ - l_page =alloc_page (GFP_KERNEL_ACCOUNT ); + l_page =alloc_page (GFP_KERNEL_ACCOUNT | __GFP_ZERO);if (!l_page) goto free_avic; kvm_svm->avic_logical_id_table_page = l_page; -clear_page (page_address (l_page));spin_lock_irqsave (&svm_vm_data_hash_lock, flags); again:
Signature · 1 line
2.18.4
Quoted 26 lines · On Wed, 2020-09-16 at 16:36 +0800, [email protected] wrote:
From: Haiwei Li <[email protected]>
Use
__GFP_ZEROwhilealloc_page().Signed-off-by Haiwei Li <[email protected]>--- arch/x86/kvm/svm/avic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)arch/x86/kvm/svm/avic.c +1
-2@@ -153,20 +153,18 @@ int avic_vm_init(struct kvm *kvm)return 0 ;/* Allocating physical APIC ID table (4KB) */ - p_page =alloc_page (GFP_KERNEL_ACCOUNT ); + p_page =alloc_page (GFP_KERNEL_ACCOUNT | __GFP_ZERO);if (!p_page) goto free_avic; kvm_svm->avic_physical_id_table_page = p_page; -clear_page (page_address (p_page));/* Allocating logical APIC ID table (4KB) */
arch/x86/kvm/svm/avic.c int avic_vm_init(struct kvm *kvm) · line 170
Quoted 10 lines
arch/x86/kvm/svm/avic.c +1
-2- l_page =alloc_page (GFP_KERNEL_ACCOUNT ); + l_page =alloc_page (GFP_KERNEL_ACCOUNT | __GFP_ZERO);if (!l_page) goto free_avic; kvm_svm->avic_logical_id_table_page = l_page; -clear_page (page_address (l_page));spin_lock_irqsave (&svm_vm_data_hash_lock, flags); again:
Reviewed-by Maxim Levitsky <[email protected]>
Best regards,
Maxim Levitsky
Quoted 27 lines · On 16/09/20 10:36, [email protected] wrote:
From: Haiwei Li <[email protected]>
Use
__GFP_ZEROwhilealloc_page().Signed-off-by Haiwei Li <[email protected]>--- arch/x86/kvm/svm/avic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)arch/x86/kvm/svm/avic.c +1
-2@@ -153,20 +153,18 @@ int avic_vm_init(struct kvm *kvm)return 0 ;/* Allocating physical APIC ID table (4KB) */ - p_page =alloc_page (GFP_KERNEL_ACCOUNT ); + p_page =alloc_page (GFP_KERNEL_ACCOUNT | __GFP_ZERO);if (!p_page) goto free_avic; kvm_svm->avic_physical_id_table_page = p_page; -clear_page (page_address (p_page));/* Allocating logical APIC ID table (4KB) */
arch/x86/kvm/svm/avic.c int avic_vm_init(struct kvm *kvm) · line 170
Quoted 10 lines
arch/x86/kvm/svm/avic.c +1
-2- l_page =alloc_page (GFP_KERNEL_ACCOUNT ); + l_page =alloc_page (GFP_KERNEL_ACCOUNT | __GFP_ZERO);if (!l_page) goto free_avic; kvm_svm->avic_logical_id_table_page = l_page; -clear_page (page_address (l_page));spin_lock_irqsave (&svm_vm_data_hash_lock, flags); again:
Queued, thanks.
Paolo