Skip to contentSkip to conversation

i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()

PATCH New Dan Carpenter 3 participants 3 messages Sep 16, 2020 – Oct 13, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()

The "failure" variable is used without being initialized. It should be set to false.

Fixes 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
---
 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_xsk.c +1 -1
index 6acede0acdca..567fd67e900e 100644
@@ -281,8 +281,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
 	unsigned int total_rx_bytes = 0, total_rx_packets = 0;
 	u16 cleaned_count = I40E_DESC_UNUSED(rx_ring);
 	unsigned int xdp_res, xdp_xmit = 0;
+	bool failure = false;
 	struct sk_buff *skb;
-	bool failure;
 
 	while (likely(total_rx_packets < (unsigned int)budget)) {
 		union i40e_rx_desc *rx_desc;
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()

Quoted 5 lines · Dan Carpenter

The "failure" variable is used without being initialized. It should be set to false.

Fixes 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")

Thanks Dan!

Quoted 19 lines
---
  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_xsk.c +1 -1
index 6acede0acdca..567fd67e900e 100644
@@ -281,8 +281,8 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
  	unsigned int total_rx_bytes = 0, total_rx_packets = 0;
  	u16 cleaned_count = I40E_DESC_UNUSED(rx_ring);
  	unsigned int xdp_res, xdp_xmit = 0;
+	bool failure = false;
  	struct sk_buff *skb;
-	bool failure;
 
  	while (likely(total_rx_packets < (unsigned int)budget)) {
  		union i40e_rx_desc *rx_desc;
#2 lore raw

PATCH 1/1 i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()

In reply to Dan Carpenter

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Dan Carpenter
Sent: Wednesday, September 16, 2020 8:02 PM
To: Kirsher, Jeffrey T <[email protected]>
Cc: intel-wired-lan at lists.osuosl.org; kernel-janitors at vger.kernel.org; Topel, Bjorn <[email protected]>
Subject: [Intel-wired-lan] [PATCH] i40e, xsk: uninitialized variable in i40e_clean_rx_irq_zc()

The "failure" variable is used without being initialized. It should be set to false.

Fixes 8cbf74149903 ("i40e, xsk: move buffer allocation out of the Rx processing loop")
Signed-off-by Dan Carpenter <dan.carpenter at oracle.com<mailto:[email protected]>>

---

drivers/net/ethernet/intel/i40e/i40e_xsk.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20201013/ee128d11/attachment.html>