SWDEV-247673 - stop data_exchange work thread before reset
Subsystems (2)
PATCH 3/3 SWDEV-247673 - stop data_exchange work thread before reset
From: Tiecheng Zhou <[email protected]>
In FLR routine, init_data_exchange is called at reset_sriov while fini_data_exchange is not. This will duplicating work thread.
So call fini_data_exchange before reset for SRIOV
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -0
@@ -4080,6 +4080,11 @@ static int amdgpu_device_pre_asic_reset(struct amdgpu_device *adev,amdgpu_debugfs_wait_dump (adev); +if (amdgpu_sriov_vf (adev)) { +/* stop the data exchange thread */ +amdgpu_virt_fini_data_exchange (adev); + } +/* block all schedulers and reset given job's ring */ for (i =0 ; i <AMDGPU_MAX_RINGS ; ++i) {struct amdgpu_ring *ring = adev->rings[i];
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 7 lines · Bokun Zhang
From: Tiecheng Zhou <[email protected]>
In FLR routine,
init_data_exchangeis called atreset_sriovwhilefini_data_exchangeis not. This will duplicating work thread.
Quoted 5 lines
So call
fini_data_exchangebefore reset for SRIOVChange-Id I974c6a3c5de86736eebefc386c03fe0e18e1fae3Signed-off-by Tiecheng Zhou <[email protected]>Signed-off-by Bokun Zhang <[email protected]>
Please drop the SWDEV reference from the subject and prefix the patch with drm/amdgpu:
Alex
Quoted 23 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5
-1@@ -4080,6 +4080,11 @@ static int amdgpu_device_pre_asic_reset(struct amdgpu_device *adev,amdgpu_debugfs_wait_dump (adev); +if (amdgpu_sriov_vf (adev)) { +/* stop the data exchange thread */ +amdgpu_virt_fini_data_exchange (adev); + } +/* block all schedulers and reset given job's ring */ for (i =0 ; i <AMDGPU_MAX_RINGS ; ++i) {struct amdgpu_ring *ring = adev->rings[i]; --2.20.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx