drm/amd/pm: Skip smu_post_init in SRIOV
Subsystems (3)
PATCH 1/1 drm/amd/pm: Skip smu_post_init in SRIOV
smu_post_init needs to enable SMU feature, while this require virtualization off. Skip it since this feature is not used in SRIOV.
--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +6 -4
@@ -469,10 +469,12 @@ static int smu_late_init(void *handle)if (!smu->pm_enabled)return 0 ; - ret =smu_post_init (smu); -if (ret) { -dev_err (adev->dev,"Failed to post smu init!\n" ); -return ret; +if (!amdgpu_sriov_vf (adev)) { + ret =smu_post_init (smu); +if (ret) { +dev_err (adev->dev,"Failed to post smu init!\n" ); +return ret; + } } ret =smu_set_default_od_settings (smu);
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
Why not moving the check in smu_post_init, and return 0 at the first early stage if it's SRIOV case?
Regards,
Guchun
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Jingwen Chen
Sent: Thursday, September 17, 2020 4:11 PM
To: [email protected]
Cc: Chen, JingWen <[email protected]>
Subject: [PATCH] drm/amd/pm: Skip smu_post_init in SRIOV
smu_post_init needs to enable SMU feature, while this require virtualization off. Skip it since this feature is not used in SRIOV.
--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +6 -4
@@ -469,10 +469,12 @@ static int smu_late_init(void *handle)if (!smu->pm_enabled)return 0 ; - ret =smu_post_init (smu); -if (ret) { -dev_err (adev->dev,"Failed to post smu init!\n" ); -return ret; +if (!amdgpu_sriov_vf (adev)) { + ret =smu_post_init (smu); +if (ret) { +dev_err (adev->dev,"Failed to post smu init!\n" ); +return ret; + } } ret =smu_set_default_od_settings (smu);
--
2.25.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cguchun.chen%40amd.com%7C7bc132d80cd34c4e7b8f08d85ae1fcc5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637359274256715319&sdata=x%2Bc0jbDbTv8PR7qj4GCbYgxorKyFg2K%2BJYgcrs4iftE%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
Done in v2
Best Regards,
JingWen Chen
Quoted 57 lines
-----Original Message-----
From: Chen, Guchun <[email protected]>
Sent: Thursday, September 17, 2020 4:21 PM
To: Chen, JingWen <[email protected]>; amd- [email protected]
Cc: Chen, JingWen <[email protected]>
Subject: RE: [PATCH] drm/amd/pm: Skipsmu_post_initin SRIOV[AMD Public Use]
Why not moving the check in
smu_post_init, and return 0 at the first early stage if it's SRIOV case?Regards,
Guchun-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Jingwen Chen
Sent: Thursday, September 17, 2020 4:11 PM
To: [email protected]
Cc: Chen, JingWen <[email protected]>
Subject: [PATCH] drm/amd/pm: Skipsmu_post_initin SRIOV
smu_post_initneeds to enable SMU feature, while this require virtualization off. Skip it since this feature is not used in SRIOV.Signed-off-by Jingwen Chen <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c +6
-5@@ -469,10 +469,12 @@ static int smu_late_init(void *handle)if (!smu->pm_enabled)return 0 ; - ret =smu_post_init (smu); -if (ret) { -dev_err (adev->dev,"Failed to post smu init!\n" ); -return ret; +if (!amdgpu_sriov_vf (adev)) { + ret =smu_post_init (smu); +if (ret) { +dev_err (adev->dev,"Failed to post smu init!\n" ); +return ret; + } } ret =smu_set_default_od_settings (smu); --2.25.1
Quoted 9 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
freedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&data=02%7C01%7Cguchun.chen%40amd.com%7C7bc132d80cd34c4 e7b8f08d85ae1fcc5%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C 637359274256715319&sdata=x%2Bc0jbDbTv8PR7qj4GCbYgxorKyFg2K%2 BJYgcrs4iftE%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx