Skip to contentSkip to conversation

bitbake: hashserv: Fix localhost sometimes resolved to a wrong IP

PATCH New [email protected] 1 participant 1 message Sep 17, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake: hashserv: Fix localhost sometimes resolved to a wrong IP

From: Anatol Belski <[email protected]>

From: Anatol Belski <[email protected]>

Using localhost for direct builds on host is fine. A case with a misbehavior has been sighted on a Docker build. Even when the host supports IPv6, but Docker is not configured correspondingly - some versions of the asyncio Python module seem to misbehave and try to use IPv6 where it's not supported in the container. This happens at least on some Ubuntu 18.04 based containers, resolving the IP explicitly appears to be the fix.

---
 bitbake/lib/hashserv/tests.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
bitbake/lib/hashserv/tests.py +6 -1
index b34c436876..4566f24738 100644
@@ -14,6 +14,7 @@ import sys
 import tempfile
 import threading
 import unittest
+import socket
 
 
 class TestHashEquivalenceServer(object):
@@ -163,4 +164,8 @@ class TestHashEquivalenceUnixServer(TestHashEquivalenceServer, unittest.TestCase
 
 class TestHashEquivalenceTCPServer(TestHashEquivalenceServer, unittest.TestCase):
     def get_server_addr(self):
-        return "localhost:0"
+        # Some hosts cause asyncio module to misbehave, when IPv6 is not enabled.
+        # If IPv6 is enabled, it should be safe to use localhost directly, in general
+        # case it is more reliable to resolve the IP address explicitly.
+        return socket.gethostbyname("localhost") + ":0"
+            
Signature · 1 line
2.17.1