Skip to contentSkip to conversation

arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller

PATCH In review Krzysztof Kozlowski 2 participants 5 messages Sep 17, 2020 – Oct 3, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: apm: drop unused reg-io-width from DW APB GPIO controller

The Synopsys DesignWare APB GPIO controller driver does not parse reg-io-width and dtschema does not allow it so drop it to fix dtschema warnings like:

arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:

    'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'

---

Changes since v1:
1. New patch

---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 1 -
 2 files changed, 2 deletions(-)
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi +0 -1
index 3feb1881bbc2..2da5b8a0cd35 100644
@@ -709,7 +709,6 @@
 		dwgpio: gpio@1c024000 {
 			compatible = "snps,dw-apb-gpio";
 			reg = <0x0 0x1c024000 0x0 0x1000>;
-			reg-io-width = <4>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 
arch/arm64/boot/dts/apm/apm-storm.dtsi +0 -1
index 8c802d87e751..560b2a6f2082 100644
@@ -825,7 +825,6 @@
 		dwgpio: gpio@1c024000 {
 			compatible = "snps,dw-apb-gpio";
 			reg = <0x0 0x1c024000 0x0 0x1000>;
-			reg-io-width = <4>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

PATCH 2/2 arm64: dts: apm: add required gpio-cells to DW APB GPIO controller port

The Synopsys DesignWare APB GPIO controller port must have gpio-cells property, as pointed by dtschema:

arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000: gpio-controller@0: '#gpio-cells' is a required property

---

Changes since v1:
1. New patch

---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 +
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 1 +
 2 files changed, 2 insertions(+)
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi +1 -0
index 2da5b8a0cd35..a83c82c50e29 100644
@@ -715,6 +715,7 @@
 			porta: gpio-controller@0 {
 				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
+				#gpio-cells = <2>;
 				snps,nr-gpios = <32>;
 				reg = <0>;
 			};
arch/arm64/boot/dts/apm/apm-storm.dtsi +1 -0
index 560b2a6f2082..0f37e77f5459 100644
@@ -831,6 +831,7 @@
 			porta: gpio-controller@0 {
 				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
+				#gpio-cells = <2>;
 				snps,nr-gpios = <32>;
 				reg = <0>;
 			};
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw
In reply to Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski

The Synopsys DesignWare APB GPIO controller driver does not parse reg-io-width and dtschema does not allow it so drop it to fix dtschema warnings like:

arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:

    'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'

---

Dear Arnd and Olof,

There is no response from APM maintainer, so maybe you could apply these two patches directly? Optionally I could take it and send to you via pull-request.

Best regards,
Krzysztof

Quoted 8 lines

Changes since v1:
1. New patch

---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 -
 arch/arm64/boot/dts/apm/apm-storm.dtsi     | 1 -
 2 files changed, 2 deletions(-)
#3 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 9 lines · Krzysztof Kozlowski

The Synopsys DesignWare APB GPIO controller driver does not parse reg-io-width and dtschema does not allow it so drop it to fix dtschema warnings like:

arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:

    'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
Quoted 7 lines
Quoted 1 line

---

Dear Arnd and Olof,

There is no response from APM maintainer, so maybe you could apply these two patches directly? Optionally I could take it and send to you via pull-request.

Sure, applying.

-Olof

#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski
Quoted 9 lines · Krzysztof Kozlowski

The Synopsys DesignWare APB GPIO controller driver does not parse reg-io-width and dtschema does not allow it so drop it to fix dtschema warnings like:

arch/arm64/boot/dts/apm/apm-mustang.dt.yaml: gpio@1c024000:

    'reg-io-width' does not match any of the regexes: '^gpio-(port|controller)@[0-9a-f]+$', 'pinctrl-[0-9]+'
Quoted 7 lines
Quoted 1 line

---

Dear Arnd and Olof,

There is no response from APM maintainer, so maybe you could apply these two patches directly? Optionally I could take it and send to you via pull-request.

I've already applied them, so no need. Thanks for following up though, seems like the patchwork email service hasn't been working on all patches.

-Olof