net: remove comments on struct rtnl_link_stats
Subsystems (2)
Jakub Kicinski
maintainerPATCH 1/1 net: remove comments on struct rtnl_link_stats
We removed the misleading comments from struct rtnl_link_stats64 when we added proper kdoc. struct rtnl_link_stats has the same inline comments, so remove them, too.
Signed-off-by Jakub Kicinski <[email protected]>
--- include/uapi/linux/if_link.h | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-)
include/uapi/linux/if_link.h +15 -16
@@ -7,24 +7,23 @@/* This struct should be in sync with struct rtnl_link_stats64 */ struct rtnl_link_stats { -__u32 rx_packets;/* total packets received */ -__u32 tx_packets;/* total packets transmitted */ -__u32 rx_bytes;/* total bytes received */ -__u32 tx_bytes;/* total bytes transmitted */ -__u32 rx_errors;/* bad packets received */ -__u32 tx_errors;/* packet transmit problems */ -__u32 rx_dropped;/* no space in linux buffers */ -__u32 tx_dropped;/* no space available in linux */ -__u32 multicast;/* multicast packets received */ +__u32 rx_packets; +__u32 tx_packets; +__u32 rx_bytes; +__u32 tx_bytes; +__u32 rx_errors; +__u32 tx_errors; +__u32 rx_dropped; +__u32 tx_dropped; +__u32 multicast;__u32 collisions; -/* detailed rx_errors: */ __u32 rx_length_errors; -__u32 rx_over_errors;/* receiver ring buff overflow */ -__u32 rx_crc_errors;/* recved pkt with crc error */ -__u32 rx_frame_errors;/* recv'd frame alignment error */ -__u32 rx_fifo_errors;/* recv'r fifo overrun */ -__u32 rx_missed_errors;/* receiver missed packet */ +__u32 rx_over_errors; +__u32 rx_crc_errors; +__u32 rx_frame_errors; +__u32 rx_fifo_errors; +__u32 rx_missed_errors;/* detailed tx_errors */ __u32 tx_aborted_errors;
@@ -37,7 +36,7 @@ struct rtnl_link_stats {__u32 rx_compressed;__u32 tx_compressed; -__u32 rx_nohandler;/* dropped, no handler found */ +__u32 rx_nohandler; };/**
Signature · 1 line
2.26.2
Quoted 5 lines · Jakub Kicinski
We removed the misleading comments from struct
rtnl_link_stats64when we added proper kdoc. structrtnl_link_statshas the same inline comments, so remove them, too.Signed-off-by Jakub Kicinski <[email protected]>
Thanks Jakub!
Reviewed-by Saeed Mahameed <[email protected]>
From: Jakub Kicinski <[email protected]>
Date: Thu, 17 Sep 2020 10:51:32 -0700
Quoted 5 lines
We removed the misleading comments from struct
rtnl_link_stats64when we added proper kdoc. structrtnl_link_statshas the same inline comments, so remove them, too.Signed-off-by Jakub Kicinski <[email protected]>
Applied, thank you.