nfp: use correct define to return NONE fec
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 nfp: use correct define to return NONE fec
struct ethtool_fecparam carries bitmasks not bit numbers. We want to return 1 (NONE), not 0.
Fixes 0d0870938337 ("nfp: implement ethtool FEC mode settings")
Signed-off-by Jakub Kicinski <[email protected]>
--- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c +2 -2
@@ -829,8 +829,8 @@ nfp_port_get_fecparam(struct net_device *netdev,struct nfp_eth_table_port *eth_port;struct nfp_port *port; - param->active_fec =ETHTOOL_FEC_NONE_BIT ; - param->fec =ETHTOOL_FEC_NONE_BIT ; + param->active_fec =ETHTOOL_FEC_NONE ; + param->fec =ETHTOOL_FEC_NONE ; port =nfp_port_from_netdev (netdev); eth_port =nfp_port_get_eth_port (port);
Signature · 1 line
2.26.2
Quoted 14 lines · Jakub Kicinski
struct
ethtool_fecparamcarries bitmasks not bit numbers. We want to return 1 (NONE), not 0.Fixes 0d0870938337 ("nfp: implement ethtool FEC mode settings")Signed-off-by Jakub Kicinski <[email protected]>--- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c +0
-0
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c nfp_port_get_fecparam(struct net_device *netdev, · line 836
Quoted 10 lines
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c +2
-2@@ -829,8 +829,8 @@ nfp_port_get_fecparam(struct net_device *netdev,struct nfp_eth_table_port *eth_port;struct nfp_port *port; - param->active_fec =ETHTOOL_FEC_NONE_BIT ; - param->fec =ETHTOOL_FEC_NONE_BIT ; + param->active_fec =ETHTOOL_FEC_NONE ; + param->fec =ETHTOOL_FEC_NONE ; port =nfp_port_from_netdev (netdev); eth_port =nfp_port_get_eth_port (port);
Reviewed-by Simon Horman <[email protected]>
Quoted 5 lines · Jakub Kicinski
struct
ethtool_fecparamcarries bitmasks not bit numbers. We want to return 1 (NONE), not 0.Fixes 0d0870938337 ("nfp: implement ethtool FEC mode settings")Signed-off-by Jakub Kicinski <[email protected]>
Good catch!
Reviewed-by Jesse Brandeburg <[email protected]>
David Miller
maintainerFrom: Jakub Kicinski <[email protected]>
Date: Thu, 17 Sep 2020 10:52:57 -0700
Quoted 5 lines
struct
ethtool_fecparamcarries bitmasks not bit numbers. We want to return 1 (NONE), not 0.Fixes 0d0870938337 ("nfp: implement ethtool FEC mode settings")Signed-off-by Jakub Kicinski <[email protected]>
Applied and queued up for -stable, thanks.