arm64: dts: zynqmp-zcu100-revC: correct interrupt flags
Subsystems (2)
PATCH v2 1/1 arm64: dts: zynqmp-zcu100-revC: correct interrupt flags
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
---
Not tested on HW.
Changes since v1:
1. Correct title
--- arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts +1 -1
@@ -186,7 +186,7 @@ compatible = "ti,tps65086"; reg = <0x5e>; interrupt-parent = <&gpio>; - interrupts = <77 GPIO_ACTIVE_LOW>; + interrupts = <77 IRQ_TYPE_LEVEL_LOW>; #gpio-cells = <2>; gpio-controller; };
Signature · 1 line
2.17.1
Michal Simek
AppliedQuoted 28 lines · Krzysztof Kozlowski
GPIO_ACTIVE_xflags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning:
1.GPIO_ACTIVE_HIGH= 0 =IRQ_TYPE_NONE
2.GPIO_ACTIVE_LOW= 1 =IRQ_TYPE_EDGE_RISINGCorrect the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "
ACTIVE_xxx", this is:
ACTIVE_LOW=>IRQ_TYPE_LEVEL_LOWSigned-off-by Krzysztof Kozlowski <[email protected]>---
Not tested on HW.
Changes since v1:
1. Correct title--- arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts +0
-0
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts line 192
Quoted 8 lines
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts +1
-1@@ -186,7 +186,7 @@ compatible = "ti,tps65086"; reg = <0x5e>; interrupt-parent = <&gpio>; - interrupts = <77 GPIO_ACTIVE_LOW>; + interrupts = <77 IRQ_TYPE_LEVEL_LOW>; #gpio-cells = <2>; gpio-controller; };
Applied to https://github.com/Xilinx/linux-xlnx/tree/zynqmp/dt.
M