Skip to contentSkip to conversation

ionic: dynamic interrupt moderation

bug report Dan Carpenter 1 participant 1 message Sep 18, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Shannon Nelson,

This is a semi-automatic email about new static checker warnings.

The patch 04a834592bf5: "ionic: dynamic interrupt moderation" from Sep 15, 2020, leads to the following Smatch complaint:

    drivers/net/ethernet/pensando/ionic/ionic_lif.c:855 ionic_adminq_napi()
    error: we previously assumed 'lif->adminqcq' could be null (see line 848)

drivers/net/ethernet/pensando/ionic/ionic_lif.c
847
848 if (lif->adminqcq && lif->adminqcq->flags & IONIC_QCQ_F_INITED)

                    ^^^^^^^^^^^^^

Existing code checks for NULL

849 a_work = ionic_cq_service(&lif->adminqcq->cq, budget,
850 ionic_adminq_service, NULL, NULL);
851
852 work_done = max(n_work, a_work);
853 if (work_done < budget && napi_complete_done(napi, work_done)) {
854 flags |= IONIC_INTR_CRED_UNMASK;

   855			lif->adminqcq->cq.bound_intr->rearm_count++;
                        ^^^^^^^^^^^^^^^

The patch adds a new unchecked dereference

856 }
857

regards,
dan carpenter