Skip to contentSkip to conversation

dt-bindings: tas2770: Fix I2C addresses for the TAS2770

PATCH In review Dan Murphy 2 participants 3 messages Sep 18, 2020 – Sep 22, 2020

Subsystems (2)
lore
Share & tools
lore

Dan Murphy

author
#0 lore raw

PATCH 1/1 dt-bindings: tas2770: Fix I2C addresses for the TAS2770

The I2C addresses listed in the yaml are not correct. The addresses can range from 0x41 through 0x48 based on register configurations. Fix the example and the description.

Fixes 4b7151dadfd4 ("dt-bindings: ASoC: Add tas2770 smart PA dt bindings")
---
 Documentation/devicetree/bindings/sound/tas2770.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/sound/tas2770.yaml +3 -3
index 33a90f829c80..bb26d081c9fa 100644
@@ -24,7 +24,7 @@ properties:
   reg:
     maxItems: 1
     description: |
-       I2C address of the device can be one of these 0x4c, 0x4d, 0x4e or 0x4f
+       I2C address of the device can be between 0x41 to 0x48.
 
   reset-gpio:
     description: GPIO used to reset the device.
@@ -62,9 +62,9 @@ examples:
    i2c0 {
      #address-cells = <1>;
      #size-cells = <0>;
-     codec: codec@4c {
+     codec: codec@41 {
        compatible = "ti,tas2770";
-       reg = <0x4c>;
+       reg = <0x41>;
        #sound-dai-cells = <1>;
        interrupt-parent = <&gpio1>;
        interrupts = <14>;
Signature · 1 line
2.28.0
author
#1 lore raw

All

Quoted 3 lines · Dan Murphy

The I2C addresses listed in the yaml are not correct. The addresses can range from 0x41 through 0x48 based on register configurations. Fix the example and the description.

Please ignore this patch I added this patch intp a different patch series because there were just that many fixes.

https://lore.kernel.org/patchwork/project/lkml/list/?series=463738

Dan

maintainer
#2 lore raw
In reply to Dan Murphy
Quoted 3 lines · Dan Murphy

The I2C addresses listed in the yaml are not correct. The addresses can range from 0x41 through 0x48 based on register configurations. Fix the example and the description.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] dt-bindings: tas2770: Fix I2C addresses for the TAS2770

      commit: b23d9eb897a1209e4d741fd69e5490f1b5b9e7cf

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark