Skip to contentSkip to conversation

Joint project with Git for outreachy

DISCUSSION Jonathan Nieder 7 participants 9 messages Sep 18, 2020 – Sep 21, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hi wiresharkers,

Outreachy <https://www.outreachy.org/> is a program similar to the Google Summer of Code, providing internships to work on open source projects.

Emily (cc-ed) and I would be interested in mentoring an outreachy intern on adding support for the Git protocol to wireshark. We think this would be helpful for documenting the spec better, for making debugging easier for future Git developers, and for helping people working on systems involving Git (e.g. CI systems) to understand the behavior of the systems they oversee. We think that a co-mentor within wireshark would be helpful for making sure an intern is set up for success (helping them find pointers, making sure their approach is on the right track, etc).

This would be a project under the Git umbrella
<https://www.outreachy.org/communities/cfp/git/>.

What do you think? Does this sound interesting to you?

Thanks,
Jonathan

#1 lore raw

Hi Jonathan,
Hi Emily

Emily, you want to contribute to wireshark? That is awesome. I think I speak for everyone to send a HUGE welcome
your way and hope your experience working on and with wireshark be excellent!

I think a git dissector would be really awesome.
We do have a packet-git.c already in wireshark, but looking at it it is very barebones (understatement of the year:-)
but getting a real full blown git protocol implementation would be totally awesome.

I am more than happy to provide feedback and advice for Emily. We do have pretty good development documentation so it should be pretty easy to get started and get a development environment up and running.

(
Jonathan, remember that smb2 client I was working on, libamb2? I got it to run on PlayStation2 now. It is totally awesome being able to use SMB3.1.1 and full encryption to copy file between the PS2 memory card and Azure cloud file server :-)
)

best regards
Ronnie Sahlberg

Quoted 24 lines · Jonathan Nieder

Hi wiresharkers,

Outreachy <https://www.outreachy.org/> is a program similar to the Google Summer of Code, providing internships to work on open source projects.

Emily (cc-ed) and I would be interested in mentoring an outreachy intern on adding support for the Git protocol to wireshark. We think this would be helpful for documenting the spec better, for making debugging easier for future Git developers, and for helping people working on systems involving Git (e.g. CI systems) to understand the behavior of the systems they oversee. We think that a co-mentor within wireshark would be helpful for making sure an intern is set up for success (helping them find pointers, making sure their approach is on the right track, etc).

This would be a project under the Git umbrella
<https://www.outreachy.org/communities/cfp/git/>.

What do you think? Does this sound interesting to you?

Thanks,
Jonathan

#9 lore raw
In reply to Jonathan Nieder
Quoted 17 lines · Jonathan Nieder

Hi wiresharkers,

Outreachy <https://www.outreachy.org/> is a program similar to the Google Summer of Code, providing internships to work on open source projects.

Emily (cc-ed) and I would be interested in mentoring an outreachy intern on adding support for the Git protocol to wireshark. We think this would be helpful for documenting the spec better, for making debugging easier for future Git developers, and for helping people working on systems involving Git (e.g. CI systems) to understand the behavior of the systems they oversee. We think that a co-mentor within wireshark would be helpful for making sure an intern is set up for success (helping them find pointers, making sure their approach is on the right track, etc).

Quoted 4 lines

This would be a project under the Git umbrella
<https://www.outreachy.org/communities/cfp/git/>.

What do you think? Does this sound interesting to you?

Replying again to all this time.

We welcome any one who wants to write a dissector or help out in any area of Wireshark, as Ronnie said.

I am more than happy to offer advice and ideas and look at code to get new Wireshark developers going.

Signature · 3 lines
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)(传说杜康是酒的发明者)
#2 lore raw
In reply to ronnie sahlberg
Quoted 6 lines · ronnie sahlberg

Hi Jonathan,
Hi Emily

Emily, you want to contribute to wireshark? That is awesome. I think I speak for everyone to send a HUGE welcome
your way and hope your experience working on and with wireshark be excellent!

I think there's been a misunderstanding. I think the proposal was to have Emily and Jonathan, who are both significant contributors to Git, doing the mentoring from the Git side, along with someone from the Wireshark side. I don't think we know yet if anyone will be interested in working on it, but it seems from the response to be a proposal that has interest in both projects.

Feel free to correct me if I've misunderstood.

Quoted 5 lines

I think a git dissector would be really awesome.
We do have a packet-git.c already in wireshark, but looking at it it is very barebones (understatement of the year:-)
but getting a real full blown git protocol implementation would be totally awesome.

I agree that a Git dissector would be an awesome addition to Wireshark, for all the reasons mentioned, and I do hope someone is able to pick it up. I'd personally find such a feature very useful, and I know some colleagues who probably would as well.

Signature · 1 line
brian m. carlson: Houston, Texas, US
#3 lore raw
Quoted 8 lines · brian m. carlson
Quoted 6 lines · ronnie sahlberg

Hi Jonathan,
Hi Emily

Emily, you want to contribute to wireshark? That is awesome. I think I speak for everyone to send a HUGE welcome
your way and hope your experience working on and with wireshark be excellent!

Quoted 8 lines

I think there's been a misunderstanding. I think the proposal was to have Emily and Jonathan, who are both significant contributors to Git, doing the mentoring from the Git side, along with someone from the Wireshark side. I don't think we know yet if anyone will be interested in working on it, but it seems from the response to be a proposal that has interest in both projects.

Feel free to correct me if I've misunderstood.

That matches my understanding.

#4 lore raw
Quoted 18 lines · Junio C Hamano
Quoted 15 lines · brian m. carlson
Quoted 6 lines · ronnie sahlberg

Hi Jonathan,
Hi Emily

Emily, you want to contribute to wireshark? That is awesome. I think I speak for everyone to send a HUGE welcome
your way and hope your experience working on and with wireshark be excellent!

I think there's been a misunderstanding. I think the proposal was to have Emily and Jonathan, who are both significant contributors to Git, doing the mentoring from the Git side, along with someone from the Wireshark side. I don't think we know yet if anyone will be interested in working on it, but it seems from the response to be a proposal that has interest in both projects.

Quoted 3 lines
Quoted 1 line

Feel free to correct me if I've misunderstood.

That matches my understanding.

Right - brian and Junio are correct, I'm hoping to co-mentor with Jonathan. Ronnie, I'm really pleased to see this warm welcome, which makes me optimistic about the kind of experience an intern would have on this project. It would be really great if we could get a volunteer to serve as point-of-contact if the mentee is not sure about something they want to send to the Wireshark list, and possibly to come to an introductory real-time chat (video/voice/IM) to provide a little overview and nudge in the right direction.

It sounds to me like we have enough enthusiasm to put this project on the list, though - if I understood my conversation with Jonathan last week he's planning to add that. Feel free to correct me :)

Thanks, Ronnie and Richard!

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

(
Jonathan, remember that smb2 client I was working on, libamb2? I got it to run on PlayStation2 now. It is totally awesome being able to use SMB3.1.1 and full encryption to copy file between the PS2 memory card and Azure cloud file server :-)
)

(This actually sounds awesome. Got a repo or blog post up somewhere?)

- Emily

#5 lore raw

Hi Emily

I got confused. I worked in Jonathans team about 5-6 years ago and since I am old fart I couldn't realize that maybe they had other people join since I left.
Hence I assumed you were the intern.

Just me being senile. No harm meant.

Regardless, a git dissectors will be totally awesome so whomever ends up being the intern or whatever doing it, I will be happy to help them get it going and have a successfull project that they can remember with joy and be proud of.

regards
ronnie sahlberg

Quoted 49 lines · Emily Shaffer
Quoted 18 lines · Junio C Hamano
Quoted 15 lines · brian m. carlson
Quoted 6 lines · ronnie sahlberg

Hi Jonathan,
Hi Emily

Emily, you want to contribute to wireshark? That is awesome. I think I speak for everyone to send a HUGE welcome
your way and hope your experience working on and with wireshark be excellent!

I think there's been a misunderstanding. I think the proposal was to have Emily and Jonathan, who are both significant contributors to Git, doing the mentoring from the Git side, along with someone from the Wireshark side. I don't think we know yet if anyone will be interested in working on it, but it seems from the response to be a proposal that has interest in both projects.

Quoted 3 lines
Quoted 1 line

Feel free to correct me if I've misunderstood.

That matches my understanding.

Right - brian and Junio are correct, I'm hoping to co-mentor with Jonathan. Ronnie, I'm really pleased to see this warm welcome, which makes me optimistic about the kind of experience an intern would have on this project. It would be really great if we could get a volunteer to serve as point-of-contact if the mentee is not sure about something they want to send to the Wireshark list, and possibly to come to an introductory real-time chat (video/voice/IM) to provide a little overview and nudge in the right direction.

It sounds to me like we have enough enthusiasm to put this project on the list, though - if I understood my conversation with Jonathan last week he's planning to add that. Feel free to correct me :)

Thanks, Ronnie and Richard!

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

(
Jonathan, remember that smb2 client I was working on, libamb2? I got it to run on PlayStation2 now. It is totally awesome being able to use SMB3.1.1 and full encryption to copy file between the PS2 memory card and Azure cloud file server :-)
)

(This actually sounds awesome. Got a repo or blog post up somewhere?)

- Emily

#6 lore raw
In reply to Emily Shaffer
Quoted 24 lines · Emily Shaffer via Wireshark-dev
Quoted 18 lines · Junio C Hamano
Quoted 15 lines · brian m. carlson
Quoted 6 lines · ronnie sahlberg

Hi Jonathan,
Hi Emily

Emily, you want to contribute to wireshark? That is awesome. I think I speak for everyone to send a HUGE welcome
your way and hope your experience working on and with wireshark be excellent!

I think there's been a misunderstanding. I think the proposal was to have Emily and Jonathan, who are both significant contributors to Git, doing the mentoring from the Git side, along with someone from the Wireshark side. I don't think we know yet if anyone will be interested in working on it, but it seems from the response to be a proposal that has interest in both projects.

Quoted 3 lines
Quoted 1 line

Feel free to correct me if I've misunderstood.

That matches my understanding.

Quoted 8 lines

Right - brian and Junio are correct, I'm hoping to co-mentor with Jonathan. Ronnie, I'm really pleased to see this warm welcome, which makes me optimistic about the kind of experience an intern would have on this project. It would be really great if we could get a volunteer to serve as point-of-contact if the mentee is not sure about something they want to send to the Wireshark list, and possibly to come to an introductory real-time chat (video/voice/IM) to provide a little overview and nudge in the right direction.

I am in the Bay Area so I can serve as the point of contact for some geographies, while Ronnie is in Australasia so he might make a better point of contact for those geographies.

There is quite a bit of information in the Wireshark sources in the doc directory, including several README.* files. There is also a sample dissector in doc/packet-PROTOABBREV.c

However, it can all be a bit daunting for a beginner so I am willing to help get things started.

I should also point out that there are many people on the wireshark-developer mailing list who will be more than happy to help.

Signature · 3 lines
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)(传说杜康是酒的发明者)
#8 lore raw
In reply to a message not in the archive
Quoted 4 lines · Graham Bloice

There's also the Wireshark Developers Guide (https://www.wireshark.org/docs/wsdg_html_chunked/) and for those that are sleep deprived there are a selection of talks on dissectors from previous SharkFest conferences, e.g. Writing a Wireshark dissector: https://www.youtube.com/watch?v=Fp_7g5as1VY

and the much more entertaining one with a different approach from Richard here: https://www.youtube.com/watch?v=XFFkC4PdCbI

Speaking of SharkFest, the next one is in a few weeks: https://sharkfestvirtual.wireshark.org/. Along with the sessions listed in the Agenda we'll have a Developer Den open throughout the conference.