dma-heap: Keep track of the heap device struct
PATCH v3 1/2 dma-heap: Keep track of the heap device struct
Keep track of the heap device struct.
This will be useful for special DMA allocations and actions.
--- drivers/dma-buf/dma-heap.c | 33 +++++++++++++++++++++++++-------- include/linux/dma-heap.h | 9 +++++++++ 2 files changed, 34 insertions(+), 8 deletions(-)
drivers/dma-buf/dma-heap.c +25 -8
@@ -30,6 +30,7 @@* @heap_devt heap device node * @list list head connecting to list of heaps * @heap_cdev heap char device +* @heap_dev heap device struct * * Represents a heap of memory from which buffers can be made. */
@@ -40,6 +41,7 @@ struct dma_heap {dev_t heap_devt;struct list_head list;struct cdev heap_cdev; +struct device *heap_dev; };static LIST_HEAD (heap_list);
@@ -190,10 +192,21 @@ void *dma_heap_get_drvdata(struct dma_heap *heap)return heap->priv; } +/** +* dma_heap_get_dev() - get device struct for the heap +* @heap: DMA-Heap to retrieve device struct from +* +* Returns: +* The device struct for the heap. +*/ +struct device *dma_heap_get_dev (struct dma_heap *heap) +{ +return heap->heap_dev; +} +struct dma_heap *dma_heap_add (const struct dma_heap_export_info *exp_info) {struct dma_heap *heap, *h, *err_ret; -struct device *dev_ret;unsigned int minor;int ret;
@@ -247,16 +260,20 @@ struct dma_heap *dma_heap_add(const struct dma_heap_export_info *exp_info) goto err1; } - dev_ret =device_create (dma_heap_class, -NULL , - heap->heap_devt, -NULL , - heap->name); -if (IS_ERR (dev_ret)) { + heap->heap_dev =device_create (dma_heap_class, +NULL , + heap->heap_devt, +NULL , + heap->name); +if (IS_ERR (heap->heap_dev)) {pr_err ("dma_heap: Unable to create device\n" ); - err_ret =ERR_CAST (dev_ret); + err_ret =ERR_CAST (heap->heap_dev); goto err2; } + +/* Make sure it doesn't disappear on us */ + heap->heap_dev =get_device (heap->heap_dev); +/* Add heap to the list */ mutex_lock (&heap_list_lock);list_add (&heap->list, &heap_list);
include/linux/dma-heap.h +9 -0
@@ -50,6 +50,15 @@ struct dma_heap_export_info {*/ void *dma_heap_get_drvdata (struct dma_heap *heap); +/** +* dma_heap_get_dev() - get device struct for the heap +* @heap: DMA-Heap to retrieve device struct from +* +* Returns: +* The device struct for the heap. +*/ +struct device *dma_heap_get_dev (struct dma_heap *heap); +/** * dma_heap_add - adds a heap to dmabuf heaps * @exp_info: information needed to register this heap
Signature · 1 line
2.17.1
PATCH v3 2/2 dma-heap: Add a system-uncached heap
This adds a heap that allocates non-contiguous buffers that are marked as writecombined, so they are not cached by the CPU.
This is useful, as most graphics buffers are usually not touched by the CPU or only written into once by the CPU. So when mapping the buffer over and over between devices, we can skip the CPU syncing, which saves a lot of cache management overhead, greatly improving performance.
For folk using ION, there was a ION_FLAG_CACHED flag, which signaled if the returned buffer should be CPU cacheable or not. With DMA-BUF heaps, we do not yet have such a flag, and by default the current heaps (system and cma) produce CPU cachable buffers. So for folks transitioning from ION to DMA-BUF Heaps, this fills in some of that missing functionality.
There has been a suggestion to make this functionality a flag (DMAHEAP_FLAG_UNCACHED?) on the system heap, similar to how ION used the ION_FLAG_CACHED. But I want to make sure an _UNCACHED flag would truely be a generic attribute across all heaps. So far that has been unclear, so having it as a separate heap seemes better for now. (But I'm open to discussion on this point!)
Feedback would be very welcome!
Many thanks to Liam Mark for his help to get this working.
Pending opensource users of this code include:
* AOSP HiKey960 gralloc:
- https://android-review.googlesource.com/c/device/linaro/hikey/+/1399519
- Visibly improves performance over the system heap
* AOSP Codec2 (possibly, needs more review):
- https://android-review.googlesource.com/c/platform/frameworks/av/+/1360640/17/media/codec2/vndk/C2DmaBufAllocator.cpp#325
---
v2:
* Fix build issue on sh reported-by: kernel test robot <[email protected]>
* Rework to use for_each_sgtable_sg(), dma_map_sgtable(), and for_each_sg_page() along with numerous other cleanups suggested by Robin Murphy
v3:
* Clarified commit message to address questions from last submission
--- drivers/dma-buf/heaps/Kconfig | 10 + drivers/dma-buf/heaps/Makefile | 1 + drivers/dma-buf/heaps/system_uncached_heap.c | 371 +++++++++++++++++++ 3 files changed, 382 insertions(+) create mode 100644 drivers/dma-buf/heaps/system_uncached_heap.c
drivers/dma-buf/heaps/Kconfig +10 -0
@@ -5,6 +5,16 @@ config DMABUF_HEAPS_SYSTEM Choose this option to enable the system dmabuf heap. The system heap is backed by pages from the buddy allocator. If in doubt, say Y. +config DMABUF_HEAPS_SYSTEM_UNCACHED + bool "DMA-BUF Uncached System Heap" + depends on DMABUF_HEAPS + help + Choose this option to enable the uncached system dmabuf heap. This + heap is backed by pages from the buddy allocator, but pages are setup + for write combining. This avoids cache management overhead, and can + be faster if pages are mostly untouched by the cpu. If in doubt, + say Y. + config DMABUF_HEAPS_CMA bool "DMA-BUF CMA Heap" depends on DMABUF_HEAPS && DMA_CMA
drivers/dma-buf/heaps/Makefile +1 -0
@@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 obj-y += heap-helpers.o obj-$(CONFIG_DMABUF_HEAPS_SYSTEM) += system_heap.o +obj-$(CONFIG_DMABUF_HEAPS_SYSTEM_UNCACHED) += system_uncached_heap.o obj-$(CONFIG_DMABUF_HEAPS_CMA) += cma_heap.o
drivers/dma-buf/heaps/system_uncached_heap.c new file +371 -0
371 lines not on this page · raw message
Signature · 1 line
2.17.1