package/mstpd: new package
PATCH 1/1 package/mstpd: new package
From: Serhiy Boiko <[email protected]>
Add MSTPD (Multiple Spanning Tree Protocol Daemon) an open source user-space daemon licensed under GPLv2.
--- DEVELOPERS | 1 + package/Config.in | 1 + package/mstpd/Config.in | 11 +++++++++++ package/mstpd/mstpd.hash | 3 +++ package/mstpd/mstpd.mk | 20 ++++++++++++++++++++ 5 files changed, 36 insertions(+) create mode 100644 package/mstpd/Config.in create mode 100644 package/mstpd/mstpd.hash create mode 100644 package/mstpd/mstpd.mk
DEVELOPERS +1 -0
@@ -2654,6 +2654,7 @@ N: Vadim Kochan <[email protected]> F: package/brcm-patchram-plus/ F: package/frr/ F: package/gettext-tiny/ +F: package/mstpd/ F: package/tinyssh/ N: Valentin Korenblit <[email protected]>
package/Config.in +1 -0
@@ -2145,6 +2145,7 @@ menu "Networking applications" source "package/mosquitto/Config.in" source "package/mrouted/Config.in" source "package/mrp/Config.in" + source "package/mstpd/Config.in" source "package/mtr/Config.in" source "package/nbd/Config.in" source "package/ncftp/Config.in"
package/mstpd/Config.in new file +11 -0
@@ -0,0 +1,11 @@ +config BR2_PACKAGE_MSTPD + bool "mstpd" + select BR2_PACKAGE_BASH # init + depends on BR2_USE_MMU # bash + help + Multiple Spanning Tree Protocol Daemon + + MSTPD is an open source user-space daemon licensed + under GPLv2. + + https://github.com/mstpd/mstpd
package/mstpd/mstpd.hash new file +3 -0
@@ -0,0 +1,3 @@ +# Locally calculated +sha256 dd6492039368efff0bd13b3f9c8bb32d859ebfe258a70ef23b2163c4b6c35f0c 0.0.8.tar.gz +sha256 c38aee9e3c8c4d5d594ff548a1be05453023016d6286931f6512db215ec1fd42 LICENSE
package/mstpd/mstpd.mk new file +20 -0
@@ -0,0 +1,20 @@ +################################################################################ +# +# mstpd +# +################################################################################ + +MSTPD_VERSION = 0.0.8 +MSTPD_SOURCE = $(MSTPD_VERSION).tar.gz +MSTPD_SITE = https://github.com/mstpd/mstpd/archive +MSTPD_LICENSE = GPL-2.0 +MSTPD_LICENSE_FILES = LICENSE +MSTPD_AUTORECONF = YES + +# mstpd requires that it is installed into /sbin, not /usr/sbin +MSTPD_CONF_OPTS = \ + --prefix=/ \ + --exec-prefix=/ \ + --sbindir=/sbin + +$(eval $(autotools-package))
Signature · 1 line
2.17.1
PATCH 1/1 package/mstpd: new package
Hello Vadym,
Thanks for this contribution. See below for a number of comments.
package/mstpd/Config.in line 3
Quoted 9 lines · On Sat, 19 Sep 2020 23:19:04 +0300 Vadym Kochan <[email protected]> wrote:
package/mstpd/Config.in new file +3
-0@@ -0,0 +1,11 @@ +config BR2_PACKAGE_MSTPD + bool "mstpd" + select BR2_PACKAGE_BASH # init
Are you sure bash is needed? For what? I don't see an init script being installed.
Quoted 6 lines
package/mstpd/mstpd.mk new file +0
-0
package/mstpd/mstpd.mk line 9
Quoted 9 lines
package/mstpd/mstpd.mk new file +9
-0@@ -0,0 +1,20 @@ +################################################################################ +# +# mstpd +# +################################################################################ + +MSTPD_VERSION = 0.0.8 +MSTPD_SOURCE = $(MSTPD_VERSION).tar.gz +MSTPD_SITE = https://github.com/mstpd/mstpd/archive
Please use the github macro, since they haven't uploaded their own tarball.
package/mstpd/mstpd.mk line 10
Quoted 1 line
package/mstpd/mstpd.mk new file +1
-0+MSTPD_LICENSE = GPL-2.0
The license is actually GPL-2.0+
package/mstpd/mstpd.mk line 18
Quoted 8 lines
package/mstpd/mstpd.mk new file +8
-0+MSTPD_LICENSE_FILES = LICENSE +MSTPD_AUTORECONF = YES + +# mstpd requires that it is installed into /sbin, not /usr/sbin +MSTPD_CONF_OPTS = \ + --prefix=/ \ + --exec-prefix=/ \ + --sbindir=/sbin
This doesn't work, because it puts the stuff that normally go into /usr/share into /share, and so the manpages are still on the target as they are not located at the usual /usr/share/man location.
??? share
??? ??? doc
??? ??? ??? mstpd
??? ??? ??? README.VLANs
??? ??? man
??? ??? man5 ??? ??? ??? mstpctl-utils-interfaces.5.gz ??? ??? man8
??? ??? mstpctl.8.gz
Would it be possible instead to fix things so that it can be installed into /usr/sbin ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/mstpd: new package
Hi Thomas,
Quoted 7 lines · Thomas Petazzoni
Hello Vadym,
Thanks for this contribution. See below for a number of comments.
On Sat, 19 Sep 2020 23:19:04 +0300
Vadym Kochan <[email protected]> wrote:
Quoted 10 lines
package/mstpd/Config.in line 3
Quoted 9 lines
package/mstpd/Config.in new file +3
-0@@ -0,0 +1,11 @@ +config BR2_PACKAGE_MSTPD + bool "mstpd" + select BR2_PACKAGE_BASH # init
Might be a mistake.
Quoted 44 lines
Are you sure bash is needed? For what? I don't see an init script being installed.
Quoted 6 lines
package/mstpd/mstpd.mk new file +0
-0package/mstpd/mstpd.mk line 9
Quoted 9 lines
package/mstpd/mstpd.mk new file +9
-0@@ -0,0 +1,20 @@ +################################################################################ +# +# mstpd +# +################################################################################ + +MSTPD_VERSION = 0.0.8 +MSTPD_SOURCE = $(MSTPD_VERSION).tar.gz +MSTPD_SITE = https://github.com/mstpd/mstpd/archivePlease use the github macro, since they haven't uploaded their own tarball.
package/mstpd/mstpd.mk line 10
Quoted 1 line
package/mstpd/mstpd.mk new file +1
-0+MSTPD_LICENSE = GPL-2.0The license is actually GPL-2.0+
package/mstpd/mstpd.mk line 18
Quoted 8 lines
package/mstpd/mstpd.mk new file +8
-0+MSTPD_LICENSE_FILES = LICENSE +MSTPD_AUTORECONF = YES + +# mstpd requires that it is installed into /sbin, not /usr/sbin +MSTPD_CONF_OPTS = \ + --prefix=/ \ + --exec-prefix=/ \ + --sbindir=/sbinThis doesn't work, because it puts the stuff that normally go into
/usr/shareinto /share, and so the manpages are still on the target as they are not located at the usual/usr/share/manlocation.??? share
??? ??? doc
??? ??? ??? mstpd
??? ??? ??? README.VLANs
??? ??? man
Quoted 7 lines
??? ??? man5 ??? ??? ??? mstpctl-utils-interfaces.5.gz ??? ??? man8??? ??? mstpctl.8.gz
Would it be possible instead to fix things so that it can be installed into
/usr/sbin?
I think you are right about the default prefix and --exec-prefix, but regarding --sbindir it looks like it should point to /sbin because Linux's bridge implementation calls /sbin/bridge-stp in case the STP handling is delegated to user space.
Quoted 8 lines
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Regards,
Vadym Kochan