Skip to contentSkip to conversation

dt-bindings: gpio: pl061: add gpio-line-names

PATCH In review Krzysztof Kozlowski 3 participants 14 messages Sep 20, 2020 – Sep 30, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/4 dt-bindings: gpio: pl061: add gpio-line-names

Describe common "gpio-line-names" property to fix dtbs_check warnings like:

arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dt.yaml: gpio@e8a0b000:
'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'

---

Changes since v2:
1. Common GPIO goes to dt-schema

---
 Documentation/devicetree/bindings/gpio/pl061-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/gpio/pl061-gpio.yaml +3 -0
index 313b17229247..bd35cbf7fa09 100644
@@ -51,7 +51,10 @@ properties:
 
   gpio-controller: true
 
+  gpio-line-names: true
+
   gpio-ranges:
+    minItems: 1
     maxItems: 8
 
 required:
Signature · 1 line
2.17.1
#1 lore raw

PATCH v3 2/4 dt-bindings: gpio: fsl-imx-gpio: add i.MX ARMv6 and ARMv7 compatibles

Several DTSes with ARMv6 and ARMv7 i.MX SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm/boot/dts/imx35-pdk.dt.yaml: gpio@53fa4000:
compatible: ['fsl,imx35-gpio', 'fsl,imx31-gpio'] is not valid under any of the given schemas

arch/arm/boot/dts/imx51-babbage.dt.yaml: gpio@73f90000:
compatible: ['fsl,imx51-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 .../devicetree/bindings/gpio/fsl-imx-gpio.yaml       | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml +12 -0
index de0b9b5f6a70..281cdd34a829 100644
@@ -18,8 +18,20 @@ properties:
           - fsl,imx31-gpio
           - fsl,imx35-gpio
           - fsl,imx7d-gpio
+      - items:
+          - const: fsl,imx35-gpio
+          - const: fsl,imx31-gpio
       - items:
           - enum:
+              - fsl,imx50-gpio
+              - fsl,imx51-gpio
+              - fsl,imx53-gpio
+              - fsl,imx6q-gpio
+              - fsl,imx6sl-gpio
+              - fsl,imx6sll-gpio
+              - fsl,imx6sx-gpio
+              - fsl,imx6ul-gpio
+              - fsl,imx7d-gpio
               - fsl,imx8mm-gpio
               - fsl,imx8mn-gpio
               - fsl,imx8mp-gpio
Signature · 1 line
2.17.1
#4 lore raw

PATCH v3 3/4 dt-bindings: gpio: fsl-imx-gpio: add gpio-line-names

In reply to Krzysztof Kozlowski

Describe common "gpio-line-names" property to fix dtbs_check warnings like:

arch/arm/boot/dts/imx53-m53menlo.dt.yaml: gpio@53f84000:

    'gpio-line-names' does not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml +1 -1
index 281cdd34a829..f57d22d1ebd6 100644
@@ -62,7 +62,7 @@ properties:
     const: 2
 
   gpio-controller: true
-
+  gpio-line-names: true
   gpio-ranges: true
 
   power-domains:
Signature · 1 line
2.17.1
#7 lore raw

PATCH v3 4/4 dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching

In reply to Krzysztof Kozlowski

The i.MX 7ULP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:

    compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:
compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected)

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

Changes since v1:
1. New patch

---
 Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/gpio/gpio-vf610.yaml +5 -3
index 6ac5a78ad3da..19738a457a58 100644
@@ -19,9 +19,11 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - fsl,vf610-gpio
-      - fsl,imx7ulp-gpio
+    oneOf:
+      - const: fsl,vf610-gpio
+      - items:
+          - const: fsl,imx7ulp-gpio
+          - const: fsl,vf610-gpio
 
   reg:
     description: The first reg tuple represents the PORT module, the second tuple
Signature · 1 line
2.17.1
maintainer Reviewed-by on v3 1/4
#12 lore raw
In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

Describe common "gpio-line-names" property to fix dtbs_check warnings like:

arch/arm64/boot/dts/hisilicon/hi3670-hikey970.dt.yaml: gpio@e8a0b000:
'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'

Quoted 8 lines

---

Changes since v2:
1. Common GPIO goes to dt-schema

---
 Documentation/devicetree/bindings/gpio/pl061-gpio.yaml | 3 +++
 1 file changed, 3 insertions(+)
maintainer Reviewed-by on v3 2/4
#2 lore raw

Re: [PATCH v3 2/4] dt-bindings: gpio: fsl-imx-gpio: add i.MX ARMv6 and ARMv7 compatibles

In reply to Krzysztof Kozlowski
Quoted 11 lines · Krzysztof Kozlowski

Several DTSes with ARMv6 and ARMv7 i.MX SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm/boot/dts/imx35-pdk.dt.yaml: gpio@53fa4000:
compatible: ['fsl,imx35-gpio', 'fsl,imx31-gpio'] is not valid under any of the given schemas

arch/arm/boot/dts/imx51-babbage.dt.yaml: gpio@73f90000:
compatible: ['fsl,imx51-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas

Quoted 8 lines

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 .../devicetree/bindings/gpio/fsl-imx-gpio.yaml       | 12 ++++++++++++
 1 file changed, 12 insertions(+)
maintainer Reviewed-by on v3 3/4
#5 lore raw

Re: [PATCH v3 3/4] dt-bindings: gpio: fsl-imx-gpio: add gpio-line-names

In reply to Krzysztof Kozlowski
Quoted 8 lines · Krzysztof Kozlowski

Describe common "gpio-line-names" property to fix dtbs_check warnings like:

arch/arm/boot/dts/imx53-m53menlo.dt.yaml: gpio@53f84000:

    'gpio-line-names' does not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
Quoted 8 lines

---

Changes since v2:
1. None, split from previous patchset using common GPIO schema

---
 Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
maintainer Reviewed-by on v3 4/4
#8 lore raw

Re: [PATCH v3 4/4] dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching

In reply to Krzysztof Kozlowski
Quoted 13 lines · Krzysztof Kozlowski

The i.MX 7ULP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:

    compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:
compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected)

---

Quoted 9 lines

Changes since v2:
1. None, split from previous patchset using common GPIO schema

Changes since v1:
1. New patch

---
 Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
#3 lore raw

Re: [PATCH v3 2/4] dt-bindings: gpio: fsl-imx-gpio: add i.MX ARMv6 and ARMv7 compatibles

In reply to Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski

Several DTSes with ARMv6 and ARMv7 i.MX SoCs introduce their own compatibles so add them to fix dtbs_check warnings like:

arch/arm/boot/dts/imx35-pdk.dt.yaml: gpio@53fa4000:
compatible: ['fsl,imx35-gpio', 'fsl,imx31-gpio'] is not valid under any of the given schemas

arch/arm/boot/dts/imx51-babbage.dt.yaml: gpio@73f90000:
compatible: ['fsl,imx51-gpio', 'fsl,imx35-gpio'] is not valid under any of the given schemas

Patch applied.

Yours,
Linus Walleij

#6 lore raw

Re: [PATCH v3 3/4] dt-bindings: gpio: fsl-imx-gpio: add gpio-line-names

In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

Describe common "gpio-line-names" property to fix dtbs_check warnings like:

arch/arm/boot/dts/imx53-m53menlo.dt.yaml: gpio@53f84000:

    'gpio-line-names' does not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'

Patch applied.

Yours,
Linus Walleij

#9 lore raw

Re: [PATCH v3 4/4] dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching

In reply to Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski

The i.MX 7ULP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:

    compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:
compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected)

This patch doesn't apply to my tree linux-gpio "devel":

$ git am --signoff
./v3_20200920_krzk_dt_bindings_gpio_pl061_add_gpio_line_names.mbx
Applying: dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching
error: Documentation/devicetree/bindings/gpio/gpio-vf610.yaml: does
not exist in index
Patch failed at 0001 dt-bindings: gpio: gpio-vf610: fix iMX 7ULP
compatible matching

Yours,
Linus Walleij

maintainer
#10 lore raw

Re: [PATCH v3 4/4] dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching

Quoted 15 lines · Linus Walleij
Quoted 10 lines · Krzysztof Kozlowski

The i.MX 7ULP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:

    compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:
compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected)

This patch doesn't apply to my tree linux-gpio "devel":

Quoted 7 lines
$ git am --signoff
./v3_20200920_krzk_dt_bindings_gpio_pl061_add_gpio_line_names.mbx
Applying: dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching
error: Documentation/devicetree/bindings/gpio/gpio-vf610.yaml: does
not exist in index
Patch failed at 0001 dt-bindings: gpio: gpio-vf610: fix iMX 7ULP
compatible matching

It's in my tree, so I've applied it.

Rob

#11 lore raw

Re: [PATCH v3 4/4] dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching

Quoted 24 lines · Rob Herring
Quoted 15 lines · Linus Walleij
Quoted 10 lines · Krzysztof Kozlowski

The i.MX 7ULP DTSes use two compatibles so update the binding to fix dtbs_check warnings like:

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:

    compatible: ['fsl,imx7ulp-gpio', 'fsl,vf610-gpio'] is too long

arch/arm/boot/dts/imx7ulp-com.dt.yaml: gpio@40ae0000:
compatible: Additional items are not allowed ('fsl,vf610-gpio' was unexpected)

This patch doesn't apply to my tree linux-gpio "devel":

Quoted 7 lines
$ git am --signoff
./v3_20200920_krzk_dt_bindings_gpio_pl061_add_gpio_line_names.mbx
Applying: dt-bindings: gpio: gpio-vf610: fix iMX 7ULP compatible matching
error: Documentation/devicetree/bindings/gpio/gpio-vf610.yaml: does
not exist in index
Patch failed at 0001 dt-bindings: gpio: gpio-vf610: fix iMX 7ULP
compatible matching
Quoted 1 line

It's in my tree, so I've applied it.

Excellent, thanks Rob.

Yours,
Linus Walleij