arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
Subsystems (2)
PATCH 1/1 arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
The included armada-372x.dtsi already defines these two aliases.
---
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"
The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0 -2
@@ -17,8 +17,6 @@ aliases { ethernet1 = &switch0port1; ethernet2 = &switch0port2; ethernet3 = &switch0port3; - serial0 = &uart0; - serial1 = &uart1; }; chosen {
Signature · 7 lines
2.28.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 1 line · On Monday 21 September 2020 18:48:30 Andre Heider wrote:
The included
armada-372x.dtsialready defines these two aliases.
Where? I do not see it in that file:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsi
Quoted 28 lines
Signed-off-by Andre Heider <[email protected]>---
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- 1 file changed, 2 deletions(-)arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0
-2@@ -17,8 +17,6 @@ aliases { ethernet1 = &switch0port1; ethernet2 = &switch0port2; ethernet3 = &switch0port3; - serial0 = &uart0; - serial1 = &uart1; }; chosen {Signature · 1 line
2.28.0
Quoted 5 lines · Pali Rohár
Quoted 1 line · On Monday 21 September 2020 18:48:30 Andre Heider wrote:
The included
armada-372x.dtsialready defines these two aliases.Where? I do not see it in that file:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsi
Oh sorry, it's in armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n20
Quoted 29 lines
Quoted 29 lines
Signed-off-by Andre Heider <[email protected]>---
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- 1 file changed, 2 deletions(-)arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0
-2@@ -17,8 +17,6 @@ aliases { ethernet1 = &switch0port1; ethernet2 = &switch0port2; ethernet3 = &switch0port3; - serial0 = &uart0; - serial1 = &uart1; }; chosen {Signature · 1 line
2.28.0
Pali Rohár
Reviewed-byQuoted 9 lines · On Monday 21 September 2020 18:57:46 Andre Heider wrote:
Quoted 5 lines · Pali Rohár
Quoted 1 line · On Monday 21 September 2020 18:48:30 Andre Heider wrote:
The included
armada-372x.dtsialready defines these two aliases.Where? I do not see it in that file:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsiOh sorry, it's in
armada-37xx.dtsi:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-37xx.dtsi#n20
Ok, with fixing file in commit message you can add my:
Quoted 29 lines
Quoted 28 lines
Quoted 28 lines
Signed-off-by Andre Heider <[email protected]>---
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- 1 file changed, 2 deletions(-)arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0
-2@@ -17,8 +17,6 @@ aliases { ethernet1 = &switch0port1; ethernet2 = &switch0port2; ethernet3 = &switch0port3; - serial0 = &uart0; - serial1 = &uart1; }; chosen {Signature · 1 line
2.28.0
PATCH v2 1/1 arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
In reply to Andre HeiderThe included armada-3xxx.dtsi already defines these two aliases.
---
v2: fix filename in commit message
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"
The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0 -2
@@ -17,8 +17,6 @@ aliases { ethernet1 = &switch0port1; ethernet2 = &switch0port2; ethernet3 = &switch0port3; - serial0 = &uart0; - serial1 = &uart1; }; chosen {
Signature · 1 line
2.28.0
PATCH v3 1/1 arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases
In reply to Andre HeiderThe included armada-37xx.dtsi already defines these two aliases.
---
v3: really fix filename, sorry for the spam... too early, not enough coffee
v2: fix filename in commit message
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"
The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0 -2
@@ -17,8 +17,6 @@ aliases { ethernet1 = &switch0port1; ethernet2 = &switch0port2; ethernet3 = &switch0port3; - serial0 = &uart0; - serial1 = &uart1; }; chosen {
Signature · 1 line
2.28.0
Gregory CLEMENT
maintainerHi Andre,
Quoted 3 lines
The included
armada-372x.dtsialready defines these two aliases.Signed-off-by Andre Heider <[email protected]>
Applied on mvebu/dt
Thanks,
Gregory
Quoted 26 lines
---
This goes on top of Pali's patch:
"arm64: dts: marvell: espressobin: Add ethernet switch aliases"The resulting .dtb files are the same.
arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi | 2 -- 1 file changed, 2 deletions(-)arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi +0
-2@@ -17,8 +17,6 @@ aliases { ethernet1 = &switch0port1; ethernet2 = &switch0port2; ethernet3 = &switch0port3; - serial0 = &uart0; - serial1 = &uart1; }; chosen {Signature · 1 line
2.28.0
Signature · 3 lines
Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com