clk: s2mps11: initialize driver via module_platform_driver
Krzysztof Kozlowski
maintainerPATCH 1/1 clk: s2mps11: initialize driver via module_platform_driver
The driver was using subsys_initcall() because in old times deferred probe was not supported everywhere and specific ordering was needed. Since probe deferral works fine and specific ordering is discouraged (hides dependencies between drivers and couples their boot order), the driver can be converted to regular module_platform_driver.
--- drivers/clk/clk-s2mps11.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)
drivers/clk/clk-s2mps11.c +1 -12
@@ -267,18 +267,7 @@ static struct platform_driver s2mps11_clk_driver = { .remove = s2mps11_clk_remove, .id_table = s2mps11_clk_id, }; - -static int __init s2mps11_clk_init (void ) -{ -return platform_driver_register (&s2mps11_clk_driver); -} -subsys_initcall (s2mps11_clk_init); - -static void __exit s2mps11_clk_cleanup(void) -{ -platform_driver_unregister (&s2mps11_clk_driver); -} -module_exit (s2mps11_clk_cleanup); +module_platform_driver (s2mps11_clk_driver);MODULE_DESCRIPTION ("S2MPS11 Clock Driver" );MODULE_AUTHOR ("Yadwinder Singh Brar <[email protected]>" );
Signature · 1 line
2.17.1
Hi Krzysztof,
Quoted 7 lines · Krzysztof Kozlowski
The driver was using
subsys_initcall()because in old times deferred probe was not supported everywhere and specific ordering was needed. Since probe deferral works fine and specific ordering is discouraged (hides dependencies between drivers and couples their boot order), the driver can be converted to regularmodule_platform_driver.Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 18 lines
--- drivers/clk/clk-s2mps11.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)drivers/clk/clk-s2mps11.c +0
-6@@ -267,18 +267,7 @@ static struct platform_driver s2mps11_clk_driver = { .remove = s2mps11_clk_remove, .id_table = s2mps11_clk_id, }; - -static int __init s2mps11_clk_init (void ) -{ -return platform_driver_register (&s2mps11_clk_driver); -} -subsys_initcall (s2mps11_clk_init);
drivers/clk/clk-s2mps11.c static struct platform_driver s2mps11_clk_driver = { · line 273
Quoted 10 lines
drivers/clk/clk-s2mps11.c +1
-6- -static void __exit s2mps11_clk_cleanup(void) -{ -platform_driver_unregister (&s2mps11_clk_driver); -} -module_exit (s2mps11_clk_cleanup); +module_platform_driver (s2mps11_clk_driver);MODULE_DESCRIPTION ("S2MPS11 Clock Driver" );MODULE_AUTHOR ("Yadwinder Singh Brar <[email protected]>" );
Best regards
Signature · 2 lines
Marek Szyprowski, PhD Samsung R&D Institute Poland
Quoting Krzysztof Kozlowski (2020-09-21 13:35:57)
Quoted 8 lines
The driver was using
subsys_initcall()because in old times deferred probe was not supported everywhere and specific ordering was needed. Since probe deferral works fine and specific ordering is discouraged (hides dependencies between drivers and couples their boot order), the driver can be converted to regularmodule_platform_driver.Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next