Skip to contentSkip to conversation

Fix top_srcdir handling in numa/sound test Makefiles

PATCH Superseded Martin Doucha 2 participants 2 messages Sep 22, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix top_srcdir handling in numa/sound test Makefiles

---
 testcases/kernel/numa/Makefile  | 18 ++----------------
 testcases/kernel/sound/Makefile |  2 +-
 2 files changed, 3 insertions(+), 17 deletions(-)
testcases/kernel/numa/Makefile +2 -16
index 48494e456..2c6a7c6a1 100644
@@ -1,22 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
 #
 #  Copyright (c) International Business Machines  Corp., 2007
-#
-#  This program is free software;  you can redistribute it and/or modify
-#  it under the terms of the GNU General Public License as published by
-#  the Free Software Foundation; either version 2 of the License, or
-#  (at your option) any later version.
-#
-#  This program is distributed in the hope that it will be useful,
-#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
-#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
-#  the GNU General Public License for more details.
-#
-#  You should have received a copy of the GNU General Public License
-#  along with this program;  if not, write to the Free Software
-#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#
 
-top_srcdir		:= ../../..
+top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
testcases/kernel/sound/Makefile +1 -1
index 022e69197..5c728ef36 100644
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-top_srcdir		:= ../../..
+top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 Fix top_srcdir handling in numa/sound test Makefiles

Hi!

Quoted 19 lines
---
 testcases/kernel/numa/Makefile  | 18 ++----------------
 testcases/kernel/sound/Makefile |  2 +-
 2 files changed, 3 insertions(+), 17 deletions(-)
testcases/kernel/numa/Makefile +1 -5
index 48494e456..2c6a7c6a1 100644
@@ -1,22 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
 #
 #  Copyright (c) International Business Machines  Corp., 2007
-#
-#  This program is free software;  you can redistribute it and/or modify
-#  it under the terms of the GNU General Public License as published by
-#  the Free Software Foundation; either version 2 of the License, or
-#  (at your option) any later version.

testcases/kernel/numa/Makefile line 17

Quoted 10 lines
testcases/kernel/numa/Makefile +0 -10
-#
-#  This program is distributed in the hope that it will be useful,
-#  but WITHOUT ANY WARRANTY;  without even the implied warranty of
-#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
-#  the GNU General Public License for more details.
-#
-#  You should have received a copy of the GNU General Public License
-#  along with this program;  if not, write to the Free Software
-#  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-#

Well technically unrealted changes should be divided into a separate patches so that in a case of revert we do not have to revert everything but only the offending change...

Quoted 23 lines
testcases/kernel/numa/Makefile +1 -1
-top_srcdir		:= ../../..
+top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
testcases/kernel/sound/Makefile +1 -1
index 022e69197..5c728ef36 100644
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
 
-top_srcdir		:= ../../..
+top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/testcases.mk
 
Signature · 5 lines
2.28.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 2 lines
Cyril Hrubis
[email protected]