Skip to contentSkip to conversation

FIX the comment of struct jbd2_journal_handle

PATCH In review Hui Su 3 participants 3 messages Sep 22, 2020 – Oct 3, 2020 Journalling layer for block devices (JBD2)

lore
Share & tools
lore

Hui Su

author
#0 lore raw

PATCH 1/1 FIX the comment of struct jbd2_journal_handle

the struct name was modified long ago, but the comment still use struct handle_s.

Signed-off-by Hui Su <[email protected]>
---
 include/linux/jbd2.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/jbd2.h +2 -2
index 08f904943ab2..a1ef05412acf 100644
@@ -452,8 +452,8 @@ struct jbd2_inode {
 struct jbd2_revoke_table_s;
 
 /**
- * struct handle_s - The handle_s type is the concrete type associated with
- *     handle_t.
+ * struct jbd2_journal_handle - The jbd2_journal_handle type is the concrete
+ *     type associated with handle_t.
  * @h_transaction: Which compound transaction is this update a part of?
  * @h_journal: Which journal handle belongs to - used iff h_reserved set.
  * @h_rsv_handle: Handle reserved for finishing the logical operation.
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Hui Su

the struct name was modified long ago, but the comment still use struct handle_s.

Signed-off-by Hui Su <[email protected]>

Thanks for the patch. It looks good to me. You can add:

Reviewed-by Jan Kara <[email protected]>

Honza

Quoted 23 lines
---
 include/linux/jbd2.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/jbd2.h +2 -2
index 08f904943ab2..a1ef05412acf 100644
@@ -452,8 +452,8 @@ struct jbd2_inode {
 struct jbd2_revoke_table_s;
 
 /**
- * struct handle_s - The handle_s type is the concrete type associated with
- *     handle_t.
+ * struct jbd2_journal_handle - The jbd2_journal_handle type is the concrete
+ *     type associated with handle_t.
  * @h_transaction: Which compound transaction is this update a part of?
  * @h_journal: Which journal handle belongs to - used iff h_reserved set.
  * @h_rsv_handle: Handle reserved for finishing the logical operation.
Signature · 1 line
2.25.1
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR