drm/i915: kernel-doc fixes for new DP helpers
Subsystems (2)
cover drm/i915: kernel-doc fixes for new DP helpers
Note that none of the code that this touches is in i915, however at the time I posted this patch all of the DP helpers that concern these patches were added through drm-intel-next-queued, not drm-misc-next, so it makes more sense to merge it through drm-intel-next-queued. As such, I'm just sending this onto intel-gfx so that it gets a patch ID.
This should introduce no functional changes, and is already reviewed by me.
Mauro Carvalho Chehab (2):
drm/dp: fix kernel-doc warnings at drm_dp_helper.c drm/dp: fix a kernel-doc issue at drm_edid.c
drivers/gpu/drm/drm_dp_helper.c | 5 +++++ drivers/gpu/drm/drm_edid.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH RESEND 1/2 drm/dp: fix kernel-doc warnings at drm_dp_helper.c
From: Mauro Carvalho Chehab <[email protected]>
As warned by kernel-doc:
./drivers/gpu/drm/drm_dp_helper.c:385: warning: Function parameter or member 'type' not described in 'drm_dp_downstream_is_type' ./drivers/gpu/drm/drm_dp_helper.c:886: warning: Function parameter or member 'dev' not described in 'drm_dp_downstream_mode'
Some function parameters weren't documented.
--- drivers/gpu/drm/drm_dp_helper.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/drm_dp_helper.c +5 -0
@@ -374,6 +374,10 @@ static bool is_edid_digital_input_dp(const struct edid *edid)* drm_dp_downstream_is_type() - is the downstream facing port of certain type? * @dpcd: DisplayPort configuration data * @port_cap: port capabilities +* @type: port type to be checked. Can be: +* %DP_DS_PORT_TYPE_DP, %DP_DS_PORT_TYPE_VGA, %DP_DS_PORT_TYPE_DVI, +* %DP_DS_PORT_TYPE_HDMI, %DP_DS_PORT_TYPE_NON_EDID, +* %DP_DS_PORT_TYPE_DP_DUALMODE or %DP_DS_PORT_TYPE_WIRELESS. * * Caveat: Only works with DPCD 1.1+ port caps. *
@@ -870,6 +874,7 @@ EXPORT_SYMBOL(drm_dp_downstream_444_to_420_conversion);/** * drm_dp_downstream_mode() - return a mode for downstream facing port +* @dev: DRM device * @dpcd: DisplayPort configuration data * @port_cap: port capabilities *
Signature · 1 line
2.26.2
PATCH RESEND 2/2 drm/dp: fix a kernel-doc issue at drm_edid.c
In reply to Lyude PaulFrom: Mauro Carvalho Chehab <[email protected]>
The name of the argument is different, causing those warnings:
./drivers/gpu/drm/drm_edid.c:3754: warning: Function parameter or member 'video_code' not described in 'drm_display_mode_from_cea_vic' ./drivers/gpu/drm/drm_edid.c:3754: warning: Excess function parameter 'vic' description in 'drm_display_mode_from_cea_vic'
--- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_edid.c +1 -1
@@ -3741,7 +3741,7 @@ drm_add_cmdb_modes(struct drm_connector *connector, u8 svd)/** * drm_display_mode_from_cea_vic() - return a mode for CEA VIC * @dev: DRM device -* @vic: CEA VIC of the mode +* @video_code: CEA VIC of the mode * * Creates a new mode matching the specified CEA VIC. *
Signature · 1 line
2.26.2
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: kernel-doc fixes for new DP helpers
In reply to Lyude Paul== Series Details ==
== Series Details ==
Series: drm/i915: kernel-doc fixes for new DP helpers
URL : https://patchwork.freedesktop.org/series/81985/
State : failure
== Summary ==
Applying: drm/dp: fix kernel-doc warnings at drm_dp_helper.c Using index info to reconstruct a base tree...
M drivers/gpu/drm/drm_dp_helper.c
Falling back to patching base and 3-way merge... No changes -- Patch already applied.
Applying: drm/dp: fix a kernel-doc issue at drm_edid.c Using index info to reconstruct a base tree...
M drivers/gpu/drm/drm_edid.c
Falling back to patching base and 3-way merge... No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx