Skip to contentSkip to conversation

packagegroup: rrecommend perf also for musl

PATCH Superseded Christian Eggers 3 participants 5 messages Sep 23, 2020 – Sep 25, 2020 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 packagegroup: rrecommend perf also for musl

The perf recipe builds fine for musl.

Fixes d758a4445a ("packagegroup: Disable packages not available on musl")
---
 .../packagegroups/packagegroup-core-tools-profile.bb          | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -3
index 1c94653d72..a5dca95c2a 100644
@@ -17,7 +17,7 @@ PROFILE_TOOLS_X_nios2 = ""
 PROFILE_TOOLS_SYSTEMD = "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd-analyze', '', d)}"
 
 RRECOMMENDS_${PN} = "\
-    ${PERF} \
+    perf \
     blktrace \
     ${PROFILE_TOOLS_X} \
     ${PROFILE_TOOLS_SYSTEMD} \
@@ -26,8 +26,6 @@ RRECOMMENDS_${PN} = "\
 PROFILETOOLS = "\
     powertop \
     "
-PERF = "perf"
-PERF_libc-musl = ""
 
 # systemtap needs elfutils which is not fully buildable on some arches/libcs
 SYSTEMTAP = "systemtap"
Signature · 8 lines
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
#1 lore raw
Quoted 2 lines · Christian Eggers

The perf recipe builds fine for musl.

which all architectures did you build on musl ? Regardless of that we should still use PERF var so non-core architectures can still override it

Quoted 39 lines
Fixes d758a4445a ("packagegroup: Disable packages not available on musl")
---
 .../packagegroups/packagegroup-core-tools-profile.bb          | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -4
index 1c94653d72..a5dca95c2a 100644
@@ -17,7 +17,7 @@ PROFILE_TOOLS_X_nios2 = ""
 PROFILE_TOOLS_SYSTEMD = "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd-analyze', '', d)}"
 
 RRECOMMENDS_${PN} = "\
-    ${PERF} \
+    perf \
     blktrace \
     ${PROFILE_TOOLS_X} \
     ${PROFILE_TOOLS_SYSTEMD} \
@@ -26,8 +26,6 @@ RRECOMMENDS_${PN} = "\
 PROFILETOOLS = "\
     powertop \
     "
-PERF = "perf"
-PERF_libc-musl = ""
 
 # systemtap needs elfutils which is not fully buildable on some arches/libcs
 SYSTEMTAP = "systemtap"
--

Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918 Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler

#2 lore raw

PATCH v2 1/1 packagegroup: rrecommend perf also for musl on ARM

The perf recipe builds fine for musl on ARM.

Fixes d758a4445a ("packagegroup: Disable packages not available on musl")

---

Quoted 4 lines · Khem Raj
Quoted 1 line · Christian Eggers

The perf recipe builds fine for musl.

which all architectures did you build on musl ?

only on ARM.

Quoted 2 lines

Regardless of that we should still use PERF var so non-core architectures can still override it

 .../packagegroups/packagegroup-core-tools-profile.bb             | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -0
index 1c94653d72..d437e28311 100644
@@ -28,6 +28,7 @@ PROFILETOOLS = "\
     "
 PERF = "perf"
 PERF_libc-musl = ""
+PERF_libc-musl_arm = "perf"
 
 # systemtap needs elfutils which is not fully buildable on some arches/libcs
 SYSTEMTAP = "systemtap"
Signature · 8 lines
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
#3 lore raw

Re: [OE-core] [PATCH v2] packagegroup: rrecommend perf also for musl on ARM

Is this also suitable for dunfell inclusion?

Thanks!

Steve

Quoted 44 lines · Christian Eggers

The perf recipe builds fine for musl on ARM.

Fixes d758a4445a ("packagegroup: Disable packages not available on musl")

---

Quoted 4 lines · Khem Raj
Quoted 1 line · Christian Eggers

The perf recipe builds fine for musl.

which all architectures did you build on musl ?

only on ARM.

Quoted 2 lines

Regardless of that we should still use PERF var so non-core architectures can still override it

 .../packagegroups/packagegroup-core-tools-profile.bb             | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -1
index 1c94653d72..d437e28311 100644
@@ -28,6 +28,7 @@ PROFILETOOLS = "\
     "
 PERF = "perf"
 PERF_libc-musl = ""
+PERF_libc-musl_arm = "perf"
 
 # systemtap needs elfutils which is not fully buildable on some arches/libcs
 SYSTEMTAP = "systemtap"
--

Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918 Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler

A message that is not in the archive (sent off-list or not yet received): 3205654.9nU1JGFCk1@n95hx1g2

#5 lore raw

Re: [OE-core] [PATCH v2] packagegroup: rrecommend perf also for musl on ARM

Quoted 5 lines · Christian Eggers
Quoted 1 line · Steve Sakoman

Is this also suitable for dunfell inclusion?

Yes, it is.

Thanks Christian!

Quoted 58 lines
Quoted 9 lines · Christian Eggers
Quoted 8 lines

The perf recipe builds fine for musl on ARM.

Fixes d758a4445a ("packagegroup: Disable packages not available on musl")

---

Quoted 1 line · Khem Raj

On Wed, Sep 23, 2020 at 1:46 AM Christian Eggers <[email protected]>

Quoted 44 lines · wrote:
Quoted 44 lines
Quoted 3 lines
Quoted 1 line

The perf recipe builds fine for musl.

which all architectures did you build on musl ?

only on ARM.

Quoted 2 lines

Regardless of that we should still use PERF var so non-core architectures can still override it

 .../packagegroups/packagegroup-core-tools-profile.bb             | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb index 1c94653d72..d437e28311 100644

meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +1 -0
@@ -28,6 +28,7 @@ PROFILETOOLS = "\
 
     "
 
 PERF = "perf"
 PERF_libc-musl = ""
 
+PERF_libc-musl_arm = "perf"
 # systemtap needs elfutils which is not fully buildable on some
 arches/libcs SYSTEMTAP = "systemtap"

--
Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen -
Handelsregisternummer: HRA 57918 Persoenlich haftender Gesellschafter:
Arnold & Richter Cine Technik GmbH Sitz: Muenchen - Registergericht:
Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler