Skip to contentSkip to conversation

drm/msm/dp: fix incorrect function prototype of dp_debug_get()

PATCH Superseded Abhinav Kumar 2 participants 3 messages Sep 23, 2020 – Sep 24, 2020

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dp: fix incorrect function prototype of dp_debug_get()

Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning.

Fixes f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")
---
 drivers/gpu/drm/msm/dp/dp_debug.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/dp/dp_debug.h +1 -1
index 377e166fd0ea..7eaedfbb149c 100644
@@ -60,7 +60,7 @@ void dp_debug_put(struct dp_debug *dp_debug);
 static inline
 struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
 		struct dp_usbpd *usbpd, struct dp_link *link,
-		struct drm_connector **connector)
+		struct drm_connector **connector, struct drm_minor *minor)
 {
 	return ERR_PTR(-EINVAL);
 }
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Quoting Abhinav Kumar (2020-09-23 16:24:48)

Quoted 7 lines

Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning.

Fixes f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")

---

Will the compliance testing parts be moved out of debugfs at some point? Just curious what the plan is there.

#2 lore raw

Hi Stephen

Thanks for the review.

Quoted 9 lines · Stephen Boyd

Quoting Abhinav Kumar (2020-09-23 16:24:48)

Quoted 7 lines

Fix the incorrect function prototype for dp_debug_get() in the dp_debug module to address compilation warning.

Fixes f913454aae8e ("drm/msm/dp: move debugfs node to /sys/kernel/debug/dri/*/")

---

Quoted 4 lines

Will the compliance testing parts be moved out of debugfs at some point? Just curious what the plan is there.

No, the video pattern compliance testing parts will remain in debugfs as they use IGT as the userspace entity which is debugfs based for DP compliance tests.

Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel