numa: hmat: require parent cache description before the next level one
PATCH 1/1 numa: hmat: require parent cache description before the next level one
Spec[1] defines 0 - 3 level memory side cache, however QEMU CLI allows to specify an intermediate cache level without specifying previous level. Such option(s) silently ignored when building HMAT table, which leads to incomplete cache information.
Make sure that previous level exists and error out if it hasn't been provided.
1) ACPI 6.2A 5.2.27.5 Memory Side Cache Information Structure
--- hw/core/numa.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
hw/core/numa.c +7 -1
@@ -424,7 +424,13 @@ void parse_numa_hmat_cache(MachineState *ms, NumaHmatCacheOptions *node, }if ((node->level >1 ) && - ms->numa_state->hmat_cache[node->node_id][node->level -1 ] && + ms->numa_state->hmat_cache[node->node_id][node->level -1 ] ==NULL ) { +error_setg (errp,"Cache level=%" PRIu8" shall be defined first" , + node->level -1 ); +return ; + } + +if ((node->level >1 ) && (node->size <= ms->numa_state->hmat_cache[node->node_id][node->level -1 ]->size)) { error_setg(errp, "Invalid size=%" PRIu64 ", the size of level=%" PRIu8
Signature · 1 line
2.27.0
Quoted 8 lines · Igor Mammedov
Spec[1] defines 0 - 3 level memory side cache, however QEMU CLI allows to specify an intermediate cache level without specifying previous level. Such option(s) silently ignored when building HMAT table, which leads to incomplete cache information.
Make sure that previous level exists and error out if it hasn't been provided.
Quoted 4 lines
1) ACPI 6.2A 5.2.27.5 Memory Side Cache Information Structure
Queueing on machine-next, thanks!
Signature · 1 line
Eduardo