Skip to contentSkip to conversation

drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:752 hubp1_is_flip_pending() error: we previously assumed 'hubp' could be null (see line 737)

PATCH New Dan Carpenter 1 participant 1 message Sep 25, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 7429/10763 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:752 hubp1_is_flip_pending() error: we previously assumed 'hubp' could be null (see line 737)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git  master
head:   d1d2220c7f39d0fca302c4ba6cca4ede01660a2b
commit: e8cb7a4dd9dffff72172d94dcea4577219426106 [7429/10763] drm/amd/display: Flip pending check timeout due to disabled hubp
config: i386-randconfig-m021-20200924 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c:752 hubp1_is_flip_pending() error: we previously assumed 'hubp' could be null (see line 737) drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_hubp.c:926 hubp2_is_flip_pending() error: we previously assumed 'hubp' could be null (see line 911)

# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e8cb7a4dd9dffff72172d94dcea4577219426106
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout e8cb7a4dd9dffff72172d94dcea4577219426106
vim +/hubp +752 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubp.c

8feabd03d34e45 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yue Hin Lau        2017-10-02  731  bool hubp1_is_flip_pending(struct hubp *hubp)
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  732  {
db3bc05034a4b0 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Dmytro Laktyushkin 2017-06-28  733  	uint32_t flip_pending = 0;
8feabd03d34e45 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yue Hin Lau        2017-10-02  734  	struct dcn10_hubp *hubp1 = TO_DCN10_HUBP(hubp);
                                                                                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^

I'm not sure how "hubp1" is used, but presumably if "hubp" is NULL then we are toasted.

2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  735  	struct dc_plane_address earliest_inuse_address;
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  736  
e8cb7a4dd9dfff drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c      Aric Cyr           2020-08-21 @737  	if (hubp && hubp->power_gated)
                                                                                                                    ^^^^

The patch adds a check for NULL

e8cb7a4dd9dfff drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c      Aric Cyr           2020-08-21  738  		return false;
e8cb7a4dd9dfff drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c      Aric Cyr           2020-08-21  739  
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  740  	REG_GET(DCSURF_FLIP_CONTROL,
db3bc05034a4b0 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Dmytro Laktyushkin 2017-06-28  741  			SURFACE_FLIP_PENDING, &flip_pending);
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  742  
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  743  	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE,
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  744  			SURFACE_EARLIEST_INUSE_ADDRESS, &earliest_inuse_address.grph.addr.low_part);
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  745  
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  746  	REG_GET(DCSURF_SURFACE_EARLIEST_INUSE_HIGH,
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  747  			SURFACE_EARLIEST_INUSE_ADDRESS_HIGH, &earliest_inuse_address.grph.addr.high_part);
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  748  
db3bc05034a4b0 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Dmytro Laktyushkin 2017-06-28  749  	if (flip_pending)
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  750  		return true;
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  751  
8feabd03d34e45 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yue Hin Lau        2017-10-02 @752  	if (earliest_inuse_address.grph.addr.quad_part != hubp->request_address.grph.addr.quad_part)
                                                                                                                                                                  ^^^^^^

But the old code doesn't check for NULL. Just delete the check?

2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  753  		return true;
2f1e8efd10315c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Yongqiang Sun      2017-06-06  754  
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  755  	return false;
70ccab604049bb drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mem_input.c Harry Wentland     2017-05-08  756  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org