net/mlx5e: Fix potential null pointer dereference
Subsystems (5)
PATCH 1/1 net/mlx5e: Fix potential null pointer dereference
Calls to kzalloc() and kvzalloc() should be null-checked in order to avoid any potential failures. In this case, a potential null pointer dereference.
Fix this by adding null checks for _parse_attr_ and _flow_ right after allocation.
Addresses-Coverity-ID: 1497154 ("Dereference before null check")
--- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +6 -4
@@ -4534,20 +4534,22 @@ mlx5e_alloc_flow(struct mlx5e_priv *priv, int attr_size,struct mlx5e_tc_flow_parse_attr *parse_attr;struct mlx5_flow_attr *attr;struct mlx5e_tc_flow *flow; -int out_index, err; +int err = -ENOMEM ; +int out_index; flow =kzalloc (sizeof (*flow),GFP_KERNEL ); parse_attr =kvzalloc (sizeof (*parse_attr),GFP_KERNEL ); +if (!parse_attr || !flow) + goto err_free; flow->flags = flow_flags; flow->cookie = f->cookie; flow->priv = priv; attr =mlx5_alloc_flow_attr (get_flow_name_space (flow)); -if (!parse_attr || !flow || !attr) { - err = -ENOMEM ; +if (!attr) goto err_free; - } + flow->attr = attr;for (out_index =0 ; out_index <MLX5_MAX_FLOW_FWD_VPORTS ; out_index++)
Signature · 1 line
2.27.0
Quoted 7 lines · Gustavo A. R. Silva
Calls to
kzalloc()andkvzalloc()should be null-checked in order to avoid any potential failures. In this case, a potential null pointer dereference.Fix this by adding null checks for _parse_attr_ and _flow_ right after allocation.
Quoted 7 lines
Addresses-Coverity-ID: 1497154 ("Dereference before null check")
Fixes c620b772152b ("net/mlx5: Refactor tc flow attributes structure")Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
Thanks,
Saeed Mahameed
AppliedQuoted 4 lines · Gustavo A. R. Silva
Calls to
kzalloc()andkvzalloc()should be null-checked in order to avoid any potential failures. In this case, a potential null pointer dereference.
Quoted 9 lines
Fix this by adding null checks for _parse_attr_ and _flow_ right after allocation.
Addresses-Coverity-ID: 1497154 ("Dereference before null check")
Fixes c620b772152b ("net/mlx5: Refactor tc flow attributesstructure")
Signed-off-by Gustavo A. R. Silva <[email protected]>---
Applied to net-next-mlx5.
Thanks.
Quoted 8 lines · Saeed Mahameed
Quoted 7 lines · Gustavo A. R. Silva
Calls to
kzalloc()andkvzalloc()should be null-checked in order to avoid any potential failures. In this case, a potential null pointer dereference.Fix this by adding null checks for _parse_attr_ and _flow_ right after allocation.
Quoted 8 lines
Quoted 6 lines
Addresses-Coverity-ID: 1497154 ("Dereference before null check")
Fixes c620b772152b ("net/mlx5: Refactor tc flow attributesstructure")
Signed-off-by Gustavo A. R. Silva <[email protected]>---
Applied to net-next-mlx5.
Thank you both. :)
--
Gustavo